Dear all,
in the if starting at line 1591 in lapdm.c there are two return, maybe you want to fix this
1591 if (!mctx.dl) { LOGP(DLAPDM, LOGL_NOTICE, "Received frame for unsupported " "SAPI %d!\n", sapi); return -EINVAL; msgb_free(msg); return -EIO; 1597 }
Regards, Loretta
-- View this message in context: http://baseband-devel.722152.n3.nabble.com/returning-twice-in-lapdm-c-tp3218... Sent from the baseband-devel mailing list archive at Nabble.com.
Hi Loretta,
On Tue, Aug 02, 2011 at 05:24:00AM -0700, screaming-pain wrote:
in the if starting at line 1591 in lapdm.c there are two return, maybe you want to fix this
thanks for pointing this out. It's great to know that somebody is reading the code, after all.
Without checking the git logs, it looks to me like a merge conflict might have been resolved the wrong way.
But actually, where did you find this? libosmocore.git only has the "return -EIO" in src/gsm/lapdm.c
Regards, Harald
Hi,
But actually, where did you find this? libosmocore.git only has the "return -EIO" in src/gsm/lapdm.c
I think it is an issue found by smatch, maybe the copy in osmocomBB was not updated yet.
It was.
But there is both in the osmocom-bb tree:
src/shared/libosmocore/src/gsm/lapdm.c src/host/layer23/src/common/lapdm.c
The latter has the problem.
Cheers,
Sylvain
Hi Sylvain and others,
On Wed, Aug 03, 2011 at 10:54:56AM +0200, Sylvain Munaut wrote:
But there is both in the osmocom-bb tree:
src/shared/libosmocore/src/gsm/lapdm.c src/host/layer23/src/common/lapdm.c
The latter has the problem.
I think if there still is code in osmocom-bb that uses a private copy, it should be updated to use the code from libosmocore/libosmogsm instead.
We really don't want to have copies lying around.
Hi all,
hehe, I read the code every day, I don't always understand it though :)))
Anyway, as Sylvain pointed out that bit of code is in src/host/layer23/src/common/lapdm.c
Have a good day, Loretta
-- View this message in context: http://baseband-devel.722152.n3.nabble.com/returning-twice-in-lapdm-c-tp3218... Sent from the baseband-devel mailing list archive at Nabble.com.
I fear you don't have the time, but we'd definitely appreciate if somebody put some documentation in the wiki abou the structure of the software. many years ago i wrote a document about the journey of a packet through the linix kernel network stack. It helped me a lot to fully understand it myself...
Regards -- Sent from a mobile device, excuse my short response
Harald Welte-3 wrote:
I fear you don't have the time, but we'd definitely appreciate if somebody put some documentation in the wiki abou the structure of the software. many years ago i wrote a document about the journey of a packet through the linix kernel network stack. It helped me a lot to fully understand it myself...
It's a nice idea, I would like to do something like that, may be it will not be exhaustive but I will try to write down something when I will have some spare time.
Regards, Loretta
-- View this message in context: http://baseband-devel.722152.n3.nabble.com/returning-twice-in-lapdm-c-tp3218... Sent from the baseband-devel mailing list archive at Nabble.com.
baseband-devel@lists.osmocom.org
-
Harald Welte -
Holger Hans Peter Freyther -
screaming-pain -
Sylvain Munaut