Hi,
When building osmocombb with an updated src/shared/libosmocore (0.3.6) the build fails due to make attempting to build utils/osmo-arfcn.c for build-target which does not have stdio.
I have no patch as I was not sure what the preferred way to solve it is. Maybe a --disable-utils like for tests?
Best regards,
Job
make[3]: Entering directory `osmocom-bb/src/shared/libosmocore/build-target/utils' CC osmo-arfcn.o ../../utils/osmo-arfcn.c: In function 'arfcn2freq': ../../utils/osmo-arfcn.c:43: warning: incompatible implicit declaration of built-in function 'fprintf' ../../utils/osmo-arfcn.c:43: error: 'stderr' undeclared (first use in this function)
On Sat, Aug 20, 2011 at 10:10:44PM +0200, Job wrote:
Hi,
When building osmocombb with an updated src/shared/libosmocore (0.3.6) the build fails due to make attempting to build utils/osmo-arfcn.c for build-target which does not have stdio.
I have no patch as I was not sure what the preferred way to solve it is. Maybe a --disable-utils like for tests?
I think we should introduce something like "--enable-embedded" as one global setting that would unify the following parts: * disable tests (so far: --disable-tests) * disable msgfile (so far: --disable-msgfile) * disable plugins (so far: --disable-plugin) * disable utilities (no way to disable so far)
so you can remove the --disable-{tests,msgfile,plugin} and simply replace it with the new --enable-embedded.
I'd be happy to merge a patch that takes care of this (as well as the osmocom-bb/src/Makefile changes related to it)
Regards, Harald
Hi,
I'd be happy to merge a patch that takes care of this (as well as the osmocom-bb/src/Makefile changes related to it)
While working on a patch I noticed an autoconf error in libosmocore:
$ autoreconf -i Makefile.am:20: docdir was already defined in condition TRUE, which includes condition HAVE_DOXYGEN ... configure.ac:1: ... `docdir' previously defined here
using autoconf 2.67 and automake 1.11.1
My autoconf knowledge is limited, but could it be that docdir is autogenerated from including doxygen or something?
configure has docdir now defined as --docdir=DIR documentation root [DATAROOTDIR/doc/libosmocore]
which is different from the requested define in Makefile.am: docdir=$(datadir)/doc
Best regards,
Job
Hi,
While further investigating the autoconf aspects of libosmcocore I ran into some counter intuitive use of the conditional options. It seems they are not implemented in the expected way.
I guess the intention of --disable-feature is that you can also say --enable-feature (even if this is the default) or that --enable-feature=no should work as this is a standard behavior of configure. In the current use of the AC_ARG_ENABLE macro this fails. According to http://www.flameeyes.eu/autotools-mythbuster/autoconf/arguments.html the action-if-present and action-if-not-present should not be used in this way. Shall I modify this in a separate patch?
I think we should introduce something like "--enable-embedded" as one global setting that would unify the following parts:
- disable tests (so far: --disable-tests)
- disable msgfile (so far: --disable-msgfile)
- disable plugins (so far: --disable-plugin)
- disable utilities (no way to disable so far)
What about --disable-vty --enable-panic-infloop --disable-shared --disable-talloc
That are now also part of the build-target configure options?
Best regards,
Job
baseband-devel@lists.osmocom.org
-
Harald Welte -
Job -
Sylvain Munaut