Hi,
when I tried to read the secure-romloader of an Alcatel VLE5-series phone, I noticed a small bug in calypso_bootrom(), which prom already tried to fix, but his fix only worked on targets which have nIBOOT tied to high (Compal).
I've committed a fix for this to steve-m/pending.
Regards, Steve
Hi Steve,
On Sat, Apr 10, 2010 at 02:25:58AM +0200, Steve Markgraf wrote:
when I tried to read the secure-romloader of an Alcatel VLE5-series phone, I noticed a small bug in calypso_bootrom(), which prom already tried to fix, but his fix only worked on targets which have nIBOOT tied to high (Compal).
I've committed a fix for this to steve-m/pending.
thanks, I've merged it. One minor comment: Your commitlog lines seem awfully long, I would like to ask you to wrap them in a format similar as it is used in e-mail messages (at 72..80 characters) in the future. Thanks for your consideration.
Regards, Harald
Hi Harald,
Harald Welte wrote:
One minor comment: Your commitlog lines seem awfully long, I would like to ask you to wrap them in a format similar as it is used in e-mail messages (at 72..80 characters) in the future. Thanks for your consideration.
Thanks for your advice, I'll take that in regard on further commits.
Steve
baseband-devel@lists.osmocom.org
-
Harald Welte -
Steve Markgraf