9 Jul
2012
9 Jul
'12
9:27 p.m.
Nico Golde wrote:
+static void retry_sync(void)
+{
+ exit_sync();
+ toggle_dcs_pcs();
+ enter_sync();
+}
+
hi nico,
i see 2 problems:
why do you toggle dcs/pcs? if you select dcs (default), but like to sync
to pcs, just push the function key, then sync.
if no sync is possible at all, your patch ends up in an endless loop.
(or am i wrong?)
regards,
andreas
10 Jul
10 Jul
12:03 p.m.
New subject: [PATCH] firmware/rssi: attempt to resync on sync errors
Hi,
* Andreas Eversberg <andreas(a)eversberg.eu> [2012-07-10 11:59]:
Nico Golde wrote:
To be honest, for a very pragmatic reason. I never
successfully resynced without toggling the pcs if I just
call enter_sync() in a loop.
+static void retry_sync(void)
+{
+ exit_sync();
+ toggle_dcs_pcs();
+ enter_sync();
+}
+
i see 2 problems:
why do you toggle dcs/pcs? if you select dcs (default), but like to
sync to pcs, just push the function key, then sync. if no sync is possible at all, your patch ends up in
an endless loop.
(or am i wrong?)
Yes but the key handler to leave the loop is still working.
Maybe it would be a better solution to set a timer and a
retry attempt counter and stop this after n attempts. For me
this endless loop was sufficient for now.
Cheers
Nico
4769
days inactive
4770
days old
baseband-devel@lists.osmocom.org
1 comments
2 participants
participants (2)
-
Andreas Eversberg -
Nico Golde