Hi all,
On Mon, Feb 20, 2012 at 09:27:18PM +0100, Peter Stuge wrote:
And we have to maintain compatibility in libosmocore as much as possible if we don't want to break everything that calls telnet_init, so I would recommend introducing a new telnet_init_ex ? that takes the added parameter and keep telnet_init as compatibility.
Are there many uses of telnet_init which can not be fixed very quickly?
the problem with fre software is that you never know ;)
At least in openbsc/cellmgr-ng/osmo-sgsn/osmo-nitb/osmo-bsc_mgcp, etc. they all use the existing function. Also, we really want to avoid the situation where older versions of openbsc suddenly don't work with a later version of libosmocore.
I agree that non-local-binding should have been implemented a long time ago. Usinga 'char *' for the ip/hostname is also the right thing to do. However, please don't introduce ipv4 assumptions unless required, so using proper getnameinfo would make sense.
It would also be a good time to start using the general socket helper code of libosmocore (osmo_sock_init/osmo_sock_init_ofd) to remove code duplication. A patch along those lines would be appreciated.
Regards, Harald