Hi,
On Sun, Jan 6, 2013 at 12:34 AM, Sylvain Munaut 246tnt@gmail.com wrote:
Hi,
This a respin of my old series of patches[1], to add decoding of SMSCB messages on the MS side.
Before I dig deeper, a quick question:
Why in libosmocore ? This implementation is MS side only right ? so can't be re-used to implement smscb in OpenBSC or OsmoBTS.
Inertia would be one reason -- since my first patchset, LAPDm has moved from BB into libosmocore, so I just tagged along.
On the practical side, I see two reasons now:
i) if we want to hook it into LAPDm, it needs to be where lapdm.c is
ii) libosmocore has a testsuite, so I could just stuff some testcases in there
In the future, we can also add the BTS-side implementation. I don't think they can share much code, but it might make sense to have both in the same place.
I can spin a patch series directly on top of osmocom-bb, but the testcases will probably not make it.
Thanks, Alex