12 May
2011
12 May
'11
2:58 a.m.
On Thu, 2011-05-12 at 08:48 +0200, Harald Welte wrote:
Hi Gianni,
On Thu, May 12, 2011 at 03:27:15AM +0100, Gianni Tedesco wrote:
No, I wasn't aware of that, I'll check it out.
I am planning to progress this work by sending back the CP-ACK, adding
an API so that the SMS can be "delivered" via a function pointer
somwhere and provide another API to send the RP-ACK +
SMS-DELIVER-REPORT. I think that should complete it? But I'm only just
getting familiar with the specs.
Will re-submit when I make the relevant changes.
Thanks for the feedback
Gianni
Attached patch implements SMS decoding.
are you aware that we already have 7bit decoding routines in libosmogsm,
as well as other SMS parsing code in OpenBSC? I would prefer if we have
one implementation that is in the shared library and re-used by all the
various Osmocom projects.
Maybe the existing routines are not suitable right-away, then they
should be adapted. But two implementations for the same task doesn't
sound like a good solution to me.