Hi,
I think it'd be useful to split the kasumi impl in its own file, so that we can use it to implement GEA3 GPRS cipher as well.
I'd do that in 2nd version of a patch: both Kasumi and KGcore functions are shared so it make sense.
Also, please put any internal method as 'static' so we can avoid polluting the namespace.
please note that there is already a libosmo-crypt-a53 (http://cgit.osmocom.org/cgit/libosmo-crypt-a53) which implements A5/3 and GEA3. However, it's based on the reference code, which may be problematic to distribute.
Awesome, I can use it for easier testing :) Is there build instructions somewhere? Has it bean tested against actual phones?
It's automake ...
I think GEA3 has been tested, but not A5/3. It's doesn't even integrate with the osmo_a5(...) functions.
GPRS cipher and Auth use a sort of plugin system, mostly because the algorithm used in there are still secret and so implementation is sometime provided by external devices / libraries / processes. For the A5/x ciphers, they're all public so they use direct linking and not a dynamic plugin system.
Cheers,
Sylvain