Sylvain Munaut wrote:
Unfortunately, it's changing libosmocore, so that makes it a whole lot more complex because you can't change the "shared" directory directly, we need to make the change to libosmocore then import the new libosmocore into the osmocom-bb git.
Yes, good point.
And we have to maintain compatibility in libosmocore as much as possible if we don't want to break everything that calls telnet_init, so I would recommend introducing a new telnet_init_ex ? that takes the added parameter and keep telnet_init as compatibility.
Are there many uses of telnet_init which can not be fixed very quickly?
Harald / Holger ? Do you see better ways to handle this sort of case ?
For a "locked" API there's no other way.. Either get the API right the first time, or pass an extensible set of options. The former is nice and neat, the latter is a little more complicated.
I think adding a new function is fine, but maybe choose a more descript name than just the _ex suffix? :)
//Peter