2 Jan
2013
2 Jan
'13
4:14 p.m.
Hi,
Please find attached a patch to cell_log that allows a
user to specify a
custom frequency range instead of the standard one.
Thanks.
In the past I've done the same job changing the
code by hand and
recompiling, but a command line switch is more feasible.
This is useful when one wants to monitor a subset of arfcns (like in GSM900)
or even a single one.
Indeed, looks like a very useful functionality.
Any comment appreciated.
- print_band_range & parse_band_range should be static
- Check coding style rules, (tab vs space). We use the kernel coding
style (which you can view in the kernel tree under
Documentation/CodingStyle )
I'm not a fan of the method used to pass the new range, but I can't
think of anything better so good enough. I'm not exactly sure why the
app is split into two files to begin with.
Cheers,
Sylvain