Hi Max,
@ttsou, you're pretty familiar with LTE right ? Can you give it a quick look just to get a second opinion. (mine is pretty useless as my lte knowledge is near zero).
diff --git a/include/osmocom/core/gsmtap.h b/include/osmocom/core/gsmtap.h index c1c53d0..5d4755b 100644 --- a/include/osmocom/core/gsmtap.h +++ b/include/osmocom/core/gsmtap.h @@ -43,7 +43,7 @@ #define GSMTAP_TYPE_GMR1_UM 0x0a /* GMR-1 L2 packets */ #define GSMTAP_TYPE_UMTS_RLC_MAC 0x0b #define GSMTAP_TYPE_UMTS_RRC 0x0c
+#define GSMTAP_TYPE_LTE_RRC 0x0d
The '-' is an unecessary whitespace change.
/* ====== DO NOT MAKE UNAPPROVED MODIFICATIONS HERE ===== */
+#define GSMTAP_LTE_CH_BCCH 0x01 +#define GSMTAP_LTE_CH_CCCH 0x02 +#define GSMTAP_LTE_CH_DCCH 0x03 +#define GSMTAP_LTE_CH_MCCH 0x04 +#define GSMTAP_LTE_CH_PCCH 0x05 +#define GSMTAP_LTE_CH_SCH 0x06
#define GSMTAP_UMTS_CH_PCCH 0x01 #define GSMTAP_UMTS_CH_CCCH 0x02 #define GSMTAP_UMTS_CH_DCCH 0x03
1) I'd add a new separate section witht ehe " ==== ..." marker before / after and put it after the UMTS section to keep the order. Also add the same comment that those are for the GSMTAP_TYPE_LTE_RRC (look at the UM / TETRA / GMR section).
2) tab vs space for alignement of the values
Cheers,
Sylvain