18.03.2014 07:37, Sylvain Munaut пишет:
When inserting new line, I think trying to keep them alphabetically sorted by group is a nice touch. It doesn't matter here and no real need to change it, but it's just as a general remark for future patches or changes.
I personally think grouping by similarity in function or style have more aesthetic value :)
Any particular reason you went with this completely generic approach rather than just handling the few cases manually ? There is only a few of them.
This is purely informational. I've confirmed that with -O2 the code is 'decent'. and with -O3 it's completely equivalent to hardcoded shift like they were before in msgb.
It seems more readable this way, also copy-pasting and adjusting lots of similar but slightly different "boring" code proved to be error-prone.
thanks, Max.