Hi, * Tomcsányi, Domonkos domi@tomcsanyi.net [2015-04-23 18:12]: [...]
It seems like there was no movement in this topic in the last couple of years, so I decided to go ahead and integrate Nico's SAP client into the current master branch and created a patch from it.
Cool, great work!
One thing however that I think is strange, and worth mentioning: I'm not sure why Nico decided to implement the switch between phone and SAP-client inside of l1ctl.c, for me it would feel better to do it in sim.c (since sim.c deals with SIM activities, l1ctl should deal only with L1 stuff...also the current SAP client calls back to sim.c, but receives data from l1ctl - little bit confusing), but I left it as is because of not knowing exactly the thoughts behind it.
I don't remember details to be honest as this is too long ago, but I think there was no real design decision behind this other than that the code that is sending traffic to the SIM was already in l1ctl and I just added the switch...
Cheers, Nico