Re: modulo and frame number in mframe_sched.c

Hi Max, On Wed, Oct 17, 2012 at 08:21:59PM +0200, ☎ wrote: On ARM, it doesn't matter. even if you made those fields uint8_t in the struct mframe_sched_item, they would still be aligned to 32bit boundaries. So you wouldn't change the memory layout at all based on your change. If you really wanted to save memory, then you would have to make the struct packed. This in turn would mean that accesses to the structure members would be unaligned accesses, around which the compiler has to work around by bit-shifting. So you save some memory at the expense of increasing code size (and execution time). Given that the CPU speed is more limited than RAM, I think the current approach makes sense. see above. I don't think so, at least not for standard GSM operation. frame_nr can never be bigger than 'modulo'. -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)