06.12.2012 14:41, Sylvain Munaut пишет:
Hi,
I think it'd be useful to split the kasumi impl in its own file, so that we can use it to implement GEA3 GPRS cipher as well.
I'd do that in 2nd version of a patch: both Kasumi and KGcore functions are shared so it make sense.
Also, please put any internal method as 'static' so we can avoid polluting the namespace.
Done.
I still didn't managed to make it work with phones but now patch is split into logical parts so I hope at least some of the code will be useful.
I've tried to compile libosmo-crypt-a53 but got multitude of errors like:
configure.in:5: error: possibly undefined macro: AM_INIT_AUTOMAKE If this token and others are legitimate, please use m4_pattern_allow. See the Autoconf documentation. configure.in:15: error: possibly undefined macro: AC_PROG_LIBTOOL configure.in:35: error: possibly undefined macro: AM_CONFIG_HEADER
and
./configure day 341, Четверг 0\0\ ./configure: line 1979: syntax error near unexpected token `dist-bzip2' ./configure: line 1979: `AM_INIT_AUTOMAKE(dist-bzip2)'
Anyway, this is exactly version from standards against which I've already tested mine. I do not want to add any test vectors until I make the code compatible with real phones.