osmocom-net-gprs

osmocom-net-gprs@lists.osmocom.org

1 participants
483 discussions

RE: osmo-pcu[master]: Add data structure for ARQ-II in EGPRS DL
by Aravind Sirsikar 24 Jun '16

24 Jun '16

Hi Holger, >Line 130: GprsCodingScheme cs_current_trans; >I would prefer to cs and cs_current_trans being private here. The cs_current_trans is made public to align with existing variables like block[RLC_MAX_LEN], len and others to have consistency. will it make sense to have cs and cs_current_trans as private?. We can rename cs to cs_last_tx as suggested in review of other patch. But it will have modification in other source files to address compilation errors. Thanks, Aravind Sirsikar

2 2

conversations in gerrit "lost" here
by Neels Hofmeyr 21 Jun '16

21 Jun '16

I am a bit ambiguous on our use of comments in gerrit. We do discuss at least some fairly interesting things in the comments on patches waiting for approval in gerrit. When these discussions are attempted on openbsc@ or osmocom-net-gprs@, you tend to block off and redirect the discussion back to the gerrit comments infrastructure. However, we have moved the gerrit mails to a separate and very noisy mailing list, and these potentially interesting discussions are moved essentially out of the public focus. Also, if we in future would like to investigate discussion on some topic, we need to search both the main ML and the gerrit ML. IMHO it would make sense to copy the human originated comments to our "human" mailing lists, so that the automatic jenkins and gerrit notifications remain on the noisy ML while we see all discussions here. Is that easy to achieve (filter on originator of comment), and would you guys agree? ~Neels -- - Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte

1 0

gerrit and branches
by Neels Hofmeyr 20 Jun '16

20 Jun '16

Today I've taken another close look at branches and gerrit, and have written down my conclusions here: http://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit#Submitting-… In summary: * Branch re-submission needs the workaround of tweaking the first commit. It would be nice to fix gerrit to not need this, but for the time being the effort of cosmetically changing the first commit log is acceptable. * It *is* possible to have private branches in the gerrit repos and still be able to submit them to master, with the proper project config. I have thus switched all our gerrit projects' configs to rebase-if-necessary with the flags as described on the wiki page. (Except for osmo-pcap, where we still disallow content merges.) I will now go back to pushing my "private" developments to the public repository (gerrit) under the neels/ or sysmocom/ namespaces. ~Neels -- - Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte

2 4

testing gerrit, might be down shortly
by Neels Hofmeyr 20 Jun '16

20 Jun '16

I'm testing things related to our gerrit bug report, if it's not working for you right now it may be because I'm restarting gerrit to test with/out our fix. I'll repost when I'm done. ~Neels -- - Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte

1 1

[EGPRS PCU] ARQ-2 support for EGPRS DL Retransmission
by Aravind Sirsikar 20 Jun '16

20 Jun '16

Hi, I have pushed series of patches related to ARQ-2 support for EGPRS DL Retransmission. This patches have been reviewed earlier and comments have been Addressed. These patches are tested and validated with NuRAN 1.0 hardware. Below are the links to Gerrit review of each patches along with patch description. 1) https://gerrit.osmocom.org/#/c/332/ ==>Add data structure for ARQ-II in EGPRS DL. 2) https://gerrit.osmocom.org/#/c/333/ ==>Add Accessor functions for ARQ-II in EGPRS DL. 3) https://gerrit.osmocom.org/#/c/334/ ==>Modify DL tbf flow for ARQ-II in EGPRS DL Retx. 4) https://gerrit.osmocom.org/#/c/335/ ==>Add test cases to support ARQ-II for EGPRS DL Retx. Above patches must be merged to master in the same order as mentioned above. Thanks, Aravind Sirsikar

2 1

RE: [MERGED] osmo-pcu[master]: Add test cases for Header Type 2 in EGPRS UL
by Aravind Sirsikar 17 Jun '16

17 Jun '16

Hi Holger, > Holger Freyther: Looks good to me, approved In http://git.osmocom.org/osmo-pcu, one of the 5 patches submitted for Gerrit review(MCS5-MCS9 support in EGPRS UL)has been merged to master. As this patch is part of series of 5 patches it should be merged in below order. 1) Remove GMSK only check in EGPRS UL(Change-Id:I567acc012d8ad49681715f0104ba7e91625e1e7a) 2) Add Header Type2 support in EGPRS UL(Change-Id:Iac2422c8acbdcefe20aafbba6a4eb87c9893e3ba) 3) Add header type 1 support for EGPRS uplink(Change-Id:I13c250e2e07377982ac3f29745f3cffd4088552a) 4) Add test cases for Header Type 2 in EGPRS UL(Change-Id:I1dd46010065a6d6da21e8e45af71e6d5f649b0b0) 5) Add test cases for Header type1 in EGPRS UL(Change-Id:I21811bb126dbe151b0708a964d3143bc2fd52389) Currently osmo-pcu build is failing since only patch 4 of the list above has been merged. Can you please let me know how to proceed over this? Going forward it will be helpful for us if you can suggest how to number the patches of a series in Gerrit review. Thanks, Aravind Sirsikar

5 6

[EGPRS] Gerrit guidance to address Jenkins Build failure and resubmission of patch.
by Aravind Sirsikar 17 Jun '16

17 Jun '16

Hi, Can you guide us to address issues we are currently facing about Gerrit process as listed below 1) Jenkins Build reports failure. Can you suggest the reason for this. Because in our local branch the Unit test and build is successful. 2) Is there any specific process to resubmit patch after addressing the review comments. Thanks, Aravind Sirsikar

5 12

Issue seen in decoding compressed bitmap in EPDAN
by Prasad Kaup 15 Jun '16

15 Jun '16

Hello, During testing with latest master osmo-pcu, we see that there is an issue in decoding of compressed bitmap with make-up code in EPDAN Input to decoding algorithm: Compressed bitmap array : 0x7a,0x28,0x31,0xe1,0xf1,0xc1,0x6c,0x32,0x87 Starting colour code : 1 Length : 72 Expected output ( Refer 3GPP 44.060 section 9.1.10): Expected decoded Length: 304 Expected Uncompressed bitmap: dd c1 48 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 01 Actual output: Actual decoded length :292 Actual Uncompressed bitmap: dd c1 48 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 Regards Prasad

2 1

[EGPRS] Radisys planned activities for EGPRS
by Aravind Sirsikar 08 Jun '16

08 Jun '16

Hello All, We at Radisys have started working on EGPRS performance analysis and stability testing on NuRAN LiteCell 1.0. Below are the High level Items we have planned. 1) EGPRS Performance benchmarking analysis and optimization 2) CPU and Memory benchmarking and analysis 3) EGPRS multi user tests, Stability, Stress and Soak testing We will keep sharing the relevant patches as well as bench marking report to the mailing list for seeking inputs and suggestion. Thanks, Aravind Sirsikar

2 1

[PATCH] gtp/queue/queue_seqdel(): fix element check which always was true
by Alexander Couzens 06 Jun '16

06 Jun '16

Iterate over all member until the correct member found, remove it and rearrange the seqnext pointer --- gtp/queue.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gtp/queue.c b/gtp/queue.c index 5b4d849..fbfa1ec 100644 --- a/gtp/queue.c +++ b/gtp/queue.c @@ -105,8 +105,7 @@ static int queue_seqdel(struct queue_t *queue, struct qmsg_t *qmsg) printf("Begin queue_seqdel seq = %d\n", (int)qmsg->seq); for (qmsg2 = queue->hashseq[hash]; qmsg2; qmsg2 = qmsg2->seqnext) { - /* FIXME: this is always true !?! */ - if (qmsg == qmsg) { + if (qmsg == qmsg2) { if (!qmsg_prev) queue->hashseq[hash] = qmsg2->seqnext; else -- 2.8.3

3 3

← Newer
1
...
30
31
32
33
34
35
36
...
49
Older →

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

osmocom-net-gprs