- gerrit-log - lists.osmocom.org

[XS] Change in osmo-asf4-dfu[master]: dfu: do not reset itself
by lynxis lazus 23 Feb '26

23 Feb '26

Attention is currently required from: Hoernchen, laforge. lynxis lazus has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42180?usp=email ) Change subject: dfu: do not reset itself ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42180?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I1b9e48470083597640918a8a1126922b31150153 Gerrit-Change-Number: 42180 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 23 Feb 2026 19:47:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: BSSAP_LE_Emulation: Increase timeout in f_bssap_le_wait_sccp_peer_ava...
by laforge 23 Feb '26

23 Feb '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42181?usp=email ) Change subject: BSSAP_LE_Emulation: Increase timeout in f_bssap_le_wait_sccp_peer_available() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42181?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2d4210bf5785a09bf384a1534c407dcf63b1c38b Gerrit-Change-Number: 42181 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Feb 2026 19:41:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-asf4-dfu[master]: dfu: do not reset itself
by Hoernchen 23 Feb '26

23 Feb '26

Attention is currently required from: Hoernchen, laforge, lynxis lazus. Hello Jenkins Builder, laforge, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42180?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by laforge Change subject: dfu: do not reset itself ...................................................................... dfu: do not reset itself In theory USB_DFU_ATTRIBUTES_WILL_DETACH is nice, in practice not so much, because usb uses control transfers and "waiting" for status response completion after finishing flashing is cumbersome. There is basically no advantage if the device resets itself, and just waiting for the host to do it like most DFU devices (and what the BL used to do in the beginning) works around the status issue. Right now dfu-utils is unhappy because the final get status never is answered because the response is submitted by the device, but the self reset immediately afterwards is faster, so it never arrives at the host. Change-Id: I1b9e48470083597640918a8a1126922b31150153 --- M usb/class/dfu/device/dfudf_desc.h 1 file changed, 5 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-asf4-dfu refs/changes/80/42180/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42180?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I1b9e48470083597640918a8a1126922b31150153 Gerrit-Change-Number: 42180 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in pysim[master]: personalization: add get_typical_input_len() to ConfigurableParameter
by laforge 23 Feb '26

23 Feb '26

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40202?usp=email ) Change subject: personalization: add get_typical_input_len() to ConfigurableParameter ...................................................................... Patch Set 7: Code-Review+1 (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/40202/comment/e12f41c3_e58a7843?usp=em… : PS7, Line 270: def get_typical_input_len(cls): I wish there was an @classproperty to avoid the awkward get_... methods in favor of accessing a property. However, it seems there are only instance properties, not class properties in python3. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40202?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2568a032167a10517d4d75d8076a747be6e21890 Gerrit-Change-Number: 40202 Gerrit-PatchSet: 7 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Feb 2026 17:38:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bts[master]: RTP: add vty option for ortp vs twrtp selection
by falconia 23 Feb '26

23 Feb '26

Attention is currently required from: pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/42167?usp=email ) Change subject: RTP: add vty option for ortp vs twrtp selection ...................................................................... Patch Set 3: (1 comment) File src/common/vty.c: https://gerrit.osmocom.org/c/osmo-bts/+/42167/comment/82ce0e6d_def4be19?usp… : PS3, Line 427: vty_out(vty, " rtp library %s%s", bts->use_twrtp ? "twrtp" : "ortp", > write it only in case the non-default option is selected, see https://osmocom. […] Yes, I will make this change. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42167?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iff4e3a399250c16ba8fe4cb12e4e22f4c6b346ec Gerrit-Change-Number: 42167 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Feb 2026 17:37:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-bts[master]: RTP: use new abstraction layer instead of direct osmo_ortp
by falconia 23 Feb '26

23 Feb '26

Attention is currently required from: pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/42166?usp=email ) Change subject: RTP: use new abstraction layer instead of direct osmo_ortp ...................................................................... Patch Set 2: (3 comments) File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/42166/comment/590d9c83_6f510fb2?usp… : PS2, Line 2329: lchan_osmux_skipped_frame(lchan, fn_ms_adj(fn, lchan)); > fn_ms_adj is also called here, so feel free to put fn_ms_adj above and modify this function too sinc […] Will do in the next patch revision. For consistency, I will also make the same change in `send_ul_rtp_packet()`. File src/common/lchan.c: https://gerrit.osmocom.org/c/osmo-bts/+/42166/comment/12657874_2662996f?usp… : PS2, Line 590: false, bts->twjit_cfg); > align to "(", like done eveyrwhere else. Will do. https://gerrit.osmocom.org/c/osmo-bts/+/42166/comment/84ecec2b_18be186b?usp… : PS2, Line 641: ia, connect_port); > ah so osmo_rtp_socket_connect() actually got a string, and you are converting now this param into an […] I would like to push back against making this change as part of the present patch - instead it should be done after ortp is fully removed and we are ready to begin the process of IPv6-ifying twrtp-based OsmoBTS. See my comment in the IPv6 thread on the previous patch in the series. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42166?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5e3de4f84e8e8875437cb94a9b8feeb07f9cc1cf Gerrit-Change-Number: 42166 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Feb 2026 17:36:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in pysim[master]: personalization: make AlgorithmID a new EnumParam
by laforge 23 Feb '26

23 Feb '26

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40201?usp=email ) Change subject: personalization: make AlgorithmID a new EnumParam ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: now if we still don't fix asn1tools and want to work around here, I would argue that anything representing an enum should be based on enum (either inheritance or by having a member variable of that type) from the standard library: https://docs.python.org/3/library/enum.html -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40201?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I71c2ec1b753c66cb577436944634f32792353240 Gerrit-Change-Number: 40201 Gerrit-PatchSet: 7 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Feb 2026 17:27:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in osmo-bts[master]: RTP: implement RTP socket abstraction layer
by falconia 23 Feb '26

23 Feb '26

Attention is currently required from: laforge, pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/42165?usp=email ) Change subject: RTP: implement RTP socket abstraction layer ...................................................................... Patch Set 3: (3 comments) File include/osmo-bts/rtp_abstract.h: https://gerrit.osmocom.org/c/osmo-bts/+/42165/comment/67b2c486_e87d3db7?usp… : PS3, Line 50: struct sockaddr_in local_addr; > struct osmo_sockaddr, so we support IPv6 too. Please see my comment in the main IPv6 thread. File src/common/rtp_abstract.c: https://gerrit.osmocom.org/c/osmo-bts/+/42165/comment/71eace29_d84d4bce?usp… : PS3, Line 97: rc = inet_aton(ipstr, &rs->local_addr.sin_addr); > osmo_sockaddr_from_str_and_uint(), so we support ipv6 too. Please see my comment in the main IPv6 thread. https://gerrit.osmocom.org/c/osmo-bts/+/42165/comment/35da20e9_b0cc73e9?usp… : PS3, Line 109: const struct in_addr *ip, uint16_t port) > well, I think the Abis-over-IP protocol doesn't even contain features to use IPv6 addresses for the […] I don't know whether ortp itself supports IPv6 or not - perhaps it does, especially in later versions - but the important bit is that osmo_ortp layer used by OsmoBTS is IPv4 only, and so is all existing OsmoBTS code operating on that "RTP socket" layer. I would like to push back on Pau's demand to sprinkle osmo_sockaddr into the present patch and the one that follows, in places where these constructs were never used before. The "RTP abstraction layer" introduced here is purely internal to OsmoBTS application, it is not any kind of actual library, hence there are no stable API or ABI considerations of any kind. In the spirit of each individual patch changing one thing at a time, if conversion to IPv6-capable intra-OsmoBTS APIs is desired, it should be separate from the present patch which merely expands RTP library support from osmo_ortp only to either osmo_ortp or osmo_twrtp. Also if expansion to IPv6-capable operation is desired, it should probably be done after the already planned full removal of ortp, rather than before, to reduce complexity. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42165?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic945f6d753ec7f5c0ac5cecc9f71049464de7e8f Gerrit-Change-Number: 42165 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Feb 2026 17:26:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in pysim[master]: personalization: indicate default ParamSource per ConfigurableParameter
by laforge 23 Feb '26

23 Feb '26

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40200?usp=email ) Change subject: personalization: indicate default ParamSource per ConfigurableParameter ...................................................................... Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40200?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie58d13bce3fa1aa2547cf3cee918c2f5b30a8b32 Gerrit-Change-Number: 40200 Gerrit-PatchSet: 8 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Feb 2026 17:12:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: personalization: allow reading back multiple values from PES
by laforge 23 Feb '26

23 Feb '26

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40199?usp=email ) Change subject: personalization: allow reading back multiple values from PES ...................................................................... Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40199?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iecb68af7c216c6b9dc3add469564416b6f37f7b2 Gerrit-Change-Number: 40199 Gerrit-PatchSet: 9 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Feb 2026 17:11:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log