- gerrit-log - lists.osmocom.org

[XS] Change in ...osmo_dia2gsup[master]: server_cb: comment out unused fields in handle_request/3

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40145?usp=email ) Change subject: server_cb: comment out unused fields in handle_request/3 ...................................................................... server_cb: comment out unused fields in handle_request/3 This fixes the following warnings: * Warning: variable 'RatType' is unused * Warning: variable 'UlrFlags' is unused Change-Id: I3b709cfc723418c1ec88d15bc25bb2cef462a4d3 --- M src/server_cb.erl 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/src/server_cb.erl b/src/server_cb.erl index 815eaf6..f51bb5c 100644 --- a/src/server_cb.erl +++ b/src/server_cb.erl @@ -287,8 +287,8 @@ % extract relevant fields from DIAMETER ULR #diameter_caps{origin_host = {OH,_}, origin_realm = {OR,_}} = Caps, #'ULR'{'Session-Id' = SessionId, - 'RAT-Type' = RatType, - 'ULR-Flags' = UlrFlags, +%% XXX 'RAT-Type' = RatType, +%% XXX 'ULR-Flags' = UlrFlags, 'User-Name' = UserName} = Req, % construct GSUP UpdateLocation request to HLR and transceive it; expect InsertSubscrDataReq -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40145?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I3b709cfc723418c1ec88d15bc25bb2cef462a4d3 Gerrit-Change-Number: 40145 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[XS] Change in ...osmo_dia2gsup[master]: osmo_dia2gsup: remove unused start/0

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40146?usp=email ) Change subject: osmo_dia2gsup: remove unused start/0 ...................................................................... osmo_dia2gsup: remove unused start/0 This function is not used anywhere. It's also not consistent with the start_link/0, which is starting the gen_server instance. Change-Id: Ibd4e1d86dc59d792f7f6ac027ee63fc2086b31c3 --- M src/osmo_dia2gsup.erl 1 file changed, 1 insertion(+), 5 deletions(-) Approvals: pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo_dia2gsup.erl b/src/osmo_dia2gsup.erl index cda616b..47ca2a4 100644 --- a/src/osmo_dia2gsup.erl +++ b/src/osmo_dia2gsup.erl @@ -40,7 +40,7 @@ % API -export([start_link/0]). --export([start/0, stop/0]). +-export([stop/0]). % gen_server callbacks -export([init/1, handle_call/3, handle_cast/2, handle_info/2]). @@ -80,10 +80,6 @@ start_link() -> gen_server:start_link({local, ?SERVER}, ?MODULE, [], []). -start() -> - application:ensure_all_started(?MODULE), - start_link(). - stop() -> gen_server:cast(?SERVER, stop). -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40146?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: Ibd4e1d86dc59d792f7f6ac027ee63fc2086b31c3 Gerrit-Change-Number: 40146 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[XS] Change in ...osmo_dia2gsup[master]: rebar.{config,lock}: bump lager version: 3.9.1 -> 3.9.2

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40144?usp=email ) Change subject: rebar.{config,lock}: bump lager version: 3.9.1 -> 3.9.2 ...................................................................... rebar.{config,lock}: bump lager version: 3.9.1 -> 3.9.2 This fixes tons of false-positive "a term is constructed, but never used" warnings. For more details, see: https://github.com/erlang-lager/lager/issues/546 https://github.com/erlang-lager/lager/pull/547 Change-Id: Id17900cb1b6fbcd6fbc13d16b90b67b82342accb --- M rebar.config M rebar.lock 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: osmith: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/rebar.config b/rebar.config index 455fd6c..48b78f7 100644 --- a/rebar.config +++ b/rebar.config @@ -2,7 +2,7 @@ {deps, [ {setup, "2.0.2"}, - {lager, {git, "https://github.com/erlang-lager/lager", {tag, "3.9.1"}}}, + {lager, {git, "https://github.com/erlang-lager/lager", {tag, "3.9.2"}}}, {osmo_ss7, {git, "https://gitea.osmocom.org/erlang/osmo_ss7", {branch, "master"}}}, {osmo_gsup, {git, "https://gitea.osmocom.org/erlang/osmo_gsup", {branch, "master"}}} ]}. diff --git a/rebar.lock b/rebar.lock index 2114e56..92484a9 100644 --- a/rebar.lock +++ b/rebar.lock @@ -6,7 +6,7 @@ {<<"goldrush">>,{pkg,<<"goldrush">>,<<"0.1.9">>},1}, {<<"lager">>, {git,"https://github.com/erlang-lager/lager", - {ref,"c5447d2d85a0d446d41a79bffe0a6a66bd50c901"}}, + {ref,"459a3b2cdd9eadd29e5a7ce5c43932f5ccd6eb88"}}, 0}, {<<"osmo_gsup">>, {git,"https://gitea.osmocom.org/erlang/osmo_gsup", @@ -18,7 +18,7 @@ 0}, {<<"parse_trans">>, {git,"https://github.com/uwiger/parse_trans", - {ref,"d443908e0a8e3842c4763cefd4b37457b892c121"}}, + {ref,"d99fb36755c813a5db23e6f93741aa58323ef911"}}, 1}, {<<"pkt">>, {git,"https://github.com/msantos/pkt", -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40144?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: Id17900cb1b6fbcd6fbc13d16b90b67b82342accb Gerrit-Change-Number: 40144 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[XS] Change in ...osmo_dia2gsup[master]: osmo_dia2gsup: remove unused start/0

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40146?usp=email ) Change subject: osmo_dia2gsup: remove unused start/0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40146?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: Ibd4e1d86dc59d792f7f6ac027ee63fc2086b31c3 Gerrit-Change-Number: 40146 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Apr 2025 09:53:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months, 2 weeks

1
0
0 0

[S] Change in ...pyosmocom[master]: bump version number to 0.0.9 for construct.{Bytes,GreedyBytes}

by fixeria

Attention is currently required from: dexter, laforge. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/40118?usp=email ) Change subject: bump version number to 0.0.9 for construct.{Bytes,GreedyBytes} ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/40118?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: Id8f9e617482c487f3314118ba3df9c937d501596 Gerrit-Change-Number: 40118 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Apr 2025 08:10:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months, 2 weeks

1
0
0 0

[S] Change in ...pyosmocom[master]: osmocom.construct: Bytes + GreedyBytes with automatic hexstring-conve...

by fixeria

Attention is currently required from: dexter, laforge. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/40117?usp=email ) Change subject: osmocom.construct: Bytes + GreedyBytes with automatic hexstring-conversion ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/40117?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I59f500c925848872a7fa38d6dbf3d6ea72bc3a90 Gerrit-Change-Number: 40117 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Apr 2025 08:10:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months, 2 weeks

1
0
0 0

[XS] Change in ...osmo_dia2gsup[master]: osmo_dia2gsup: remove unused start/0

by osmith

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40146?usp=email ) Change subject: osmo_dia2gsup: remove unused start/0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40146?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: Ibd4e1d86dc59d792f7f6ac027ee63fc2086b31c3 Gerrit-Change-Number: 40146 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Apr 2025 08:08:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months, 2 weeks

1
0
0 0

[S] Change in upf-benchmark[master]: osmo-upf-load-gen: Allow setting local PFCP port

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/upf-benchmark/+/40143?usp=email ) Change subject: osmo-upf-load-gen: Allow setting local PFCP port ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/40143?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: upf-benchmark Gerrit-Branch: master Gerrit-Change-Id: If74456aa85cc31fd940d47a3258ce566e12716da Gerrit-Change-Number: 40143 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Apr 2025 08:08:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months, 2 weeks

1
0
0 0

[XS] Change in ...osmo_dia2gsup[master]: server_cb: comment out unused fields in handle_request/3

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40145?usp=email ) Change subject: server_cb: comment out unused fields in handle_request/3 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40145?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I3b709cfc723418c1ec88d15bc25bb2cef462a4d3 Gerrit-Change-Number: 40145 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Apr 2025 08:07:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months, 2 weeks

1
0
0 0

[XS] Change in ...osmo_dia2gsup[master]: rebar.{config,lock}: bump lager version: 3.9.1 -> 3.9.2

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40144?usp=email ) Change subject: rebar.{config,lock}: bump lager version: 3.9.1 -> 3.9.2 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40144?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: Id17900cb1b6fbcd6fbc13d16b90b67b82342accb Gerrit-Change-Number: 40144 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Apr 2025 08:07:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log