falconia has abandoned this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39308?usp=email )
Change subject: add dependency on libosmovty
......................................................................
Abandoned
This separate patch is no longer needed - the necessary dependency logic addition has already been done as part of merged twjit and twrtp patches.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39308?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: abandon
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I57cb919891e5c7ee0f828b98af11199cd9c123f8
Gerrit-Change-Number: 39308
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Attention is currently required from: falconia, pespin.
Hello Jenkins Builder, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bts/+/42167?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: RTP: add vty option for ortp vs twrtp selection
......................................................................
RTP: add vty option for ortp vs twrtp selection
With this patch it finally becomes possible for the user to select
which RTP library should be used: ortp or twrtp. ortp is still
the default for now, in order to not alter behavior for existing
installations until twrtp receives more real world testing by users
beyond the original author. Future patches may change the default
or even remove ortp support altogether - but twrtp should receive
more testing as a user opt-in feature first.
Related: OS#6474
Change-Id: Iff4e3a399250c16ba8fe4cb12e4e22f4c6b346ec
---
M include/osmo-bts/bts.h
M src/common/bts.c
M src/common/lchan.c
M src/common/vty.c
M tests/osmo-bts.vty
5 files changed, 91 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/67/42167/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42167?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iff4e3a399250c16ba8fe4cb12e4e22f4c6b346ec
Gerrit-Change-Number: 42167
Gerrit-PatchSet: 5
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/42166?usp=email )
Change subject: RTP: use new abstraction layer instead of direct osmo_ortp
......................................................................
Patch Set 3:
(2 comments)
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/42166/comment/4c4ca5f0_acae9e6a?usp… :
PS2, Line 2329: lchan_osmux_skipped_frame(lchan, fn_ms_adj(fn, lchan));
> Will do in the next patch revision. […]
Done
File src/common/lchan.c:
https://gerrit.osmocom.org/c/osmo-bts/+/42166/comment/76fc6704_af5c583f?usp… :
PS2, Line 590: false, bts->twjit_cfg);
> Will do.
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42166?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I5e3de4f84e8e8875437cb94a9b8feeb07f9cc1cf
Gerrit-Change-Number: 42166
Gerrit-PatchSet: 3
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 23 Feb 2026 20:07:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia <falcon(a)freecalypso.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: laforge, pespin.
falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/42165?usp=email )
Change subject: RTP: implement RTP socket abstraction layer
......................................................................
Patch Set 4:
(2 comments)
File src/common/rtp_abstract.c:
https://gerrit.osmocom.org/c/osmo-bts/+/42165/comment/e15a138a_6e89c8f8?usp… :
PS3, Line 14: #define HAVE_ORTP
> I will change it in the next iteration if Osmocom style preference is to use space here.
Done
https://gerrit.osmocom.org/c/osmo-bts/+/42165/comment/47b2bb7a_23730537?usp… :
PS3, Line 169: osmo_twrtp_twjit_rx_ctrl(rs->twrtp, true);
> Not needed, but no harm either. […]
I added an extra comment in the code explaining this aspect.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42165?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ic945f6d753ec7f5c0ac5cecc9f71049464de7e8f
Gerrit-Change-Number: 42165
Gerrit-PatchSet: 4
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 23 Feb 2026 20:03:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia <falcon(a)freecalypso.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
Hello Jenkins Builder, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bts/+/42167?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: RTP: add vty option for ortp vs twrtp selection
......................................................................
RTP: add vty option for ortp vs twrtp selection
With this patch it finally becomes possible for the user to select
which RTP library should be used: ortp or twrtp. ortp is still
the default for now, in order to not alter behavior for existing
installations until twrtp receives more real world testing by users
beyond the original author. Future patches may change the default
or even remove ortp support altogether - but twrtp should receive
more testing as a user opt-in feature first.
Related: OS#6474
Change-Id: Iff4e3a399250c16ba8fe4cb12e4e22f4c6b346ec
---
M include/osmo-bts/bts.h
M src/common/bts.c
M src/common/lchan.c
M src/common/vty.c
M tests/osmo-bts.vty
5 files changed, 89 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/67/42167/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42167?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iff4e3a399250c16ba8fe4cb12e4e22f4c6b346ec
Gerrit-Change-Number: 42167
Gerrit-PatchSet: 4
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bts/+/42166?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: RTP: use new abstraction layer instead of direct osmo_ortp
......................................................................
RTP: use new abstraction layer instead of direct osmo_ortp
As of this patch in the series, the RTP library in active use
is still always ortp, but all BTS code now accesses it through
the new abstraction layer, paving the way for twrtp option.
Related: OS#6474
Change-Id: I5e3de4f84e8e8875437cb94a9b8feeb07f9cc1cf
---
M include/osmo-bts/l1sap.h
M include/osmo-bts/lchan.h
M src/common/l1sap.c
M src/common/lchan.c
M src/common/msg_utils.c
M src/common/rsl.c
M src/common/vty.c
7 files changed, 45 insertions(+), 62 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/66/42166/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42166?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I5e3de4f84e8e8875437cb94a9b8feeb07f9cc1cf
Gerrit-Change-Number: 42166
Gerrit-PatchSet: 3
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: laforge, pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bts/+/42165?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: RTP: implement RTP socket abstraction layer
......................................................................
RTP: implement RTP socket abstraction layer
This abstraction layer is another step toward supporting a choice
between legacy Belledonne ortp and Osmocom-integrated twrtp.
Related: OS#6474
Depends: Ibda74c0dbfb163f5d0e3fb13f593a6e2c6817673 (libosmo-netif.git)
Change-Id: Ic945f6d753ec7f5c0ac5cecc9f71049464de7e8f
---
M TODO-RELEASE
M include/osmo-bts/Makefile.am
A include/osmo-bts/rtp_abstract.h
M src/common/Makefile.am
A src/common/rtp_abstract.c
5 files changed, 538 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/65/42165/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42165?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ic945f6d753ec7f5c0ac5cecc9f71049464de7e8f
Gerrit-Change-Number: 42165
Gerrit-PatchSet: 4
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>