- gerrit-log - lists.osmocom.org

[M] Change in osmo-bts[master]: RTP: add vty option for ortp vs twrtp selection
by pespin 24 Feb '26

24 Feb '26

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/42167?usp=email ) Change subject: RTP: add vty option for ortp vs twrtp selection ...................................................................... Patch Set 5: (2 comments) File src/common/vty.c: https://gerrit.osmocom.org/c/osmo-bts/+/42167/comment/17bd9019_c47ac600?usp… : PS5, Line 434: if (bts->use_twrtp != g_use_twrtp_default) { tbh, I see no need for the global variable here. If at all, add a "#define RTP_LIBRARY_USE_TWRTP_DEFAULT true", but I don't even consider that necessary here. Simply do: if (bts->use_twrtp) vty_out(vty, " rtp library twrtp%s", VTY_NEWLINE); If you like, add a comment above it simply stating: "ortp is the default" or similar, nothing more is needed, see how it's done similarly for most of the other commands in here and other places. https://gerrit.osmocom.org/c/osmo-bts/+/42167/comment/99d6f915_7490df8a?usp… : PS5, Line 1529: vty_out(vty, I'd say simply add here: vty_out("RTP library: %s%s", bts->use_twrtp ? "Themyscira twrtp" : "Belledonne ortp", VTY_NEWLINE); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42167?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iff4e3a399250c16ba8fe4cb12e4e22f4c6b346ec Gerrit-Change-Number: 42167 Gerrit-PatchSet: 5 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 24 Feb 2026 09:54:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-bts[master]: RTP: use new abstraction layer instead of direct osmo_ortp
by pespin 24 Feb '26

24 Feb '26

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/42166?usp=email ) Change subject: RTP: use new abstraction layer instead of direct osmo_ortp ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File src/common/lchan.c: https://gerrit.osmocom.org/c/osmo-bts/+/42166/comment/ab3ab845_c906be40?usp… : PS2, Line 641: ia, connect_port); > I would like to push back against making this change as part of the present patch - instead it shoul […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42166?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5e3de4f84e8e8875437cb94a9b8feeb07f9cc1cf Gerrit-Change-Number: 42166 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 24 Feb 2026 09:47:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in osmo-bts[master]: RTP: implement RTP socket abstraction layer
by pespin 24 Feb '26

24 Feb '26

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/42165?usp=email ) Change subject: RTP: implement RTP socket abstraction layer ...................................................................... Patch Set 4: Code-Review+2 (4 comments) File include/osmo-bts/rtp_abstract.h: https://gerrit.osmocom.org/c/osmo-bts/+/42165/comment/57c8f44c_c2f881f9?usp… : PS3, Line 50: struct sockaddr_in local_addr; > Please see my comment in the main IPv6 thread. Done File src/common/rtp_abstract.c: https://gerrit.osmocom.org/c/osmo-bts/+/42165/comment/07a7fde6_cb2d5c09?usp… : PS3, Line 54: #ifdef HAVE_ORTP > How do you propose doing so? Each function needs to check if the `rtp_abst_socket` it operates on wa […] Indeed when I was reviewing and writing the comment I thought you planned to enable one or the other at build time. It's fine then. https://gerrit.osmocom.org/c/osmo-bts/+/42165/comment/1ae8d477_aa2f145e?usp… : PS3, Line 97: rc = inet_aton(ipstr, &rs->local_addr.sin_addr); > Please see my comment in the main IPv6 thread. Done https://gerrit.osmocom.org/c/osmo-bts/+/42165/comment/a49d0339_5c347358?usp… : PS3, Line 169: osmo_twrtp_twjit_rx_ctrl(rs->twrtp, true); > I added an extra comment in the code explaining this aspect. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42165?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic945f6d753ec7f5c0ac5cecc9f71049464de7e8f Gerrit-Change-Number: 42165 Gerrit-PatchSet: 4 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 24 Feb 2026 09:45:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-bts[master]: RTP: add vty configuration for twjit
by pespin 24 Feb '26

24 Feb '26

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/42164?usp=email ) Change subject: RTP: add vty configuration for twjit ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42164?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I9ccd060fce8416e01356fccd9ae465a7298a9ce5 Gerrit-Change-Number: 42164 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 24 Feb 2026 09:43:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: BSSAP_LE_Emulation: Increase timeout in f_bssap_le_wait_sccp_peer_ava...
by fixeria 24 Feb '26

24 Feb '26

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42181?usp=email ) Change subject: BSSAP_LE_Emulation: Increase timeout in f_bssap_le_wait_sccp_peer_available() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42181?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2d4210bf5785a09bf384a1534c407dcf63b1c38b Gerrit-Change-Number: 42181 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 24 Feb 2026 09:37:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: contrib/smpp-ota-tool: warn about mixed up KIC/KIC indexes
by laforge 24 Feb '26

24 Feb '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42186?usp=email ) Change subject: contrib/smpp-ota-tool: warn about mixed up KIC/KIC indexes ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42186?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ieb4e14145baba1c2cb4a237b612b04694940f402 Gerrit-Change-Number: 42186 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 24 Feb 2026 09:00:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: contrib/smpp-ota-tool: add missing usage helpstrings
by dexter 24 Feb '26

24 Feb '26

Attention is currently required from: dexter. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/42187?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: contrib/smpp-ota-tool: add missing usage helpstrings ...................................................................... contrib/smpp-ota-tool: add missing usage helpstrings Change-Id: Ic1521ba11b405f311a30fdb3585ad518375669ae Related: OS#6868 --- M contrib/smpp-ota-tool.py 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/87/42187/3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42187?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic1521ba11b405f311a30fdb3585ad518375669ae Gerrit-Change-Number: 42187 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: contrib/smpp-ota-tool: warn about mixed up KIC/KIC indexes
by dexter 24 Feb '26

24 Feb '26

Attention is currently required from: laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42186?usp=email ) Change subject: contrib/smpp-ota-tool: warn about mixed up KIC/KIC indexes ...................................................................... Patch Set 2: (1 comment) File contrib/smpp-ota-tool.py: https://gerrit.osmocom.org/c/pysim/+/42186/comment/aaa50b48_3ece8221?usp=em… : PS1, Line 218: differnet > spelling: different Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42186?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ieb4e14145baba1c2cb4a237b612b04694940f402 Gerrit-Change-Number: 42186 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 24 Feb 2026 08:54:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: contrib/smpp-ota-tool: warn about mixed up KIC/KIC indexes
by dexter 24 Feb '26

24 Feb '26

Attention is currently required from: laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/42186?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: contrib/smpp-ota-tool: warn about mixed up KIC/KIC indexes ...................................................................... contrib/smpp-ota-tool: warn about mixed up KIC/KIC indexes Cards usually have multiple sets of KIC, KID (and KIK). The keys are selected through an index. However, mixing keys from different sets is concidered as a security violation and cards should reject such configurations. Let's print a warning to make users aware that something is off. Change-Id: Ieb4e14145baba1c2cb4a237b612b04694940f402 Related: OS#6868 --- M contrib/smpp-ota-tool.py 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/86/42186/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42186?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ieb4e14145baba1c2cb4a237b612b04694940f402 Gerrit-Change-Number: 42186 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-gsm-manuals[master]: sigtran-osmocom.adoc: Describe tcap-aware loadshare
by daniel 24 Feb '26

24 Feb '26

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/42190?usp=email ) Change subject: sigtran-osmocom.adoc: Describe tcap-aware loadshare ...................................................................... sigtran-osmocom.adoc: Describe tcap-aware loadshare Change-Id: I58979e8f6c5156706b1016069eaaf2801ec9311b Related: OS#5423 --- M common/chapters/sigtran-osmocom.adoc 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/90/42190/1 diff --git a/common/chapters/sigtran-osmocom.adoc b/common/chapters/sigtran-osmocom.adoc index 32d03cf..dba73a8 100644 --- a/common/chapters/sigtran-osmocom.adoc +++ b/common/chapters/sigtran-osmocom.adoc @@ -181,6 +181,24 @@ user has no information (nor to worry about ) any "physical" signaling links. +==== Loadshare with TCAP-aware routing + +A TCAP dialogue consists of multiple messages that depend on each other. +This means that simply load-sharing messages between ASPs will not work +unless the ASPs are able to share state about ongoing TCAP dialogues. + +<<ietf-rfc3868>> states in Ch. A.3.1 that "[...] when TCAP messages are +transported, load sharing is only possible for the first message in a +TCAP dialogue (TC_Begin, TC_Query, TC_Unidirectional). All other TCAP +messages in the same dialogue are sent to the same ASP that was selected +for the first message, unless the ASPs are able to share state and +maintain sequenced delivery." + +The Osmocom SIGTRAN stack supports TCAP-aware routing as described above +in traffic-mode loadshare. Additionally, ASPs connected through IPA/SCCPlite +can use an IPA-based protocol to register ranges of TCAP Ids. This ensures +that a TC_Begin with a given TCAP Id will already be routed to this specific +ASP. === Minimal Osmocom SIGTRAN configurations for small networks -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/42190?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I58979e8f6c5156706b1016069eaaf2801ec9311b Gerrit-Change-Number: 42190 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log