- gerrit-log - lists.osmocom.org

[S] Change in osmo-bts[master]: osmo-bts-trx: trx_fn_timer_cb(): fix misleading shutdown reason

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/40156?usp=email ) Change subject: osmo-bts-trx: trx_fn_timer_cb(): fix misleading shutdown reason ...................................................................... Patch Set 3: (2 comments) File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/c/osmo-bts/+/40156/comment/c20767e1_e97d25c4?usp… : PS2, Line 414: const char *reason; > better NULL it here to avoid some mess in the future if someone changes some code path. Acknowledged https://gerrit.osmocom.org/c/osmo-bts/+/40156/comment/3e6d76a4_88c30004?usp… : PS2, Line 454: reason = "PC clock skew"; > I'd rather change this to something like "PC clock skew too high". […] Acknowledged -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/40156?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ibbbbc4e919e6eb812882fc60de4be13fa77934b7 Gerrit-Change-Number: 40156 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Apr 2025 14:53:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[S] Change in osmo-bts[master]: osmo-bts-trx: trx_fn_timer_cb(): fix misleading shutdown reason

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/40156?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: osmo-bts-trx: trx_fn_timer_cb(): fix misleading shutdown reason ...................................................................... osmo-bts-trx: trx_fn_timer_cb(): fix misleading shutdown reason If osmo-bts-trx exit()s due to the PC clock issues, e.g. if the process stalls, it produces rather confusing logging messages: DL1C ERROR PC clock skew: elapsed_us=387574, error_us=382959 DOML NOTICE ... Shutting down BTS, exit 1, reason: No clock from osmo-trx The second message suggests that the transceiver (osmo-trx) is the culprit, but the first one reflects the actual reason (PC clock skew). Let's pass proper shutdown reason to avoid confusion. Change-Id: Ibbbbc4e919e6eb812882fc60de4be13fa77934b7 --- M src/osmo-bts-trx/scheduler_trx.c 1 file changed, 11 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/56/40156/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/40156?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ibbbbc4e919e6eb812882fc60de4be13fa77934b7 Gerrit-Change-Number: 40156 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[S] Change in osmo-bts[master]: osmo-bts-trx: trx_fn_timer_cb(): fix misleading shutdown reason

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/40156?usp=email ) Change subject: osmo-bts-trx: trx_fn_timer_cb(): fix misleading shutdown reason ...................................................................... Patch Set 2: (2 comments) File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/c/osmo-bts/+/40156/comment/ba2d8fa9_2905f34a?usp… : PS2, Line 414: const char *reason; better NULL it here to avoid some mess in the future if someone changes some code path. https://gerrit.osmocom.org/c/osmo-bts/+/40156/comment/9a9e4f72_86b9b369?usp… : PS2, Line 454: reason = "PC clock skew"; I'd rather change this to something like "PC clock skew too high". We are not stopping because there was a bit of skew, but because we ended up in some crazy value we cannot recover from. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/40156?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ibbbbc4e919e6eb812882fc60de4be13fa77934b7 Gerrit-Change-Number: 40156 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Apr 2025 14:48:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

2 months, 2 weeks

1
0
0 0

[S] Change in osmo-bts[master]: osmo-bts-trx: trx_fn_timer_cb(): fix misleading shutdown reason

by fixeria

fixeria has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-bts/+/40156?usp=email ) Change subject: osmo-bts-trx: trx_fn_timer_cb(): fix misleading shutdown reason ...................................................................... osmo-bts-trx: trx_fn_timer_cb(): fix misleading shutdown reason If osmo-bts-trx exit()s due to the PC clock issues, e.g. if the process stalls, it produces rather confusing logging messages: DL1C ERROR PC clock skew: elapsed_us=387574, error_us=382959 DOML NOTICE ... Shutting down BTS, exit 1, reason: No clock from osmo-trx The second message suggests that the transceiver (osmo-trx) is the culprit, but the first one reflects the actual reason (PC clock skew). Let's pass proper shutdown reason to avoid confusion. Change-Id: Ibbbbc4e919e6eb812882fc60de4be13fa77934b7 --- M src/osmo-bts-trx/scheduler_trx.c 1 file changed, 11 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/56/40156/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/40156?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ibbbbc4e919e6eb812882fc60de4be13fa77934b7 Gerrit-Change-Number: 40156 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: Jenkins Builder

2 months, 2 weeks

1
0
0 0

[S] Change in osmo-bts[master]: osmo-bts-trx: trx_fn_timer_cb(): proper shutdown reason

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/40156?usp=email ) Change subject: osmo-bts-trx: trx_fn_timer_cb(): proper shutdown reason ...................................................................... osmo-bts-trx: trx_fn_timer_cb(): proper shutdown reason If osmo-bts-trx exit()s due to the PC clock issues, it produces rather confusing logging messages. For instance: DL1C ERROR PC clock skew: elapsed_us=387574, error_us=382959 DOML NOTICE ... Shutting down BTS, exit 1, reason: No clock from osmo-trx The second message suggests that the transceiver (osmo-trx) is the culprit, but the first one reflects the actual reason (PC clock skew). Let's pass proper shutdown reason to avoid confusion. Change-Id: Ibbbbc4e919e6eb812882fc60de4be13fa77934b7 --- M src/osmo-bts-trx/scheduler_trx.c 1 file changed, 11 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/56/40156/1 diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c index 00143ab..2bae295 100644 --- a/src/osmo-bts-trx/scheduler_trx.c +++ b/src/osmo-bts-trx/scheduler_trx.c @@ -411,6 +411,7 @@ struct timespec tv_now; uint64_t expire_count; int64_t elapsed_us, error_us; + const char *reason; int rc, i; if (!(what & OSMO_FD_READ)) @@ -430,8 +431,9 @@ /* check if transceiver is still alive */ if (tcs->fn_without_clock_ind++ == TRX_LOSS_FRAMES) { - LOGP(DL1C, LOGL_NOTICE, "No more clock from transceiver\n"); - goto no_clock; + reason = "No more clock from transceiver"; + LOGP(DL1C, LOGL_ERROR, "%s\n", reason); + goto shutdown; } /* compute actual elapsed time and resulting OS scheduling error */ @@ -446,9 +448,11 @@ /* if someone played with clock, or if the process stalled */ if (elapsed_us > GSM_TDMA_FN_DURATION_uS * MAX_FN_SKEW || elapsed_us < 0) { - LOGP(DL1C, LOGL_ERROR, "PC clock skew: elapsed_us=%" PRId64 ", error_us=%" PRId64 "\n", - elapsed_us, error_us); - goto no_clock; + LOGP(DL1C, LOGL_ERROR, + "PC clock skew: elapsed_us=%" PRId64 ", error_us=%" PRId64 "\n", + elapsed_us, error_us); + reason = "PC clock skew"; + goto shutdown; } /* call bts_sched_fn() for all expired FN */ @@ -457,9 +461,9 @@ return 0; -no_clock: +shutdown: osmo_timerfd_disable(&tcs->fn_timer_ofd); - bts_shutdown(bts, "No clock from osmo-trx"); + bts_shutdown(bts, reason); return -1; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/40156?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ibbbbc4e919e6eb812882fc60de4be13fa77934b7 Gerrit-Change-Number: 40156 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[XS] Change in osmo-hnbgw[master]: change log level patching GTP info NOTICE->INFO

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40155?usp=email ) Change subject: change log level patching GTP info NOTICE->INFO ...................................................................... change log level patching GTP info NOTICE->INFO Change-Id: I93b8634ff4de52fb7e3f2bfd915552173f27a09a --- M src/osmo-hnbgw/ps_rab_ass_fsm.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/55/40155/1 diff --git a/src/osmo-hnbgw/ps_rab_ass_fsm.c b/src/osmo-hnbgw/ps_rab_ass_fsm.c index f400fcc..f5025a2 100644 --- a/src/osmo-hnbgw/ps_rab_ass_fsm.c +++ b/src/osmo-hnbgw/ps_rab_ass_fsm.c @@ -441,7 +441,7 @@ return -1; } - LOG_PS_RAB_ASS(rab_ass, LOGL_NOTICE, "PS RAB-AssignmentResponse received, updating RABs\n"); + LOG_PS_RAB_ASS(rab_ass, LOGL_INFO, "PS RAB-AssignmentResponse received, updating RABs\n"); /* Multiple RABs may be set up, bump matching FSMs in list rab_ass->ps_rabs. */ for (i = 0; i < ies->raB_SetupOrModifiedList.raB_SetupOrModifiedList_ies.list.count; i++) { @@ -601,7 +601,7 @@ return; } - LOG_PS_RAB_ASS(rab_ass, LOGL_NOTICE, "Sending RANAP PS RAB-AssignmentResponse with mapped GTP info\n"); + LOG_PS_RAB_ASS(rab_ass, LOGL_INFO, "Sending RANAP PS RAB-AssignmentResponse with mapped GTP info\n"); rc = map_sccp_dispatch(rab_ass->map, MAP_SCCP_EV_TX_DATA_REQUEST, msg); if (rc < 0) { -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40155?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I93b8634ff4de52fb7e3f2bfd915552173f27a09a Gerrit-Change-Number: 40155 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[XS] Change in osmo-hnbgw[master]: Change log level new conn created NOTICE->INFO

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40154?usp=email ) Change subject: Change log level new conn created NOTICE->INFO ...................................................................... Change log level new conn created NOTICE->INFO Change-Id: Ie8a50312abc3dd4a438556f6f626d069259cc551 --- M src/osmo-hnbgw/context_map.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/54/40154/1 diff --git a/src/osmo-hnbgw/context_map.c b/src/osmo-hnbgw/context_map.c index 6146e6c..1f4c6a2 100644 --- a/src/osmo-hnbgw/context_map.c +++ b/src/osmo-hnbgw/context_map.c @@ -125,7 +125,7 @@ hash_add(hsu->hnbgw_context_map_by_conn_id, &map->hnbgw_sccp_user_entry, new_scu_conn_id); - LOGP(DRUA, LOGL_NOTICE, "New conn: %s '%s' RUA-%u <-> SCCP-%u %s%s%s %s l=%s<->r=%s\n", + LOGP(DRUA, LOGL_INFO, "New conn: %s '%s' RUA-%u <-> SCCP-%u %s%s%s %s l=%s<->r=%s\n", osmo_sock_get_name2_c(OTC_SELECT, osmo_stream_srv_get_ofd(map->hnb_ctx->conn)->fd), hnb_context_name(map->hnb_ctx), map->rua_ctx_id, new_scu_conn_id, -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40154?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ie8a50312abc3dd4a438556f6f626d069259cc551 Gerrit-Change-Number: 40154 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: bts: set osmo-bts sched priority to 30

by pespin

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40153?usp=email ) Change subject: bts: set osmo-bts sched priority to 30 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > In the case of sysmoBTS, it helped to increase priority: […] From tps://gerrit.osmocom.org/c/osmo-bts/+/34581: "There is no other process using RR prio, but there are kernel processes with nice level of -20." so that seems to explain it, yet I don't see such an important information in this patch. To me this patch so far looks like blindly increasing prio with no check of any sort. If I'm wrong, please provide such info in the patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40153?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I828422e2363a58ca8c19d0f1b8a1b7d4e4bc031e Gerrit-Change-Number: 40153 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Apr 2025 13:47:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/ttcn3-testsuites-testenv: set core env var

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40139?usp=email ) Change subject: jobs/ttcn3-testsuites-testenv: set core env var ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40139?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I8359b0faa1fed76b430749589916cd072a8a7753 Gerrit-Change-Number: 40139 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Apr 2025 13:40:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months, 2 weeks

1
0
0 0

[M] Change in osmo-ci[master]: ansible: build-hosts: add testenv-coredump-helper

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40138?usp=email ) Change subject: ansible: build-hosts: add testenv-coredump-helper ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40138?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7e66c98106b7028a393e3b873e96ae2dcb412c48 Gerrit-Change-Number: 40138 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Apr 2025 13:40:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log