- gerrit-log - lists.osmocom.org

[S] Change in docker-playground[master]: ttcn3-bts-test: write bts logs to tmpfs
by pespin 24 Feb '26

24 Feb '26

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/docker-playground/+/42194?usp=email ) Change subject: ttcn3-bts-test: write bts logs to tmpfs ...................................................................... Patch Set 1: (2 comments) File ttcn3-bts-test/jenkins.sh: https://gerrit.osmocom.org/c/docker-playground/+/42194/comment/cce2f6e9_8a0… : PS1, Line 74: --mount type=tmpfs,dst=/tmp \ nice! https://gerrit.osmocom.org/c/docker-playground/+/42194/comment/4045e8ce_fb6… : PS1, Line 117: docker exec "${BUILD_TAG}-bts" sh -c "cat /tmp/osmo-bts.log >> /data/osmo-bts.log" lol Can't we simply do "cp /tmp/osmo-bts.log /data/osmo-bts.log" ? -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/42194?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Id9a93f7149ef7e9bfde1f4fe3a8299ba46645d50 Gerrit-Change-Number: 42194 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 24 Feb 2026 15:00:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-ccid-firmware[master]: main: don't access msgbs after giving them away
by lynxis lazus 24 Feb '26

24 Feb '26

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42162?usp=email ) Change subject: main: don't access msgbs after giving them away ...................................................................... Patch Set 1: (1 comment) This change is ready for review. Patchset: PS1: Needs further testing -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42162?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I79844f77d5cd75e08b0eb44b22c4ad223cb79dcb Gerrit-Change-Number: 42162 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Tue, 24 Feb 2026 14:45:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-ccid-firmware[master]: main: fix crash when ccid_df_write_in() fails
by lynxis lazus 24 Feb '26

24 Feb '26

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42161?usp=email ) Change subject: main: fix crash when ccid_df_write_in() fails ...................................................................... Patch Set 1: (1 comment) This change is ready for review. Patchset: PS1: Needs further testing -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42161?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I49c81fba756f3620638b6c6c664f53e4a8758ef9 Gerrit-Change-Number: 42161 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Tue, 24 Feb 2026 14:45:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-asf4-dfu[master]: dfu: MANIFEST: mainloop: wait 5 ms before handling the state
by lynxis lazus 24 Feb '26

24 Feb '26

lynxis lazus has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42177?usp=email ) Change subject: dfu: MANIFEST: mainloop: wait 5 ms before handling the state ...................................................................... Abandoned Superseeded by https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42180/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42177?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: If9178120eed46f75089abf1898db3176cce93df2 Gerrit-Change-Number: 42177 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-asf4-dfu[master]: dfu: rewrite firmware downloading
by lynxis lazus 24 Feb '26

24 Feb '26

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: dfu: rewrite firmware downloading ...................................................................... dfu: rewrite firmware downloading Improve handling of dfu_state by moving more state changing towards the IRQ handler. Having both the main loop and IRQ changes dfu_state within the same state could lead to races. The main loop is now only a simple worker which reports back via dfu_flash_done & dfu_flash_status. Change-Id: I345d5948455b25cd8a2efb1abfd9d0986ebd8cef --- M usb/class/dfu/device/dfudf.c M usb/class/dfu/device/dfudf.h M usb_start.c 3 files changed, 77 insertions(+), 34 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-asf4-dfu refs/changes/74/42174/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I345d5948455b25cd8a2efb1abfd9d0986ebd8cef Gerrit-Change-Number: 42174 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-asf4-dfu[master]: dfu: MANIFEST_SYNC: stay in MANIFEST_SYNC when manifestationIntoleran...
by lynxis lazus 24 Feb '26

24 Feb '26

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42175?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: dfu: MANIFEST_SYNC: stay in MANIFEST_SYNC when manifestationIntolerant & completed ...................................................................... dfu: MANIFEST_SYNC: stay in MANIFEST_SYNC when manifestationIntolerant & completed In theory a device which is manifestintolerant and completed the manifestation should not reach MANIFEST_SYNC again. Remove the state transistion to WAIT-RESET and stay in the current state and wait for the main loop to change the state is safer. Change-Id: I8c34a18e2336731126a8c01070d86e2547578e3d --- M usb/class/dfu/device/dfudf.c 1 file changed, 8 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-asf4-dfu refs/changes/75/42175/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42175?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I8c34a18e2336731126a8c01070d86e2547578e3d Gerrit-Change-Number: 42175 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-asf4-dfu[master]: dfu: irq: GET_STATUS: set state before sending it
by lynxis lazus 24 Feb '26

24 Feb '26

lynxis lazus has restored this change. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42172?usp=email ) Change subject: dfu: irq: GET_STATUS: set state before sending it ...................................................................... Restored -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42172?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: restore Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I6d28404d6936f7ea79fcee90f0c8191f0f623ad8 Gerrit-Change-Number: 42172 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-asf4-dfu[master]: dfu: MANIFEST_SYNC: stay in MANIFEST_SYNC when manifestationIntoleran...
by lynxis lazus 24 Feb '26

24 Feb '26

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42175?usp=email ) Change subject: dfu: MANIFEST_SYNC: stay in MANIFEST_SYNC when manifestationIntolerant & completed ...................................................................... Patch Set 2: (2 comments) File usb/class/dfu/device/dfudf.c: https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42175/comment/705bf41e_eab52ca… : PS2, Line 188: } else { // this should not happen (after manifestation the state should be dfuMANIFEST-WAIT-RESET if we are not manifest tolerant) > I'll take over this comment, improve the otherwise stay in MANIFEST_SYNC Done https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42175/comment/87e5d082_67cbb83… : PS2, Line 184: if (!dfu_manifestation_complete) { > may make sense to actually switch the if path to be "if (dfu_manifestation_complete)" now. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42175?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I8c34a18e2336731126a8c01070d86e2547578e3d Gerrit-Change-Number: 42175 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 24 Feb 2026 14:38:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in osmo-asf4-dfu[master]: dfu: rewrite firmware downloading
by lynxis lazus 24 Feb '26

24 Feb '26

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174?usp=email ) Change subject: dfu: rewrite firmware downloading ...................................................................... Patch Set 2: (1 comment) File usb_start.c: https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174/comment/563f5957_240afe3… : PS2, Line 171: /* FIXME: check if dfu_download_offset / length are valid */ > Acknowledged Done -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I345d5948455b25cd8a2efb1abfd9d0986ebd8cef Gerrit-Change-Number: 42174 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 24 Feb 2026 14:35:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-asf4-dfu[master]: dfu: irq: GET_STATUS: set state before sending it
by lynxis lazus 24 Feb '26

24 Feb '26

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42172?usp=email ) Change subject: dfu: irq: GET_STATUS: set state before sending it ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Will drop the patch as soon the successor have been merged. -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42172?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I6d28404d6936f7ea79fcee90f0c8191f0f623ad8 Gerrit-Change-Number: 42172 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 24 Feb 2026 14:34:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2026

2025

2024

2023

2022

gerrit-log