- gerrit-log - lists.osmocom.org

[S] Change in osmo-hnbgw[master]: rua: Handle event TX_DIRECT_TRANSFER in disconnected state discarding...

by fixeria

Attention is currently required from: lynxis lazus, neels, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40162?usp=email ) Change subject: rua: Handle event TX_DIRECT_TRANSFER in disconnected state discarding msg ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40162?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Id68f219ce776fbbfaa80d3b3ed976f48bef4f883 Gerrit-Change-Number: 40162 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 25 Apr 2025 18:02:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months, 2 weeks

1
0
0 0

[S] Change in osmo-hnbgw[master]: rua: Handle event TX_DIRECT_TRANSFER in disconnected state discarding...

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40162?usp=email ) Change subject: rua: Handle event TX_DIRECT_TRANSFER in disconnected state discarding msg ...................................................................... rua: Handle event TX_DIRECT_TRANSFER in disconnected state discarding msg Related: SYS#7452 Change-Id: Id68f219ce776fbbfaa80d3b3ed976f48bef4f883 --- M src/osmo-hnbgw/context_map_rua.c 1 file changed, 20 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/62/40162/1 diff --git a/src/osmo-hnbgw/context_map_rua.c b/src/osmo-hnbgw/context_map_rua.c index d408ddd..f545e31 100644 --- a/src/osmo-hnbgw/context_map_rua.c +++ b/src/osmo-hnbgw/context_map_rua.c @@ -276,10 +276,25 @@ static void map_rua_disconnected_action(struct osmo_fsm_inst *fi, uint32_t event, void *data) { - struct msgb *ranap_msg = data; - if (msg_has_l2_data(ranap_msg)) - LOGPFSML(fi, LOGL_NOTICE, "RUA not connected, cannot dispatch RANAP message\n"); - /* Ignore all events. */ + struct msgb *ranap_msg; + + switch (event) { + + case MAP_RUA_EV_TX_DIRECT_TRANSFER: + /* This can happen if CN is buggy, or in general if there was a race + * condition between us forwarding the release towards CN (SCCP Release + * or RANAP Iu-ReleaseComplete) and CN sendig whatever to us. */ + ranap_msg = data; + if (msg_has_l2_data(ranap_msg)) + LOGPFSML(fi, LOGL_NOTICE, "RUA already disconnected, skip forwarding DL RANAP msg (%u bytes): %s\n", + msgb_l2len(ranap_msg), osmo_hexdump(msgb_l2(ranap_msg), msgb_l2len(ranap_msg))); + break; + + case MAP_RUA_EV_CN_DISC: + case MAP_RUA_EV_HNB_LINK_LOST: + /* Ignore all events. */ + break; + } } static void map_rua_disrupted_onenter(struct osmo_fsm_inst *fi, uint32_t prev_state) @@ -331,6 +346,7 @@ [MAP_RUA_ST_DISCONNECTED] = { .name = "disconnected", .in_event_mask = 0 + | S(MAP_RUA_EV_TX_DIRECT_TRANSFER) | S(MAP_RUA_EV_CN_DISC) | S(MAP_RUA_EV_HNB_LINK_LOST) , -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40162?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Id68f219ce776fbbfaa80d3b3ed976f48bef4f883 Gerrit-Change-Number: 40162 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[S] Change in osmo-hnbgw[master]: cosmetic: Improve ranap_msg passing ownership documentation

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40161?usp=email ) Change subject: cosmetic: Improve ranap_msg passing ownership documentation ...................................................................... cosmetic: Improve ranap_msg passing ownership documentation In general ranap_msg is made owned by OTC_SELECT, and under RAB Assignment where PFCP or MGCP is involved the msg ownership is temporarily stolen to the related FSM instance. Change-Id: I556e01b26a71b43432c623adb7ea5af2114981e3 --- M include/osmocom/hnbgw/context_map.h M src/osmo-hnbgw/hnbgw_cn.c M src/osmo-hnbgw/hnbgw_ranap.c 3 files changed, 18 insertions(+), 11 deletions(-) Approvals: Jenkins Builder: Verified lynxis lazus: Looks good to me, approved diff --git a/include/osmocom/hnbgw/context_map.h b/include/osmocom/hnbgw/context_map.h index f9bd251..41b312d 100644 --- a/include/osmocom/hnbgw/context_map.h +++ b/include/osmocom/hnbgw/context_map.h @@ -29,13 +29,17 @@ * - The RANAP message shall be at msgb_l2(). */ enum map_rua_fsm_event { - /* Receiving a RUA Connect from HNB. */ + /* Receiving a RUA Connect from HNB. + * Parameter: struct msgb *ranap_msg */ MAP_RUA_EV_RX_CONNECT, - /* Receiving some data from HNB via RUA, to forward via SCCP to CN. */ + /* Receiving some data from HNB via RUA, to forward via SCCP to CN. + * Parameter: struct msgb *ranap_msg */ MAP_RUA_EV_RX_DIRECT_TRANSFER, - /* Receiving a RUA Disconnect from HNB. */ + /* Receiving a RUA Disconnect from HNB. + * Parameter: struct msgb *ranap_msg (can be NULL) */ MAP_RUA_EV_RX_DISCONNECT, - /* SCCP has received some data from CN to forward via RUA to HNB. */ + /* SCCP has received some data from CN to forward via RUA to HNB. + * Parameter: struct msgb *ranap_msg */ MAP_RUA_EV_TX_DIRECT_TRANSFER, /* The CN side is disconnected (e.g. received an SCCP Released), that means we are going gracefully disconnect * RUA, too. */ @@ -52,9 +56,11 @@ enum map_sccp_fsm_event { /* Receiving an SCCP CC from CN. */ MAP_SCCP_EV_RX_CONNECTION_CONFIRM, - /* Receiving some data from CN via SCCP, to forward via RUA to HNB. */ + /* Receiving some data from CN via SCCP, to forward via RUA to HNB. + * Parameter: struct msgb *ranap_msg */ MAP_SCCP_EV_RX_DATA_INDICATION, - /* RUA has received some data from HNB to forward via SCCP to CN. */ + /* RUA has received some data from HNB to forward via SCCP to CN. + * Parameter: struct msgb *ranap_msg */ MAP_SCCP_EV_TX_DATA_REQUEST, /* 3GPP TS 25.468 9.1.5: The RAN side received a RUA Disconnect. * - Under normal conditions (cause=Normal) the RUA Disconnect contains a RANAP Iu-ReleaseComplete. diff --git a/src/osmo-hnbgw/hnbgw_cn.c b/src/osmo-hnbgw/hnbgw_cn.c index 3659b36..686a0e5 100644 --- a/src/osmo-hnbgw/hnbgw_cn.c +++ b/src/osmo-hnbgw/hnbgw_cn.c @@ -258,7 +258,8 @@ } } -/* Entry point for primitives coming up from SCCP User SAP */ +/* Entry point for primitives coming up from SCCP User SAP. + * Ownership of oph->msg is transferred to us. */ static int sccp_sap_up(struct osmo_prim_hdr *oph, void *ctx) { struct osmo_sccp_user *scu = ctx; diff --git a/src/osmo-hnbgw/hnbgw_ranap.c b/src/osmo-hnbgw/hnbgw_ranap.c index 692cf11..6dc1f06 100644 --- a/src/osmo-hnbgw/hnbgw_ranap.c +++ b/src/osmo-hnbgw/hnbgw_ranap.c @@ -252,7 +252,7 @@ } /* Process a received RANAP PDU through SCCP DATA.ind coming from CN (MSC/SGSN) - * Takes ownership of ranap_msg? */ + * ranap_msg is owned by OTC_SELECT. */ int hnbgw_ranap_rx_data_ul(struct hnbgw_context_map *map, struct msgb *ranap_msg) { OSMO_ASSERT(map); @@ -270,7 +270,7 @@ * information, for RTP mapping via MGW, or GTP mapping via UPF. */ switch (message->procedureCode) { case RANAP_ProcedureCode_id_RAB_Assignment: - /* mgw_fsm_handle_rab_ass_resp() takes ownership of prim->oph and (ranap) message */ + /* mgw_fsm_handle_rab_ass_resp() may take ownership of "ranap_msg" (prim->oph) and "message" */ return mgw_fsm_handle_cs_rab_ass_resp(map, ranap_msg, message); } } else { @@ -279,7 +279,7 @@ /* map->is_ps == true and PFCP is enabled in osmo-hnbgw.cfg */ switch (message->procedureCode) { case RANAP_ProcedureCode_id_RAB_Assignment: - /* ps_rab_ass_fsm takes ownership of prim->oph and RANAP message */ + /* ps_rab_ass_fsm() may take ownership of "ranap_msg" (prim->oph) and "message" */ return hnbgw_gtpmap_rx_rab_ass_resp(map, ranap_msg, message); } } @@ -617,7 +617,7 @@ } /* Process a received RANAP PDU through SCCP DATA.ind coming from CN (MSC/SGSN) - * Takes ownership of ranap_msg? */ + * ranap_msg is owned by OTC_SELECT. */ int hnbgw_ranap_rx_data_dl(struct hnbgw_context_map *map, struct msgb *ranap_msg) { OSMO_ASSERT(map); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40161?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I556e01b26a71b43432c623adb7ea5af2114981e3 Gerrit-Change-Number: 40161 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[XS] Change in osmo-hnbgw[master]: Change log level new conn created NOTICE->INFO

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40154?usp=email ) Change subject: Change log level new conn created NOTICE->INFO ...................................................................... Change log level new conn created NOTICE->INFO Change-Id: Ie8a50312abc3dd4a438556f6f626d069259cc551 --- M src/osmo-hnbgw/context_map.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified lynxis lazus: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/src/osmo-hnbgw/context_map.c b/src/osmo-hnbgw/context_map.c index 6146e6c..1f4c6a2 100644 --- a/src/osmo-hnbgw/context_map.c +++ b/src/osmo-hnbgw/context_map.c @@ -125,7 +125,7 @@ hash_add(hsu->hnbgw_context_map_by_conn_id, &map->hnbgw_sccp_user_entry, new_scu_conn_id); - LOGP(DRUA, LOGL_NOTICE, "New conn: %s '%s' RUA-%u <-> SCCP-%u %s%s%s %s l=%s<->r=%s\n", + LOGP(DRUA, LOGL_INFO, "New conn: %s '%s' RUA-%u <-> SCCP-%u %s%s%s %s l=%s<->r=%s\n", osmo_sock_get_name2_c(OTC_SELECT, osmo_stream_srv_get_ofd(map->hnb_ctx->conn)->fd), hnb_context_name(map->hnb_ctx), map->rua_ctx_id, new_scu_conn_id, -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40154?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ie8a50312abc3dd4a438556f6f626d069259cc551 Gerrit-Change-Number: 40154 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[XS] Change in osmo-hnbgw[master]: change log level patching GTP info NOTICE->INFO

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40155?usp=email ) Change subject: change log level patching GTP info NOTICE->INFO ...................................................................... change log level patching GTP info NOTICE->INFO Change-Id: I93b8634ff4de52fb7e3f2bfd915552173f27a09a --- M src/osmo-hnbgw/ps_rab_ass_fsm.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve lynxis lazus: Looks good to me, approved diff --git a/src/osmo-hnbgw/ps_rab_ass_fsm.c b/src/osmo-hnbgw/ps_rab_ass_fsm.c index f400fcc..f5025a2 100644 --- a/src/osmo-hnbgw/ps_rab_ass_fsm.c +++ b/src/osmo-hnbgw/ps_rab_ass_fsm.c @@ -441,7 +441,7 @@ return -1; } - LOG_PS_RAB_ASS(rab_ass, LOGL_NOTICE, "PS RAB-AssignmentResponse received, updating RABs\n"); + LOG_PS_RAB_ASS(rab_ass, LOGL_INFO, "PS RAB-AssignmentResponse received, updating RABs\n"); /* Multiple RABs may be set up, bump matching FSMs in list rab_ass->ps_rabs. */ for (i = 0; i < ies->raB_SetupOrModifiedList.raB_SetupOrModifiedList_ies.list.count; i++) { @@ -601,7 +601,7 @@ return; } - LOG_PS_RAB_ASS(rab_ass, LOGL_NOTICE, "Sending RANAP PS RAB-AssignmentResponse with mapped GTP info\n"); + LOG_PS_RAB_ASS(rab_ass, LOGL_INFO, "Sending RANAP PS RAB-AssignmentResponse with mapped GTP info\n"); rc = map_sccp_dispatch(rab_ass->map, MAP_SCCP_EV_TX_DATA_REQUEST, msg); if (rc < 0) { -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40155?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I93b8634ff4de52fb7e3f2bfd915552173f27a09a Gerrit-Change-Number: 40155 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[XS] Change in osmo-hnbgw[master]: rua: Change log err level ERROR->NOTICE regarding received unexpected...

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40152?usp=email ) Change subject: rua: Change log err level ERROR->NOTICE regarding received unexpected RUA context ...................................................................... rua: Change log err level ERROR->NOTICE regarding received unexpected RUA context This is not really an internal error but can actually happen if the HNB or the HNBGW crashed and state is no longer the same in both. Change-Id: Ib588bb71ccbe716a495afec27d38f48881e7e1bc --- M src/osmo-hnbgw/hnbgw_rua.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: lynxis lazus: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-hnbgw/hnbgw_rua.c b/src/osmo-hnbgw/hnbgw_rua.c index 7cc1b27..7a51c8d 100644 --- a/src/osmo-hnbgw/hnbgw_rua.c +++ b/src/osmo-hnbgw/hnbgw_rua.c @@ -271,7 +271,7 @@ /* A Connect message can only be the first message for an unused RUA context */ if (map) { /* Already established this RUA context. But then how can it be a Connect message. */ - LOGHNB(hnb, DRUA, LOGL_ERROR, "rx RUA %s for already active RUA context %u\n", + LOGHNB(hnb, DRUA, LOGL_NOTICE, "rx RUA %s for already active RUA context %u\n", rua_procedure_code_name(rua_procedure), context_id); return -EINVAL; } @@ -300,7 +300,7 @@ default: /* Any message other than Connect must have a valid RUA context */ if (!map) { - LOGHNB(hnb, DRUA, LOGL_ERROR, "rx RUA %s for unknown RUA context %u\n", + LOGHNB(hnb, DRUA, LOGL_NOTICE, "rx RUA %s for unknown RUA context %u\n", rua_procedure_code_name(rua_procedure), context_id); rua_tx_disc_conn_fail(hnb, is_ps, context_id); return -EINVAL; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40152?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ib588bb71ccbe716a495afec27d38f48881e7e1bc Gerrit-Change-Number: 40152 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[S] Change in osmo-hnbgw[master]: mgw_fsm: use LOG_MAP() to log error

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40160?usp=email ) Change subject: mgw_fsm: use LOG_MAP() to log error ...................................................................... mgw_fsm: use LOG_MAP() to log error Change-Id: Ic543a3c17eddf4b1da51172223eccaa62a441fd3 --- M src/osmo-hnbgw/mgw_fsm.c 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: lynxis lazus: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-hnbgw/mgw_fsm.c b/src/osmo-hnbgw/mgw_fsm.c index d44a6e3..3d230c6 100644 --- a/src/osmo-hnbgw/mgw_fsm.c +++ b/src/osmo-hnbgw/mgw_fsm.c @@ -846,9 +846,9 @@ * into account under the assumption that voice calls typically require a single RAB only. Nevertheless, we * will block all incoming RAB assignments that try to assign more (or less) than one RAB. */ if (ranap_rab_ass_req_ies_get_count(&message->msg.raB_AssignmentRequestIEs) != 1) { - LOGP(DMGW, LOGL_ERROR, - "%s() rua_ctx_id=%d, RAB-AssignmentRequest with more than one RAB assignment -- abort!\n", - __func__, map->rua_ctx_id); + LOG_MAP(map, DMGW, LOGL_ERROR, + "%s() RAB-AssignmentRequest with more than one RAB assignment -- abort!\n", + __func__); tx_release_req(map); return -1; } @@ -886,9 +886,9 @@ /* NOTE: This situation is a corner-case. We may end up here when the co-located MGW caused a problem * on the way between RANAP RAB Assignment Request and RANAP RAB Assignment Response. */ - LOGP(DMGW, LOGL_ERROR, - "%s() rua_ctx_id=%d, no MGW fsm -- sending Iu-Release-Request!\n", - __func__, map->rua_ctx_id); + LOG_MAP(map, DMGW, LOGL_ERROR, + "%s() no MGW fsm -- sending Iu-Release-Request!\n", + __func__); /* Send a release request, to make sure that the MSC is aware of the problem. */ tx_release_req(map); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40160?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ic543a3c17eddf4b1da51172223eccaa62a441fd3 Gerrit-Change-Number: 40160 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[XS] Change in osmo-hnbgw[master]: ranap: No need to set destructor function twice

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40158?usp=email ) Change subject: ranap: No need to set destructor function twice ...................................................................... ranap: No need to set destructor function twice talloc destructor function is already being set in hnbgw_decode_ranap_ran_co(), no need to do it twice. This is a leftover from recent refactoring. Fixes: 79c5600bb65e5e940dddfd4b3be50259caa1bd34 Change-Id: I9caaff3bd6435cde51006cd14837f3824c77c68b --- M src/osmo-hnbgw/hnbgw_ranap.c 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified lynxis lazus: Looks good to me, approved diff --git a/src/osmo-hnbgw/hnbgw_ranap.c b/src/osmo-hnbgw/hnbgw_ranap.c index f97f53f..692cf11 100644 --- a/src/osmo-hnbgw/hnbgw_ranap.c +++ b/src/osmo-hnbgw/hnbgw_ranap.c @@ -627,8 +627,6 @@ * information, for RTP mapping via MGW, or GTP mapping via UPF. */ ranap_message *message = hnbgw_decode_ranap_ran_co(ranap_msg); if (message) { - talloc_set_destructor(message, destruct_ranap_ran_rx_co_ies); - LOG_MAP(map, DCN, LOGL_DEBUG, "rx from SCCP: RANAP %s\n", get_value_string(ranap_procedure_code_vals, message->procedureCode)); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40158?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I9caaff3bd6435cde51006cd14837f3824c77c68b Gerrit-Change-Number: 40158 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[XS] Change in osmo-hnbgw[master]: Change level ERROR->NOTICE trying to transmit msg if RUA disconnected

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40159?usp=email ) Change subject: Change level ERROR->NOTICE trying to transmit msg if RUA disconnected ...................................................................... Change level ERROR->NOTICE trying to transmit msg if RUA disconnected Change-Id: I22210e1699709853a9a8bc828cbe5d6379e79e08 --- M src/osmo-hnbgw/context_map_rua.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified lynxis lazus: Looks good to me, approved diff --git a/src/osmo-hnbgw/context_map_rua.c b/src/osmo-hnbgw/context_map_rua.c index ca1a6ed..d408ddd 100644 --- a/src/osmo-hnbgw/context_map_rua.c +++ b/src/osmo-hnbgw/context_map_rua.c @@ -278,7 +278,7 @@ { struct msgb *ranap_msg = data; if (msg_has_l2_data(ranap_msg)) - LOGPFSML(fi, LOGL_ERROR, "RUA not connected, cannot dispatch RANAP message\n"); + LOGPFSML(fi, LOGL_NOTICE, "RUA not connected, cannot dispatch RANAP message\n"); /* Ignore all events. */ } -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40159?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I22210e1699709853a9a8bc828cbe5d6379e79e08 Gerrit-Change-Number: 40159 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[XS] Change in osmo-hnbgw[master]: change log level patching GTP info NOTICE->INFO

by lynxis lazus

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40155?usp=email ) Change subject: change log level patching GTP info NOTICE->INFO ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40155?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I93b8634ff4de52fb7e3f2bfd915552173f27a09a Gerrit-Change-Number: 40155 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Apr 2025 17:15:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log