- gerrit-log - lists.osmocom.org

[XS] Change in osmo-ccid-firmware[master]: ccid_device: Reject XfrBlock with zero-length data
by lynxis lazus 24 Feb '26

24 Feb '26

Attention is currently required from: Hoernchen, jolly, laforge. lynxis lazus has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42192?usp=email ) Change subject: ccid_device: Reject XfrBlock with zero-length data ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Without your patch, it fails in ../ccid_common/iso7816_fsm.c:1260, […] octsim fw: 0.3.32-8bb7 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42192?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I65df88477e4b1c03dc20a8d41e5cbd1c9f363ba8 Gerrit-Change-Number: 42192 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 24 Feb 2026 18:09:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-ccid-firmware[master]: ccid_device: Reject XfrBlock with zero-length data
by lynxis lazus 24 Feb '26

24 Feb '26

Attention is currently required from: Hoernchen, jolly, laforge. lynxis lazus has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42192?usp=email ) Change subject: ccid_device: Reject XfrBlock with zero-length data ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Without your patch, it fails in ../ccid_common/iso7816_fsm.c:1260, the trace shows a different location, but line no 1260 is taking from parsing fmt & args from frame 2. > OSMO_ASSERT(msgb_length(tfp->tpdu) >= sizeof(*tpduh)); (gdb) bt #0 0x0000ae70 in bdg_bkptpanic (fmt=0x16635 "Assert failed %s %s:%d\n", args=...) at ../main.c:44 #1 0x000107ba in osmo_panic (fmt=0x16635 "Assert failed %s %s:%d\n") at panic.c:78 #2 0x00005cf0 in tpdu_s_init_action (fi=0x2000f070, event=<optimized out>, data=0x20013f60) at ../ccid_common/iso7816_fsm.c:1279 #3 0x0000ebda in _osmo_fsm_inst_dispatch (fi=0x2000f070, event=7, data=0x20013f60, file=0x1664d "../ccid_common/iso7816_fsm.c", line=402) at fsm.c:875 #4 0x00004f0a in iso7816_3_wait_tpdu_action (fi=0x2000ecd8, event=7, data=0x20013f60) at ../ccid_common/iso7816_fsm.c:407 #5 0x0000ebda in _osmo_fsm_inst_dispatch (fi=0x2000ecd8, event=event@entry=7, data=data@entry=0x20013f60, file=file@entry=0x16b4b "../ccid_common/ccid_slot_fsm.c", line=line@entry=366) at fsm.c:875 #6 0x000070f6 in iso_fsm_slot_xfr_block_async (cs=0x20001d48 <g_ci>, msg=0x20013f60, xfb=<optimized out>) at ../ccid_common/ccid_slot_fsm.c:366 #7 0x00004850 in ccid_handle_xfr_block (cs=0x20001d48 <g_ci>, msg=0x20013f60) at ../ccid_common/ccid_device.c:464 #8 ccid_handle_out (ci=ci@entry=0x20001d48 <g_ci>, msg=0x20013f60) at ../ccid_common/ccid_device.c:761 #9 0x0000bbac in feed_ccid () at ../main.c:509 #10 main () at ../main.c:731 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42192?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I65df88477e4b1c03dc20a8d41e5cbd1c9f363ba8 Gerrit-Change-Number: 42192 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 24 Feb 2026 18:08:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-bts[master]: RTP: add vty option for ortp vs twrtp selection
by falconia 24 Feb '26

24 Feb '26

Attention is currently required from: pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/42167?usp=email ) Change subject: RTP: add vty option for ortp vs twrtp selection ...................................................................... Patch Set 5: (1 comment) File src/common/vty.c: https://gerrit.osmocom.org/c/osmo-bts/+/42167/comment/cbda2953_a5f0a4be?usp… : PS5, Line 434: if (bts->use_twrtp != g_use_twrtp_default) { > > my implementation only one line of code will need to change at that point […] I don't have extra spoons to fight it - so I'll implement your way in the next patch iteration. I will also include the `--disable-ortp` patch, so you will see more directly how your approach makes it more difficult. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42167?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iff4e3a399250c16ba8fe4cb12e4e22f4c6b346ec Gerrit-Change-Number: 42167 Gerrit-PatchSet: 5 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 24 Feb 2026 17:08:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: mgw: Fix sporadic failure in TC_one_crcx_loopback_rtp
by pespin 24 Feb '26

24 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42196?usp=email ) Change subject: mgw: Fix sporadic failure in TC_one_crcx_loopback_rtp ...................................................................... mgw: Fix sporadic failure in TC_one_crcx_loopback_rtp Change-Id: I29d8d376e343975e3dfeb018bdfda8350bdfc58a --- M mgw/MGCP_Test.ttcn 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/96/42196/1 diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn index 36cd94c..98d63d3 100644 --- a/mgw/MGCP_Test.ttcn +++ b/mgw/MGCP_Test.ttcn @@ -1928,6 +1928,9 @@ f_rtpem_mode(RTPEM[0], RTPEM_MODE_BIDIR); f_sleep(1.0); + /* Now move to RXONLY for a while to wait for in-flight packets to reach back to us: */ + f_rtpem_mode(RTPEM[0], RTPEM_MODE_RXONLY); + f_sleep(1.0); f_flow_delete(RTPEM[0], ep, call_id); stats := f_rtpem_stats_get(RTPEM[0]); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42196?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I29d8d376e343975e3dfeb018bdfda8350bdfc58a Gerrit-Change-Number: 42196 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ccid-firmware[master]: ccid_common: iso_handle_fsm_events: add missing return
by lynxis lazus 24 Feb '26

24 Feb '26

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42160?usp=email ) Change subject: ccid_common: iso_handle_fsm_events: add missing return ...................................................................... ccid_common: iso_handle_fsm_events: add missing return Fix warning about control reaches end of non-void function. Change-Id: I4066c8a1ab1eadb3d8f8cbaf5aa0afbbb2e5dd80 --- M ccid_common/ccid_slot_fsm.c 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve lynxis lazus: Looks good to me, approved diff --git a/ccid_common/ccid_slot_fsm.c b/ccid_common/ccid_slot_fsm.c index 0c56275..c34ad72 100644 --- a/ccid_common/ccid_slot_fsm.c +++ b/ccid_common/ccid_slot_fsm.c @@ -199,7 +199,8 @@ } /* do not free msgbs passed from the fsms, they are statically allocated! */ -static int iso_handle_fsm_events(struct ccid_slot *cs, bool enable){ +static int iso_handle_fsm_events(struct ccid_slot *cs, bool enable) +{ struct iso_fsm_slot *ss = ccid_slot2iso_fsm_slot(cs); struct msgb *tpdu, *resp; volatile uint32_t event = cs->event; @@ -338,6 +339,8 @@ __func__, event, data); break; } + + return 0; } static int iso_fsm_slot_xfr_block_async(struct ccid_slot *cs, struct msgb *msg, -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42160?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I4066c8a1ab1eadb3d8f8cbaf5aa0afbbb2e5dd80 Gerrit-Change-Number: 42160 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ccid-firmware[master]: ccid_common: iso_handle_fsm_events: add missing return
by lynxis lazus 24 Feb '26

24 Feb '26

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42160?usp=email ) Change subject: ccid_common: iso_handle_fsm_events: add missing return ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42160?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I4066c8a1ab1eadb3d8f8cbaf5aa0afbbb2e5dd80 Gerrit-Change-Number: 42160 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 24 Feb 2026 16:10:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: mgw: Improve failure message in f_TC_one_crcx_loopback_rtp()
by pespin 24 Feb '26

24 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42195?usp=email ) Change subject: mgw: Improve failure message in f_TC_one_crcx_loopback_rtp() ...................................................................... mgw: Improve failure message in f_TC_one_crcx_loopback_rtp() Change-Id: I51c656371c330e4689738321d0739e280cab530d --- M mgw/MGCP_Test.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/95/42195/1 diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn index 934179c..36cd94c 100644 --- a/mgw/MGCP_Test.ttcn +++ b/mgw/MGCP_Test.ttcn @@ -1935,10 +1935,10 @@ if (one_phase) { /* osmo-mgw knows both local and remote RTP address. Expect all packets to be reflected. */ if (stats.num_pkts_tx != stats.num_pkts_rx) { - setverdict(fail); + setverdict(fail, "stats.num_pkts_tx=", stats.num_pkts_tx, " != stats.num_pkts_rx=", stats.num_pkts_rx); } if (stats.bytes_payload_tx != stats.bytes_payload_rx) { - setverdict(fail); + setverdict(fail, "stats.bytes_payload_tx=", stats.bytes_payload_tx, " != stats.bytes_payload_rx=", stats.bytes_payload_rx); } } else { /* osmo-mgw knows only the local RTP address. Expect no packets to be reflected. */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42195?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I51c656371c330e4689738321d0739e280cab530d Gerrit-Change-Number: 42195 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: introduce test TC_pfcp_heartbeat_timeout
by pespin 24 Feb '26

24 Feb '26

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42121?usp=email ) Change subject: hnbgw: introduce test TC_pfcp_heartbeat_timeout ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: ping -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42121?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1e0b50bc19e1fa1240274baea1e7fedd1265ffcb Gerrit-Change-Number: 42121 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 24 Feb 2026 15:43:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in libosmo-netif[master]: stream: Improve error handling and logging in write_cb
by pespin 24 Feb '26

24 Feb '26

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/42191?usp=email ) Change subject: stream: Improve error handling and logging in write_cb ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > alternatively, if we submitted a write of zero bytes length, then that's also an error in the applic […] Actually a write(count=0) is an expected correct scenario, see man 2 write: ``` If count is zero and fd refers to a regular file, then write() may return a failure status if one of the errors below is detected. If no errors are detected, or error detection is not performed, 0 is returned without causing any other effect. If count is zero and fd refers to a file other than a regular file, the results are not specified. ``` Also, currently stream_cli and stream_srv are handling that part different, so for sure we want to unify the behavior there... -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/42191?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I68468f0452cbc86b6210bbd1dbfa251579270adb Gerrit-Change-Number: 42191 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 24 Feb 2026 15:11:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[M] Change in osmo-bts[master]: RTP: add vty option for ortp vs twrtp selection
by pespin 24 Feb '26

24 Feb '26

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/42167?usp=email ) Change subject: RTP: add vty option for ortp vs twrtp selection ...................................................................... Patch Set 5: (2 comments) File src/common/vty.c: https://gerrit.osmocom.org/c/osmo-bts/+/42167/comment/ad5a44e4_8ae46c69?usp… : PS5, Line 434: if (bts->use_twrtp != g_use_twrtp_default) { > my implementation only one line of code will need to change at that point same with the other approach, where if (bts->use_twrtp) vty_out(vty, " rtp library twrtp%s", VTY_NEWLINE); becomes if (!bts->use_twrtp) vty_out(vty, " rtp library ortp%s", VTY_NEWLINE); > --disable-ortp When that's added (soon I hope :P) simply add an extra #ifdef HAVE_ORTP around those lines. https://gerrit.osmocom.org/c/osmo-bts/+/42167/comment/1644d785_fc3a6744?usp… : PS5, Line 1529: vty_out(vty, > Considering our already set plan to change the default at some point in the not too distant future, […] I understand your point, but this simply deviates for how all the other N-thousand parameteres we have in the code, because otherwise we'd need to have tons of global variables and it's something I'd like to avoid to make the code more complex. If a user wants to figure out the default, simply drop the config and start the program + use vty, or look at the code, or the user manual. So my opinion on this is that this patch should follow similar ways as done for all the other N-thousand params, otherwise it's more hassle to maintain. It also creates different expectancies for users in relation to the other parameters. If others are fine with having it this way though, I won't oppose. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42167?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iff4e3a399250c16ba8fe4cb12e4e22f4c6b346ec Gerrit-Change-Number: 42167 Gerrit-PatchSet: 5 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 24 Feb 2026 15:08:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log