- gerrit-log - lists.osmocom.org

[S] Change in osmo-asf4-dfu[master]: dfu: irq: GET_STATUS: set state before sending it
by lynxis lazus 24 Feb '26

24 Feb '26

lynxis lazus has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42172?usp=email ) Change subject: dfu: irq: GET_STATUS: set state before sending it ...................................................................... Abandoned Superseeded by https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42178 -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42172?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I6d28404d6936f7ea79fcee90f0c8191f0f623ad8 Gerrit-Change-Number: 42172 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-netif[master]: stream: Improve error handling and logging in write_cb
by laforge 24 Feb '26

24 Feb '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/42191?usp=email ) Change subject: stream: Improve error handling and logging in write_cb ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > well, a write of 0 is not an error _inside_ the syscall, but still an indication of an error of our […] alternatively, if we submitted a write of zero bytes length, then that's also an error in the application. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/42191?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I68468f0452cbc86b6210bbd1dbfa251579270adb Gerrit-Change-Number: 42191 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 24 Feb 2026 13:55:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[M] Change in osmo-bts[master]: RTP: add vty option for ortp vs twrtp selection
by falconia 24 Feb '26

24 Feb '26

Attention is currently required from: pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/42167?usp=email ) Change subject: RTP: add vty option for ortp vs twrtp selection ...................................................................... Patch Set 5: (2 comments) File src/common/vty.c: https://gerrit.osmocom.org/c/osmo-bts/+/42167/comment/22f674d2_986315d9?usp… : PS5, Line 434: if (bts->use_twrtp != g_use_twrtp_default) { > tbh, I see no need for the global variable here. […] I know full well that the approach you describe is the standard way used everywhere else. However, the present case is special: * We already plan from the get-go to change this default in the not too distant future. With my implementation only one line of code will need to change at that point, as opposed to having to remember to rework the vty write-out code for the opposite construct. * I plan on a follow-up patch that will introduce `--disable-ortp` configure option, and I hope we both agree that patch should be merge-able well before we reach the point of making twrtp the new default for everyone. Therefore, there will be a period of time when the default is still ortp in the standard build, but the special build with ortp disabled has to default to twrtp as it is the only supported selection. My global variable implementation is already prepared for this eventuality. https://gerrit.osmocom.org/c/osmo-bts/+/42167/comment/a62230e5_d1650e20?usp… : PS5, Line 1529: vty_out(vty, > I'd say simply add here: […] Considering our already set plan to change the default at some point in the not too distant future, I really feel that both the current setting and the default should be displayed. It is important to know the default in this case, so that the operator can tell which library will be selected with a config file that does not specify `rtp library`. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42167?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iff4e3a399250c16ba8fe4cb12e4e22f4c6b346ec Gerrit-Change-Number: 42167 Gerrit-PatchSet: 5 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 24 Feb 2026 13:33:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-netif[master]: stream: Improve error handling and logging in write_cb
by laforge 24 Feb '26

24 Feb '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/42191?usp=email ) Change subject: stream: Improve error handling and logging in write_cb ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: well, a write of 0 is not an error _inside_ the syscall, but still an indication of an error of our I/O code, like the FD was not writeable and we tried to write > 0 bytes which resulted in a short write, and now we lost some data that wasn't written? -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/42191?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I68468f0452cbc86b6210bbd1dbfa251579270adb Gerrit-Change-Number: 42191 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 24 Feb 2026 13:06:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in docker-playground[master]: ttcn3-bts-test: write bts logs to tmpfs
by laforge 24 Feb '26

24 Feb '26

Attention is currently required from: fixeria, osmith, pespin. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/docker-playground/+/42194?usp=email ) Change subject: ttcn3-bts-test: write bts logs to tmpfs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/42194?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Id9a93f7149ef7e9bfde1f4fe3a8299ba46645d50 Gerrit-Change-Number: 42194 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 24 Feb 2026 13:04:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ccid-firmware[master]: ccid_slot_fsm.c: Reject T=0 TPDU > 260 bytes
by laforge 24 Feb '26

24 Feb '26

Attention is currently required from: Hoernchen, jolly, lynxis lazus. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42193?usp=email ) Change subject: ccid_slot_fsm.c: Reject T=0 TPDU > 260 bytes ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: UNTESTED, PLEASE TEST -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42193?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Iceb0013adf448fe56c909fd8ccf14a021d8b7331 Gerrit-Change-Number: 42193 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 24 Feb 2026 12:48:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-ccid-firmware[master]: ccid_device: Reject XfrBlock with zero-length data
by laforge 24 Feb '26

24 Feb '26

Attention is currently required from: Hoernchen, jolly, lynxis lazus. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42192?usp=email ) Change subject: ccid_device: Reject XfrBlock with zero-length data ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: UNTESTED -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42192?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I65df88477e4b1c03dc20a8d41e5cbd1c9f363ba8 Gerrit-Change-Number: 42192 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 24 Feb 2026 12:48:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in docker-playground[master]: ttcn3-bts-test: write bts logs to tmpfs
by osmith 24 Feb '26

24 Feb '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/42194?usp=email ) Change subject: ttcn3-bts-test: write bts logs to tmpfs ...................................................................... ttcn3-bts-test: write bts logs to tmpfs Pau suggested in the related issue that we try to write the bts logs into tmpfs, instead of directly to ext4. This seems to cause the slow downs, which then result in clock skew errors. Related: SYS#6794#note-29 Change-Id: Id9a93f7149ef7e9bfde1f4fe3a8299ba46645d50 --- M ttcn3-bts-test/jenkins.sh 1 file changed, 16 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/94/42194/1 diff --git a/ttcn3-bts-test/jenkins.sh b/ttcn3-bts-test/jenkins.sh index 6f75266..15163bd 100755 --- a/ttcn3-bts-test/jenkins.sh +++ b/ttcn3-bts-test/jenkins.sh @@ -1,4 +1,9 @@ #!/bin/sh +# Start the bts testsuite. +# In an attempt to avoid clock skew errors (OS#6794), osmo-bts log output is +# written to tmpfs first, and only copied to the jenkins workspace before the +# container gets stopped. + TEST_CONFIGS_ALL="generic virtphy oml hopping" TEST_CONFIGS="${TEST_CONFIGS:-"generic oml hopping"}" @@ -66,6 +71,7 @@ --cap-add=SYS_ADMIN \ --ulimit rtprio=99 \ --ulimit core=-1 \ + --mount type=tmpfs,dst=/tmp \ -v $VOL_BASE_DIR/bts:/data \ -v $VOL_BASE_DIR/unix:/data/unix \ -e "SLEEP_BEFORE_RESPAWN=$sleep_time_respawn" \ @@ -73,7 +79,7 @@ $DOCKER_ARGS \ $extra_args \ $REPO_USER/osmo-bts-$IMAGE_SUFFIX \ - /bin/sh -c "/usr/local/bin/respawn.sh osmo-bts-$variant -c /data/osmo-bts.gen.cfg >>/data/osmo-bts.log 2>&1" + /bin/sh -c "/usr/local/bin/respawn.sh osmo-bts-$variant -c /data/osmo-bts.gen.cfg >>/tmp/osmo-bts.log 2>&1" # Run bpftrace scripts (OS#6794#note-16) if [ "$RUN_BPFTRACE" = "1" ]; then @@ -107,6 +113,11 @@ fi } +stop_bts() { + docker exec "${BUILD_TAG}-bts" sh -c "cat /tmp/osmo-bts.log >> /data/osmo-bts.log" + docker_kill_wait "${BUILD_TAG}-bts" +} + start_fake_trx() { echo Starting container with fake_trx docker run --rm \ @@ -206,7 +217,7 @@ docker_kill_wait ${BUILD_TAG}-trxcon docker_kill_wait ${BUILD_TAG}-fake_trx - docker_kill_wait ${BUILD_TAG}-bts + stop_bts docker_kill_wait ${BUILD_TAG}-bsc } @@ -232,7 +243,7 @@ start_testsuite virtphy docker_kill_wait ${BUILD_TAG}-virtphy - docker_kill_wait ${BUILD_TAG}-bts + stop_bts docker_kill_wait ${BUILD_TAG}-bsc } @@ -253,7 +264,7 @@ docker_kill_wait ${BUILD_TAG}-trxcon docker_kill_wait ${BUILD_TAG}-fake_trx - docker_kill_wait ${BUILD_TAG}-bts + stop_bts } # Frequency hopping tests require different configuration files @@ -276,7 +287,7 @@ docker_kill_wait ${BUILD_TAG}-trxcon docker_kill_wait ${BUILD_TAG}-fake_trx docker_kill_wait ${BUILD_TAG}-bsc - docker_kill_wait ${BUILD_TAG}-bts + stop_bts } check_respawn_count() { -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/42194?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Id9a93f7149ef7e9bfde1f4fe3a8299ba46645d50 Gerrit-Change-Number: 42194 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ccid-firmware[master]: ccid_slot_fsm.c: Reject T=0 TPDU > 260 bytes
by laforge 24 Feb '26

24 Feb '26

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42193?usp=email ) Change subject: ccid_slot_fsm.c: Reject T=0 TPDU > 260 bytes ...................................................................... ccid_slot_fsm.c: Reject T=0 TPDU > 260 bytes The CCID v1.1 specification states a T=0 TPDU must not exceed 260 bytes, so let's properly handle this error case. Change-Id: Iceb0013adf448fe56c909fd8ccf14a021d8b7331 --- M ccid_common/ccid_slot_fsm.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/93/42193/1 diff --git a/ccid_common/ccid_slot_fsm.c b/ccid_common/ccid_slot_fsm.c index 0c56275..027dc2c 100644 --- a/ccid_common/ccid_slot_fsm.c +++ b/ccid_common/ccid_slot_fsm.c @@ -356,6 +356,11 @@ if (msgb_length(msg) != xfb->hdr.dwLength + 10) return -1; + /* CCID spec v1.1 Section 6.1.4 states: + * "the absolute maximum block size for a TPDU T=0 block is 260 * bytes" */ + if (xfb->hdr.dwLength > 260) + return -1; + /* might be unpowered after failed ppss that led to reset */ if (cs->icc_powered != true) return -0; -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42193?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Iceb0013adf448fe56c909fd8ccf14a021d8b7331 Gerrit-Change-Number: 42193 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-ccid-firmware[master]: ccid_device: Reject XfrBlock with zero-length data
by laforge 24 Feb '26

24 Feb '26

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42192?usp=email ) Change subject: ccid_device: Reject XfrBlock with zero-length data ...................................................................... ccid_device: Reject XfrBlock with zero-length data While the CCID v1.1 spec seems to declare dwLength == 0 is within the valid range, it's of course a no-op as we cannot transact a TPDU that isn't there. Change-Id: I65df88477e4b1c03dc20a8d41e5cbd1c9f363ba8 --- M ccid_common/ccid_device.c 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/92/42192/1 diff --git a/ccid_common/ccid_device.c b/ccid_common/ccid_device.c index acee696..bf131a9 100644 --- a/ccid_common/ccid_device.c +++ b/ccid_common/ccid_device.c @@ -460,6 +460,13 @@ struct msgb *resp; int rc; + if (u->xfr_block.hdr.dwLength == 0) { + /* CCID Rev 1.1 permits a zero-length XfrBlock on the protocol level, but what should we do + * with a zero-length TPDU? We need to reject it as bError=1 (Bad dwLength) */ + resp = ccid_gen_data_block(cs, u->xfr_block.hdr.bSeq, CCID_CMD_STATUS_FAILED, 1, 0, 0); + goto out; + } + /* handle this asynchronously */ rc = cs->ci->slot_ops->xfr_block_async(cs, msg, &u->xfr_block); if (rc <= 0) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42192?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I65df88477e4b1c03dc20a8d41e5cbd1c9f363ba8 Gerrit-Change-Number: 42192 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

2026

2025

2024

2023

2022

gerrit-log