- gerrit-log - lists.osmocom.org

[XS] Change in osmo-asf4-dfu[master]: dfu: make resp buffer static
by lynxis lazus 24 Feb '26

24 Feb '26

Attention is currently required from: Hoernchen. lynxis lazus has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42179?usp=email ) Change subject: dfu: make resp buffer static ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42179?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I2f9336143190350817e6352b00751b35b1600b62 Gerrit-Change-Number: 42179 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Tue, 24 Feb 2026 11:56:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-asf4-dfu[master]: dfu: fix bState transition/reporting order as per dfu spec
by lynxis lazus 24 Feb '26

24 Feb '26

Attention is currently required from: Hoernchen, pespin. lynxis lazus has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42178?usp=email ) Change subject: dfu: fix bState transition/reporting order as per dfu spec ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42178?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I06519c73cdb0b082002632da9cfe7436c63f52b0 Gerrit-Change-Number: 42178 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 24 Feb 2026 11:56:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-netif[master]: stream: Improve error handling and logging in write_cb
by pespin 24 Feb '26

24 Feb '26

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/42191?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: stream: Improve error handling and logging in write_cb ...................................................................... stream: Improve error handling and logging in write_cb Nowhere in man 2 write/send/sendmsg it can be read that a return of 0 is actually an error, so avoid handling that case as error in stream_cli. While at ti, log the errno string. Change-Id: I68468f0452cbc86b6210bbd1dbfa251579270adb --- M src/stream_cli.c M src/stream_srv.c 2 files changed, 9 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/91/42191/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/42191?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I68468f0452cbc86b6210bbd1dbfa251579270adb Gerrit-Change-Number: 42191 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[XS] Change in libosmo-netif[master]: stream_cli: Log errno string if write failed
by pespin 24 Feb '26

24 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/42191?usp=email ) Change subject: stream_cli: Log errno string if write failed ...................................................................... stream_cli: Log errno string if write failed Change-Id: I68468f0452cbc86b6210bbd1dbfa251579270adb --- M src/stream_cli.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/91/42191/1 diff --git a/src/stream_cli.c b/src/stream_cli.c index e59122b..1c1d3df 100644 --- a/src/stream_cli.c +++ b/src/stream_cli.c @@ -605,7 +605,9 @@ break; case STREAM_CLI_STATE_CONNECTED: if (msg && res <= 0) { - LOGSCLI(cli, LOGL_ERROR, "received error %d in response to send\n", res); + char errbuf[64]; + strerror_r(errno, errbuf, sizeof(errbuf)); + LOGSCLI(cli, LOGL_ERROR, "received error %d (%s) in response to send\n", errno, errbuf); (void)stream_cli_reconnect(cli); } /* res=0 && msgb=NULL: "connected notify", but we already received before a read_cb -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/42191?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I68468f0452cbc86b6210bbd1dbfa251579270adb Gerrit-Change-Number: 42191 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in pysim[master]: contrib/smpp-ota-tool: fix boolean commandline parameters
by laforge 24 Feb '26

24 Feb '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42188?usp=email ) Change subject: contrib/smpp-ota-tool: fix boolean commandline parameters ...................................................................... contrib/smpp-ota-tool: fix boolean commandline parameters Boolean parameters should be false by default and use store_true when set. Change-Id: I0652b48d2ea5efbaaf5bc147aa8cef7ab8b0861d Related: OS#6868 --- M contrib/smpp-ota-tool.py 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/contrib/smpp-ota-tool.py b/contrib/smpp-ota-tool.py index 02ddfc0..91b6dd2 100755 --- a/contrib/smpp-ota-tool.py +++ b/contrib/smpp-ota-tool.py @@ -194,12 +194,12 @@ option_parser.add_argument('--tar', required=True, type=is_hexstr, help='Toolkit Application Reference') option_parser.add_argument("--cntr_req", choices=CNTR_REQ.decmapping.values(), default='no_counter', help="Counter requirement") - option_parser.add_argument('--ciphering', default=True, type=bool, help='Enable ciphering') + option_parser.add_argument('--no-ciphering', action='store_true', default=False, help='Disable ciphering') option_parser.add_argument("--rc-cc-ds", choices=RC_CC_DS.decmapping.values(), default='cc', help="message check (rc=redundency check, cc=crypt. checksum, ds=digital signature)") - option_parser.add_argument('--por-in-submit', default=False, type=bool, + option_parser.add_argument('--por-in-submit', action='store_true', default=False, help='require PoR to be sent via SMS-SUBMIT') - option_parser.add_argument('--por-shall-be-ciphered', default=True, type=bool, help='require encrypted PoR') + option_parser.add_argument('--por-no-ciphering', action='store_true', default=False, help='Disable ciphering (PoR)') option_parser.add_argument("--por-rc-cc-ds", choices=RC_CC_DS.decmapping.values(), default='cc', help="PoR check (rc=redundency check, cc=crypt. checksum, ds=digital signature)") option_parser.add_argument("--por_req", choices=POR_REQ.decmapping.values(), default='por_required', @@ -226,10 +226,10 @@ kid=h2b(opts.kid), cntr=opts.cntr) spi = {'counter' : opts.cntr_req, - 'ciphering' : opts.ciphering, + 'ciphering' : not opts.no_ciphering, 'rc_cc_ds': opts.rc_cc_ds, - 'por_shall_be_ciphered':opts.por_shall_be_ciphered, 'por_in_submit': opts.por_in_submit, + 'por_shall_be_ciphered': not opts.por_no_ciphering, 'por_rc_cc_ds': opts.por_rc_cc_ds, 'por': opts.por_req} apdu = h2b("".join(opts.apdu)) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42188?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0652b48d2ea5efbaaf5bc147aa8cef7ab8b0861d Gerrit-Change-Number: 42188 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in pysim[master]: contrib/smpp-ota-tool: fix boolean commandline parameters
by laforge 24 Feb '26

24 Feb '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42188?usp=email ) Change subject: contrib/smpp-ota-tool: fix boolean commandline parameters ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42188?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0652b48d2ea5efbaaf5bc147aa8cef7ab8b0861d Gerrit-Change-Number: 42188 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 24 Feb 2026 10:35:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: contrib/smpp-ota-tool: warn about mixed up KIC/KIC indexes
by laforge 24 Feb '26

24 Feb '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42186?usp=email ) Change subject: contrib/smpp-ota-tool: warn about mixed up KIC/KIC indexes ...................................................................... contrib/smpp-ota-tool: warn about mixed up KIC/KIC indexes Cards usually have multiple sets of KIC, KID (and KIK). The keys are selected through an index. However, mixing keys from different sets is concidered as a security violation and cards should reject such configurations. Let's print a warning to make users aware that something is off. Change-Id: Ieb4e14145baba1c2cb4a237b612b04694940f402 Related: OS#6868 --- M contrib/smpp-ota-tool.py 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/contrib/smpp-ota-tool.py b/contrib/smpp-ota-tool.py index c2e9562..0903533 100755 --- a/contrib/smpp-ota-tool.py +++ b/contrib/smpp-ota-tool.py @@ -214,6 +214,10 @@ format='%(asctime)s %(levelname)s %(message)s', datefmt='%Y-%m-%d %H:%M:%S') + if opts.kic_idx != opts.kid_idx: + logger.warning("KIC index (%s) and KID index (%s) are different (security violation, card should reject message)", + opts.kic_idx, opts.kid_idx) + ota_keyset = OtaKeyset(algo_crypt=opts.algo_crypt, kic_idx=opts.kic_idx, kic=h2b(opts.kic), -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42186?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ieb4e14145baba1c2cb4a237b612b04694940f402 Gerrit-Change-Number: 42186 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: contrib/smpp-ota-tool: add missing usage helpstrings
by laforge 24 Feb '26

24 Feb '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42187?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: contrib/smpp-ota-tool: add missing usage helpstrings ...................................................................... contrib/smpp-ota-tool: add missing usage helpstrings Change-Id: Ic1521ba11b405f311a30fdb3585ad518375669ae Related: OS#6868 --- M contrib/smpp-ota-tool.py 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/contrib/smpp-ota-tool.py b/contrib/smpp-ota-tool.py index 0903533..02ddfc0 100755 --- a/contrib/smpp-ota-tool.py +++ b/contrib/smpp-ota-tool.py @@ -204,9 +204,9 @@ help="PoR check (rc=redundency check, cc=crypt. checksum, ds=digital signature)") option_parser.add_argument("--por_req", choices=POR_REQ.decmapping.values(), default='por_required', help="Proof of Receipt requirements") - option_parser.add_argument('--src-addr', default='12', type=str, help='TODO') - option_parser.add_argument('--dest-addr', default='23', type=str, help='TODO') - option_parser.add_argument('--timeout', default=10, type=int, help='TODO') + option_parser.add_argument('--src-addr', default='12', type=str, help='SMS source address (MSISDN)') + option_parser.add_argument('--dest-addr', default='23', type=str, help='SMS destination address (MSISDN)') + option_parser.add_argument('--timeout', default=10, type=int, help='Maximum response waiting time') option_parser.add_argument('-a', '--apdu', action='append', required=True, type=is_hexstr, help='C-APDU to send') opts = option_parser.parse_args() -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42187?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic1521ba11b405f311a30fdb3585ad518375669ae Gerrit-Change-Number: 42187 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: BSSAP_LE_Emulation: Increase timeout in f_bssap_le_wait_sccp_peer_ava...
by pespin 24 Feb '26

24 Feb '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42181?usp=email ) Change subject: BSSAP_LE_Emulation: Increase timeout in f_bssap_le_wait_sccp_peer_available() ...................................................................... BSSAP_LE_Emulation: Increase timeout in f_bssap_le_wait_sccp_peer_available() It was spotted in SMLC_Tests.ttcn that the current timeout may be too short, and the test fails because ttcn3 connects to STP and receives a DUNA, and then the IUT (osmo-smlc) connects to STP around 4 seconds later, which is too late with existing timeout. Change-Id: I2d4210bf5785a09bf384a1534c407dcf63b1c38b --- M library/BSSAP_LE_Emulation.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/library/BSSAP_LE_Emulation.ttcn b/library/BSSAP_LE_Emulation.ttcn index 1786af5..a0bde0a 100644 --- a/library/BSSAP_LE_Emulation.ttcn +++ b/library/BSSAP_LE_Emulation.ttcn @@ -530,7 +530,7 @@ f_ML3_patch_seq_nr(seq_nr, enc_l3); } -function f_bssap_le_wait_sccp_peer_available(BSSAP_LE_CODEC_PT pt, integer peer_pc, float timeout_sec := 3.0) +function f_bssap_le_wait_sccp_peer_available(BSSAP_LE_CODEC_PT pt, integer peer_pc, float timeout_sec := 5.0) { timer T; var ASP_SCCP_N_PCSTATE_ind n_pcstate_ind; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42181?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2d4210bf5785a09bf384a1534c407dcf63b1c38b Gerrit-Change-Number: 42181 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-gsm-manuals[master]: sigtran-osmocom.adoc: Describe tcap-aware loadshare
by pespin 24 Feb '26

24 Feb '26

Attention is currently required from: daniel. pespin has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/42190?usp=email ) Change subject: sigtran-osmocom.adoc: Describe tcap-aware loadshare ...................................................................... Patch Set 1: (1 comment) File common/chapters/sigtran-osmocom.adoc: https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/42190/comment/92744bc8_0b4c… : PS1, Line 201: ASP. I'm missing here: * How to configure an ASP to be TCAP-aware * Describing the IPA extension to register rances of TCAP IDs, and how the logic works at the STP. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/42190?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I58979e8f6c5156706b1016069eaaf2801ec9311b Gerrit-Change-Number: 42190 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 24 Feb 2026 09:57:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2026

2025

2024

2023

2022

gerrit-log