- gerrit-log - lists.osmocom.org

Change in libosmo-sccp[master]: SIGTRAN: add function to check connection existence
by msuraev 18 Aug '22

18 Aug '22

Attention is currently required from: neels, fixeria, msuraev. Hello Jenkins Builder, neels, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 to look at the new patch set (#10). Change subject: SIGTRAN: add function to check connection existence ...................................................................... SIGTRAN: add function to check connection existence Add convenience helper to check if particular connection ID exists and use it to properly report errors when attempting to send messages over non-existent connections. Change-Id: Iffedf55b4c292ee6b2f97bcdeef6dc13c050ce01 --- M examples/sccp_test_vty.c M include/osmocom/sigtran/sccp_helpers.h M src/sccp_helpers.c M src/sccp_scoc.c 4 files changed, 36 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/87/29087/10 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Iffedf55b4c292ee6b2f97bcdeef6dc13c050ce01 Gerrit-Change-Number: 29087 Gerrit-PatchSet: 10 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in libosmocore[master]: use_count: Return if uc is NULL
by neels 18 Aug '22

18 Aug '22

neels has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29121 ) Change subject: use_count: Return if uc is NULL ...................................................................... use_count: Return if uc is NULL The documentation for osmo_use_count_get_put states the return value is "Negative on range violations or USE_LIST == NULL, the use_cb()'s return value, or 0 on success" However, the code in _osmo_use_count_get_put doesn't check if uc is NULL - instead it would crash in osmo_use_count_find() where it is dereferenced. Add a check for uc and return -EINVAL if it is NULL. Change-Id: I792563696860a3100e95cafdd5fe57511819ef56 Related: SYS#5895 --- M src/use_count.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: neels: Looks good to me, approved fixeria: Looks good to me, but someone else must approve dexter: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/use_count.c b/src/use_count.c index 6c52899..9714403 100644 --- a/src/use_count.c +++ b/src/use_count.c @@ -235,6 +235,8 @@ { struct osmo_use_count_entry *e; int32_t old_use_count; + if (!uc) + return -EINVAL; if (!change) return 0; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29121 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I792563696860a3100e95cafdd5fe57511819ef56 Gerrit-Change-Number: 29121 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in libosmocore[master]: use_count: Return if uc is NULL
by neels 18 Aug '22

18 Aug '22

Attention is currently required from: daniel. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29121 ) Change subject: use_count: Return if uc is NULL ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29121 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I792563696860a3100e95cafdd5fe57511819ef56 Gerrit-Change-Number: 29121 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Aug 2022 14:13:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmocore[master]: use_count: Return if uc is NULL
by fixeria 18 Aug '22

18 Aug '22

Attention is currently required from: neels, daniel. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29121 ) Change subject: use_count: Return if uc is NULL ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29121 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I792563696860a3100e95cafdd5fe57511819ef56 Gerrit-Change-Number: 29121 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Aug 2022 14:06:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Build failure of network:osmocom:nightly/osmo-upf in openSUSE_Tumbleweed/x86_64
by OBS Notification 18 Aug '22

18 Aug '22

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo-upf failed to build in openSUSE_Tumbleweed/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-upf Last lines of build log: [ 44s] checking whether to build static libraries... yes [ 44s] checking for pkg-config... /usr/bin/pkg-config [ 44s] checking for x86_64-suse-linux-gnu-pkg-config... /usr/bin/x86_64-suse-linux-gnu-pkg-config [ 44s] checking pkg-config is at least version 0.20... yes [ 44s] checking for LIBOSMOCORE... yes [ 44s] checking for LIBOSMOVTY... yes [ 44s] checking for LIBOSMOCTRL... yes [ 44s] checking for LIBOSMOGTLV... no [ 44s] configure: error: Package requirements (libosmo-gtlv >= 0.1.0) were not met: [ 44s] [ 44s] Package 'libosmo-gtlv', required by 'virtual:world', not found [ 44s] [ 44s] Consider adjusting the PKG_CONFIG_PATH environment variable if you [ 44s] installed software in a non-standard prefix. [ 44s] [ 44s] Alternatively, you may set the environment variables LIBOSMOGTLV_CFLAGS [ 44s] and LIBOSMOGTLV_LIBS to avoid the need to call pkg-config. [ 44s] See the pkg-config man page for more details. [ 44s] error: Bad exit status from /var/tmp/rpm-tmp.sj6drq (%build) [ 44s] [ 44s] RPM build errors: [ 44s] Bad exit status from /var/tmp/rpm-tmp.sj6drq (%build) [ 44s] ### VM INTERACTION START ### [ 44s] [ 37.697494][ T1] sysrq: Power Off [ 44s] [ 37.700408][ T18] reboot: Power down [ 44s] ### VM INTERACTION END ### [ 44s] [ 44s] lamb16 failed "build osmo-upf.spec" at Thu Aug 18 13:29:37 UTC 2022. [ 44s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

1 0

Change in osmo-ci[master]: repo-install-test: adjust for obs.osmocom.org
by fixeria 18 Aug '22

18 Aug '22

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29157 ) Change subject: repo-install-test: adjust for obs.osmocom.org ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29157 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib53df6c40ae92634e6d93389dcb8a21c48dfb63d Gerrit-Change-Number: 29157 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Aug 2022 13:28:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: repo-install-test: don't use next repository
by fixeria 18 Aug '22

18 Aug '22

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29156 ) Change subject: repo-install-test: don't use next repository ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29156 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I73a6c051c423eb30ddeab1688fc78fe959e60cf4 Gerrit-Change-Number: 29156 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Aug 2022 13:28:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Build failure of network:osmocom:nightly/libosmo-pfcp in openSUSE_Tumbleweed/x86_64
by OBS Notification 18 Aug '22

18 Aug '22

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/l… Package network:osmocom:nightly/libosmo-pfcp failed to build in openSUSE_Tumbleweed/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-pfcp Last lines of build log: [ 41s] make[3]: Entering directory '/home/abuild/rpmbuild/BUILD/libosmo-pfcp/doc' [ 41s] make[3]: Nothing to be done for 'check-am'. [ 41s] make[3]: Leaving directory '/home/abuild/rpmbuild/BUILD/libosmo-pfcp/doc' [ 41s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/libosmo-pfcp/doc' [ 41s] Making check in contrib [ 41s] make[2]: Entering directory '/home/abuild/rpmbuild/BUILD/libosmo-pfcp/contrib' [ 41s] make[2]: Nothing to be done for 'check'. [ 41s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/libosmo-pfcp/contrib' [ 41s] make[2]: Entering directory '/home/abuild/rpmbuild/BUILD/libosmo-pfcp' [ 41s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/libosmo-pfcp' [ 41s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/libosmo-pfcp' [ 41s] + RPM_EC=0 [ 41s] ++ jobs -p [ 41s] + exit 0 [ 41s] Processing files: libosmo-pfcp-debugsource-0.1.0.26.6ec5.202208180052-1.1.x86_64 [ 41s] Provides: libosmo-pfcp-debugsource = 0.1.0.26.6ec5.202208180052-1.1 libosmo-pfcp-debugsource(x86-64) = 0.1.0.26.6ec5.202208180052-1.1 [ 41s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 41s] Processing files: libosmo-gtlv0-0.1.0.26.6ec5.202208180052-1.1.x86_64 [ 41s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/libosmo-pfcp-0.1.0.26.6ec5.202208180052-1.1.x86_64/usr/lib64/libosmo-gltv.so.0* [ 41s] [ 41s] RPM build errors: [ 41s] File not found: /home/abuild/rpmbuild/BUILDROOT/libosmo-pfcp-0.1.0.26.6ec5.202208180052-1.1.x86_64/usr/lib64/libosmo-gltv.so.0* [ 41s] ### VM INTERACTION START ### [ 41s] [ 37.616701][ T1] sysrq: Power Off [ 41s] [ 37.618673][ T18] reboot: Power down [ 41s] ### VM INTERACTION END ### [ 41s] [ 41s] sheep83 failed "build libosmo-pfcp.spec" at Thu Aug 18 13:21:46 UTC 2022. [ 41s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

1 0

Change in osmo-ci[master]: obs: checkout_for_feed + fetch: fix for 2022q1 etc
by osmith 18 Aug '22

18 Aug '22

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29150 ) Change subject: obs: checkout_for_feed + fetch: fix for 2022q1 etc ...................................................................... obs: checkout_for_feed + fetch: fix for 2022q1 etc As Neels pointed out, with the current code the 2022q1 and similar feeds do not get checked out properly if: * the repository was not freshly cloned (like jenkins would do) * the repository was fetched (--git-fetch) Instead of the last revision of that branch from origin, we get the revision that was previously checked out on the branch. Fix this by prepending origin/. Change-Id: I2e265fc84abd4596c386bb56cbabb2af121dc7ca --- M scripts/obs/lib/srcpkg.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: neels: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/scripts/obs/lib/srcpkg.py b/scripts/obs/lib/srcpkg.py index ec29581..92c3aa7 100644 --- a/scripts/obs/lib/srcpkg.py +++ b/scripts/obs/lib/srcpkg.py @@ -16,7 +16,7 @@ elif feed == "nightly": lib.git.checkout_default_branch(project) else: # 2022q1 etc - lib.git.checkout(project, feed) + lib.git.checkout(project, f"origin/{feed}") def get_git_version_gen_path(project): -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29150 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2e265fc84abd4596c386bb56cbabb2af121dc7ca Gerrit-Change-Number: 29150 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-ci[master]: obs: make git fetch the default
by osmith 18 Aug '22

18 Aug '22

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29151 ) Change subject: obs: make git fetch the default ...................................................................... obs: make git fetch the default As discussed with Neels, it makes more sense to fetch git repos by default. Change-Id: Ib8adfbcf59d66b26f322ad22b2df1ccbeaf15af7 --- M jobs/osmocom-obs.yml M scripts/obs/README M scripts/obs/lib/__init__.py 3 files changed, 4 insertions(+), 9 deletions(-) Approvals: neels: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/jobs/osmocom-obs.yml b/jobs/osmocom-obs.yml index cb8cef1..06b4ecb 100644 --- a/jobs/osmocom-obs.yml +++ b/jobs/osmocom-obs.yml @@ -38,7 +38,6 @@ --conflict-version {conflict_version} \ --docker \ --feed {type} \ - --git-fetch \ --meta \ {proj}:{type} scm: diff --git a/scripts/obs/README b/scripts/obs/README index 6d18f7d..d9499d8 100644 --- a/scripts/obs/README +++ b/scripts/obs/README @@ -88,11 +88,7 @@ -------------------------------------- cd ~/osmo-dev/src/osmo-ci/scripts/obs/ - ./update_obs_project.py -g -b origin/neels/pkg home:nhofmeyr:test osmo-hnbgw - -The -g option ensures that the latest branch tip is fetched from Osmocom's git. -Without it, the cached git repository will stay stuck on its currently checked -out branch version -- you will keep submitting the same state. + ./update_obs_project.py -b origin/neels/pkg home:nhofmeyr:test osmo-hnbgw The -b option chooses a custom branch to build. It is important to prepend 'origin/' to 'your/branch', so that repeated dev cycles use the latest branch diff --git a/scripts/obs/lib/__init__.py b/scripts/obs/lib/__init__.py index b490ae8..a07a072 100644 --- a/scripts/obs/lib/__init__.py +++ b/scripts/obs/lib/__init__.py @@ -27,9 +27,9 @@ parser.add_argument("-d", "--docker", help="run in docker to avoid installing required pkgs", action="store_true") - parser.add_argument("-g", "--git-fetch", - help="fetch already cloned git repositories", - action="store_true") + parser.add_argument("-s", "--git-skip-fetch", + help="do not fetch already cloned git repositories", + action="store_false", dest="git_fetch") parser.add_argument("-m", "--meta", action="store_true", help="build a meta package (e.g. osmocom-nightly)") parser.add_argument("-c", "--conflict-version", nargs="?", -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29151 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib8adfbcf59d66b26f322ad22b2df1ccbeaf15af7 Gerrit-Change-Number: 29151 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 0

2026

2025

2024

2023

2022

gerrit-log