- gerrit-log - lists.osmocom.org

[S] Change in docker-playground[master]: ttcn3-bts-test: write bts logs to tmpfs
by pespin 25 Feb '26

25 Feb '26

pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/docker-playground/+/42194?usp=email ) Change subject: ttcn3-bts-test: write bts logs to tmpfs ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File ttcn3-bts-test/jenkins.sh: https://gerrit.osmocom.org/c/docker-playground/+/42194/comment/1e01cf6a_b24… : PS1, Line 117: docker exec "${BUILD_TAG}-bts" sh -c "cat /tmp/osmo-bts.log >> /data/osmo-bts.log" > Done It would then be good to take the chance to keep the osmo-bts.log split into multiple files, to ease looking for subset of tests, but fine anyway. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/42194?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Id9a93f7149ef7e9bfde1f4fe3a8299ba46645d50 Gerrit-Change-Number: 42194 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Feb 2026 09:37:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-bts[master]: RTP: make ortp optional at compile time
by pespin 25 Feb '26

25 Feb '26

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/42197?usp=email ) Change subject: RTP: make ortp optional at compile time ...................................................................... Patch Set 2: (1 comment) File contrib/ber/Makefile.am: https://gerrit.osmocom.org/c/osmo-bts/+/42197/comment/9110c645_d90ee222?usp… : PS2, Line 1: if ENABLE_ORTP > Add this to the parent Makefile to conditionally add it to SUBDIR so this file is not even processed […] See how it's done for instance in osmo-bsc/src/Makefile.am:22 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42197?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib171bd42a65117457319befee2615e0c36c8d9e1 Gerrit-Change-Number: 42197 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Wed, 25 Feb 2026 09:35:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-bts[master]: RTP: make ortp optional at compile time
by pespin 25 Feb '26

25 Feb '26

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/42197?usp=email ) Change subject: RTP: make ortp optional at compile time ...................................................................... Patch Set 2: (3 comments) Patchset: PS2: I see these 2 ORTP references, but they are probably wrong and can be dropped since they should come from libosmo-netif pkgcfg if needed: src/osmo-bts-oc2g/Makefile.am 17: $(ORTP_CFLAGS) \ 29: $(ORTP_LIBS) \ Do you mind submitting an extra patch dropping them? I can do it myself but I don't want to interfere with your changes. File contrib/ber/Makefile.am: https://gerrit.osmocom.org/c/osmo-bts/+/42197/comment/71258ed1_67d4e696?usp… : PS2, Line 1: if ENABLE_ORTP Add this to the parent Makefile to conditionally add it to SUBDIR so this file is not even processed? File src/common/bts.c: https://gerrit.osmocom.org/c/osmo-bts/+/42197/comment/7c27856c_c8f7bf61?usp… : PS2, Line 406: { you don't really need {} afaict, we are enforcing -std=gnu11 during build in configure.ac? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42197?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib171bd42a65117457319befee2615e0c36c8d9e1 Gerrit-Change-Number: 42197 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Wed, 25 Feb 2026 09:34:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-bts[master]: RTP: add vty option for ortp vs twrtp selection
by pespin 25 Feb '26

25 Feb '26

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/42167?usp=email ) Change subject: RTP: add vty option for ortp vs twrtp selection ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42167?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iff4e3a399250c16ba8fe4cb12e4e22f4c6b346ec Gerrit-Change-Number: 42167 Gerrit-PatchSet: 6 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Wed, 25 Feb 2026 09:25:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-trx[master]: fix(threads): support GNU and POSIX strerror_r variants
by Timur Davydov 25 Feb '26

25 Feb '26

Timur Davydov has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/42199?usp=email ) Change subject: fix(threads): support GNU and POSIX strerror_r variants ...................................................................... fix(threads): support GNU and POSIX strerror_r variants - Add required headers - Use correct handling for GNU-specific strerror_r - Provide fallback error string for portability Change-Id: I642aff8a9f98823e117c4debd19384ddf5975039 --- M CommonLibs/Threads.cpp 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/99/42199/1 diff --git a/CommonLibs/Threads.cpp b/CommonLibs/Threads.cpp index 377a1b0..22191f0 100644 --- a/CommonLibs/Threads.cpp +++ b/CommonLibs/Threads.cpp @@ -27,6 +27,8 @@ #include <string.h> #include <sys/types.h> +#include <errno.h> +#include <stdio.h> #include "Threads.h" #include "Timeval.h" @@ -53,7 +55,17 @@ } else { char buf[256]; int err = errno; - char* err_str = strerror_r(err, buf, sizeof(buf)); + char *err_str = NULL; +#if defined(__GLIBC__) && defined(_GNU_SOURCE) + err_str = strerror_r(err, buf, sizeof(buf)); +#else + if (strerror_r(err, buf, sizeof(buf)) == 0) { + err_str = buf; + } else { + snprintf(buf, sizeof(buf), "Unknown error %d", err); + err_str = buf; + } +#endif LOG(NOTICE) << "Thread "<< selfid << " (task " << tid << ") set name \"" << name << "\" failed: (" << err << ") " << err_str; } } -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42199?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I642aff8a9f98823e117c4debd19384ddf5975039 Gerrit-Change-Number: 42199 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[S] Change in osmo-ttcn3-hacks[master]: 5gc: Split f_start_handler_with_pars() into multiple helpers
by osmith 25 Feb '26

25 Feb '26

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42153?usp=email ) Change subject: 5gc: Split f_start_handler_with_pars() into multiple helpers ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42153?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic60009c5f7fcdc43f6e13f9ea469bfaddc639c33 Gerrit-Change-Number: 42153 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Feb 2026 07:50:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: Fix race conditions during PFCP Association
by osmith 25 Feb '26

25 Feb '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42182?usp=email ) Change subject: hnbgw: Fix race conditions during PFCP Association ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42182?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If62bd6c6e4d6cf73791029172d3d8880629f36a8 Gerrit-Change-Number: 42182 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Feb 2026 07:49:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in docker-playground[master]: ttcn3-bts-test: write bts logs to tmpfs
by osmith 25 Feb '26

25 Feb '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/42194?usp=email ) Change subject: ttcn3-bts-test: write bts logs to tmpfs ...................................................................... ttcn3-bts-test: write bts logs to tmpfs Pau suggested in the related issue that we try to write the bts logs into tmpfs, instead of directly to ext4. This seems to cause the slow downs, which then result in clock skew errors. Related: SYS#6794#note-29 Change-Id: Id9a93f7149ef7e9bfde1f4fe3a8299ba46645d50 --- M ttcn3-bts-test/jenkins.sh 1 file changed, 16 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/ttcn3-bts-test/jenkins.sh b/ttcn3-bts-test/jenkins.sh index 6f75266..15163bd 100755 --- a/ttcn3-bts-test/jenkins.sh +++ b/ttcn3-bts-test/jenkins.sh @@ -1,4 +1,9 @@ #!/bin/sh +# Start the bts testsuite. +# In an attempt to avoid clock skew errors (OS#6794), osmo-bts log output is +# written to tmpfs first, and only copied to the jenkins workspace before the +# container gets stopped. + TEST_CONFIGS_ALL="generic virtphy oml hopping" TEST_CONFIGS="${TEST_CONFIGS:-"generic oml hopping"}" @@ -66,6 +71,7 @@ --cap-add=SYS_ADMIN \ --ulimit rtprio=99 \ --ulimit core=-1 \ + --mount type=tmpfs,dst=/tmp \ -v $VOL_BASE_DIR/bts:/data \ -v $VOL_BASE_DIR/unix:/data/unix \ -e "SLEEP_BEFORE_RESPAWN=$sleep_time_respawn" \ @@ -73,7 +79,7 @@ $DOCKER_ARGS \ $extra_args \ $REPO_USER/osmo-bts-$IMAGE_SUFFIX \ - /bin/sh -c "/usr/local/bin/respawn.sh osmo-bts-$variant -c /data/osmo-bts.gen.cfg >>/data/osmo-bts.log 2>&1" + /bin/sh -c "/usr/local/bin/respawn.sh osmo-bts-$variant -c /data/osmo-bts.gen.cfg >>/tmp/osmo-bts.log 2>&1" # Run bpftrace scripts (OS#6794#note-16) if [ "$RUN_BPFTRACE" = "1" ]; then @@ -107,6 +113,11 @@ fi } +stop_bts() { + docker exec "${BUILD_TAG}-bts" sh -c "cat /tmp/osmo-bts.log >> /data/osmo-bts.log" + docker_kill_wait "${BUILD_TAG}-bts" +} + start_fake_trx() { echo Starting container with fake_trx docker run --rm \ @@ -206,7 +217,7 @@ docker_kill_wait ${BUILD_TAG}-trxcon docker_kill_wait ${BUILD_TAG}-fake_trx - docker_kill_wait ${BUILD_TAG}-bts + stop_bts docker_kill_wait ${BUILD_TAG}-bsc } @@ -232,7 +243,7 @@ start_testsuite virtphy docker_kill_wait ${BUILD_TAG}-virtphy - docker_kill_wait ${BUILD_TAG}-bts + stop_bts docker_kill_wait ${BUILD_TAG}-bsc } @@ -253,7 +264,7 @@ docker_kill_wait ${BUILD_TAG}-trxcon docker_kill_wait ${BUILD_TAG}-fake_trx - docker_kill_wait ${BUILD_TAG}-bts + stop_bts } # Frequency hopping tests require different configuration files @@ -276,7 +287,7 @@ docker_kill_wait ${BUILD_TAG}-trxcon docker_kill_wait ${BUILD_TAG}-fake_trx docker_kill_wait ${BUILD_TAG}-bsc - docker_kill_wait ${BUILD_TAG}-bts + stop_bts } check_respawn_count() { -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/42194?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Id9a93f7149ef7e9bfde1f4fe3a8299ba46645d50 Gerrit-Change-Number: 42194 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in docker-playground[master]: ttcn3-bts-test: write bts logs to tmpfs
by osmith 25 Feb '26

25 Feb '26

Attention is currently required from: pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/docker-playground/+/42194?usp=email ) Change subject: ttcn3-bts-test: write bts logs to tmpfs ...................................................................... Patch Set 1: (1 comment) File ttcn3-bts-test/jenkins.sh: https://gerrit.osmocom.org/c/docker-playground/+/42194/comment/72f43c85_19f… : PS1, Line 117: docker exec "${BUILD_TAG}-bts" sh -c "cat /tmp/osmo-bts.log >> /data/osmo-bts.log" > No, because `start_bts` and `stop_bts` run multiple times and append to the same log file each time. […] Done -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/42194?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Id9a93f7149ef7e9bfde1f4fe3a8299ba46645d50 Gerrit-Change-Number: 42194 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Feb 2026 07:37:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in docker-playground[master]: ttcn3-bts-test: write bts logs to tmpfs
by fixeria 25 Feb '26

25 Feb '26

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/docker-playground/+/42194?usp=email ) Change subject: ttcn3-bts-test: write bts logs to tmpfs ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/42194?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Id9a93f7149ef7e9bfde1f4fe3a8299ba46645d50 Gerrit-Change-Number: 42194 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Feb 2026 07:34:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log