- gerrit-log - lists.osmocom.org

[S] Change in osmo-asf4-dfu[master]: dfu: MANIFEST_SYNC: stay in MANIFEST_SYNC when manifestationIntoleran...
by laforge 25 Feb '26

25 Feb '26

Attention is currently required from: Hoernchen, lynxis lazus, pespin. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42175?usp=email ) Change subject: dfu: MANIFEST_SYNC: stay in MANIFEST_SYNC when manifestationIntolerant & completed ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: likewise here, if I'm adding the subject matter expert @ewild@sysmocom.de as a reviwere, than that is a work assingment to review the patch and provide feedback. Removing oneself from the list of reviwers is basically refusing a work assignment. Keep in mind, we're talking about paid work here, not loose collaboration in an open source project in our spare time... -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42175?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I8c34a18e2336731126a8c01070d86e2547578e3d Gerrit-Change-Number: 42175 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 25 Feb 2026 11:25:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-asf4-dfu[master]: dfu: rewrite firmware downloading
by laforge 25 Feb '26

25 Feb '26

Attention is currently required from: Hoernchen, lynxis lazus, pespin. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174?usp=email ) Change subject: dfu: rewrite firmware downloading ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: I would really want to hear feedback from @ewild@sysmocom.de on this one. Do we consider this patch an improvement, or is it just "lateral change" in parts of criticial code that do not have a provable issue to be resolved? -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I345d5948455b25cd8a2efb1abfd9d0986ebd8cef Gerrit-Change-Number: 42174 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 25 Feb 2026 11:23:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-asf4-dfu[master]: dfu: usb_dfu() convert if() intos switch/case
by laforge 25 Feb '26

25 Feb '26

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42173?usp=email ) Change subject: dfu: usb_dfu() convert if() intos switch/case ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42173?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: Ie0abcdb51612598e77cacf7772276919ded17d5a Gerrit-Change-Number: 42173 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 25 Feb 2026 11:21:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-asf4-dfu[master]: dfu: irq: replace if(states) with a switch case
by laforge 25 Feb '26

25 Feb '26

Attention is currently required from: Hoernchen, lynxis lazus, pespin. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42171?usp=email ) Change subject: dfu: irq: replace if(states) with a switch case ...................................................................... Patch Set 4: Code-Review+2 (1 comment) Patchset: PS2: > This pointlessly churns code to muddy the blame without improving anything.. Nobody is blaming anyone for the way how the code it, at least not that I have seen/heard about it. I think the switch statement is a readability improvement - but it's of course what I'd call "sideways development" as it doesn't really appear to move us forward. Since the patch was written, and it is a miniscule improvmeent, we can merge it to avoid holding back the series. -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42171?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: Ic32fe16dff4b7bb933ec62e36a9c7c7829aece1b Gerrit-Change-Number: 42171 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 25 Feb 2026 11:20:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de>

1 0

[XS] Change in osmo-asf4-dfu[master]: dfu: mainloop: work on a local copy of dfu_state
by laforge 25 Feb '26

25 Feb '26

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42170?usp=email ) Change subject: dfu: mainloop: work on a local copy of dfu_state ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Patchset: PS4: ok, so I think we agree this is not neccessary after all? Given that all loads/stores are atomic, and we are not performing incrment/decrement or the like (requiring atomicity of a read-modify-write)? -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42170?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: Ic146c8fa5ba25425cf785bae66f9c99b0faab944 Gerrit-Change-Number: 42170 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 25 Feb 2026 11:18:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-asf4-dfu[master]: dfu: make dfu_state/dfu_status volatile
by laforge 25 Feb '26

25 Feb '26

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42169?usp=email ) Change subject: dfu: make dfu_state/dfu_status volatile ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Patchset: PS3: I think @ewild@sysmocom.de stated it's technically not neccessary but removed his review later? In any case, it can't hurt either. -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42169?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I7ad5255064917c203cebe5ab54a5d457baa2f5ed Gerrit-Change-Number: 42169 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 25 Feb 2026 11:17:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-remsim[master]: bankd: csv: fix crash on invalid lines
by pespin 25 Feb '26

25 Feb '26

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42200?usp=email ) Change subject: bankd: csv: fix crash on invalid lines ...................................................................... Patch Set 1: (1 comment) File src/bankd/bankd_pcsc.c: https://gerrit.osmocom.org/c/osmo-remsim/+/42200/comment/68add67b_4fa512a2?… : PS1, Line 105: LOGP(DMAIN, LOGL_ERROR, "B%d:%d: No reader name given. Maybe invalid csv.\n", > Yes, but the logging is still a good topic to change things. […] Sure, np, just giving the idea. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42200?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Id6059c7dd4a119ffb1658a6cd7345a40bef3a69f Gerrit-Change-Number: 42200 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 25 Feb 2026 11:02:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: bsc: TC_stat_msc_sctp_disconnected Fix sporadic failure
by osmith 25 Feb '26

25 Feb '26

Attention is currently required from: fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42202?usp=email ) Change subject: bsc: TC_stat_msc_sctp_disconnected Fix sporadic failure ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42202?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib063a481d9039cbcd462609404dbae14922c7510 Gerrit-Change-Number: 42202 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Feb 2026 11:01:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: bsc: TC_stat_msc_sctp_disconnected Fix sporadic failure
by pespin 25 Feb '26

25 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42202?usp=email ) Change subject: bsc: TC_stat_msc_sctp_disconnected Fix sporadic failure ...................................................................... bsc: TC_stat_msc_sctp_disconnected Fix sporadic failure Since we recently increased a bit the timeout to assume the BSSAP_LE peer (SMLC) is implicitly up, the function f_bssap_le_wait_sccp_peer_available() may still be onging when we drop the sctp connection at the STP in the test, which will generate an explicit DUNA towards BSSAP_LE and hence fail the test because it never comes back available before it times out. Since we don't need nor test SMLC in this test, simply disable starting the SMLC here to avoid this race condition and simplify the test. Change-Id: Ib063a481d9039cbcd462609404dbae14922c7510 --- M bsc/BSC_Tests.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/02/42202/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index a9d063d..ef02faf 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -3269,7 +3269,7 @@ var MSC_ConnHdlr vc_conn; var integer exp_total_num_msc; - f_init(nr_bts := 1, handler_mode := true, nr_msc := 1); + f_init(nr_bts := 1, handler_mode := true, nr_msc := 1, enable_smlc := false); if (mp_bssap_cfg[0].transport == BSSAP_TRANSPORT_AoIP) { exp_total_num_msc := NUM_MSC; f_init_vty_stp(); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42202?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib063a481d9039cbcd462609404dbae14922c7510 Gerrit-Change-Number: 42202 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-remsim[master]: bankd: csv: fix crash on invalid lines
by lynxis lazus 25 Feb '26

25 Feb '26

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42200?usp=email ) Change subject: bankd: csv: fix crash on invalid lines ...................................................................... Patch Set 1: (1 comment) File src/bankd/bankd_pcsc.c: https://gerrit.osmocom.org/c/osmo-remsim/+/42200/comment/a4d1e5df_a00b15ba?… : PS1, Line 105: LOGP(DMAIN, LOGL_ERROR, "B%d:%d: No reader name given. Maybe invalid csv.\n", > looks ike we want to add a LOG define for sn here :) Yes, but the logging is still a good topic to change things.I would like to do the topic in a different commit, because it is a general problem and this fixes a crash here. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42200?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Id6059c7dd4a119ffb1658a6cd7345a40bef3a69f Gerrit-Change-Number: 42200 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Feb 2026 10:57:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log