- gerrit-log - lists.osmocom.org

[S] Change in osmo-hnbgw[master]: context_map_sccp: Drop unused MAP_SCCP_EV_CN_LINK_LOST

by pespin

Attention is currently required from: laforge, neels. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40175?usp=email ) Change subject: context_map_sccp: Drop unused MAP_SCCP_EV_CN_LINK_LOST ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-hnbgw/+/40175/comment/331acdbc_495d31c8?u… : PS2, Line 9: This event is never called. Furthermore, this kind of "SCCP link went : down" should already be handled by libosmo-sigtran's sccp SAP : internally, and we should simply recieve an N-DISCONNECT.ind when that : happens which dispatches event MAP_SCCP_EV_RX_RELEASED. > There seems to be a mixup of events when receiving an SCCP N-PCSTATE. […] This looks like a bug introduced in osmo-hnbgw.git b1c0bb19e2bfbc48e05a89a5f09b476d1243b5f3, the commit where MAP_SCCP_EV_CN_LINK_LOST was introduced but never dispatched anywhere. Looks like there was probably a copy-paste issue in there. I'll continue investigating and submit a new patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40175?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I3a37522da16d9a06764f58c2da9579b397d8a7f2 Gerrit-Change-Number: 40175 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 30 Apr 2025 12:23:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

2 months, 1 week

1
0
0 0

[S] Change in osmo-hnbgw[master]: context_map_sccp: Drop unused MAP_SCCP_EV_CN_LINK_LOST

by pespin

Attention is currently required from: laforge, neels. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40175?usp=email ) Change subject: context_map_sccp: Drop unused MAP_SCCP_EV_CN_LINK_LOST ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-hnbgw/+/40175/comment/b88887b8_948e2e6d?u… : PS2, Line 9: This event is never called. Furthermore, this kind of "SCCP link went : down" should already be handled by libosmo-sigtran's sccp SAP : internally, and we should simply recieve an N-DISCONNECT.ind when that : happens which dispatches event MAP_SCCP_EV_RX_RELEASED. > This is a related ticket which I recalled existed but was unable to find yesterday: https://osmocom. […] There seems to be a mixup of events when receiving an SCCP N-PCSTATE.ind handle_pcstate_ind in(), which ends up calling: cnlink_set_disconnected() cnlink_fsm_state_chg(cnlink->fi, CNLINK_ST_DISC) cnlink_disc_onenter() link_lost() context_map_cnlink_lost() map_sccp_dispatch(map, MAP_SCCP_EV_RAN_LINK_LOST, NULL) See how context_map_cnlink_lost() is sending event MAP_SCCP_EV_RAN_LINK_LOST, but that should actually be MAP_SCCP_EV_CN_LINK_LOST afaiu... -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40175?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I3a37522da16d9a06764f58c2da9579b397d8a7f2 Gerrit-Change-Number: 40175 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 30 Apr 2025 12:20:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

2 months, 1 week

1
0
0 0

[S] Change in osmo-hnbgw[master]: context_map_sccp: Drop unused MAP_SCCP_EV_CN_LINK_LOST

by pespin

Attention is currently required from: laforge, neels. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40175?usp=email ) Change subject: context_map_sccp: Drop unused MAP_SCCP_EV_CN_LINK_LOST ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-hnbgw/+/40175/comment/c378fc09_eeec3687?u… : PS2, Line 9: This event is never called. Furthermore, this kind of "SCCP link went : down" should already be handled by libosmo-sigtran's sccp SAP : internally, and we should simply recieve an N-DISCONNECT.ind when that : happens which dispatches event MAP_SCCP_EV_RX_RELEASED. > N-DISCONNECT.ind is the termination of a sinle SCCP connection. […] This is a related ticket which I recalled existed but was unable to find yesterday: https://osmocom.org/issues/5917 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40175?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I3a37522da16d9a06764f58c2da9579b397d8a7f2 Gerrit-Change-Number: 40175 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 30 Apr 2025 12:08:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

2 months, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: tarballs: add pyosmocom, libosmo-gprs

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/40177?usp=email ) Change subject: tarballs: add pyosmocom, libosmo-gprs ...................................................................... tarballs: add pyosmocom, libosmo-gprs Fixes: OS#6786, OS#6785 Change-Id: I7eaf8d4091d6261a7e526148075c4a87f9de49b7 --- M scripts/tarballs/publish-tarballs-for-tags.sh 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/77/40177/1 diff --git a/scripts/tarballs/publish-tarballs-for-tags.sh b/scripts/tarballs/publish-tarballs-for-tags.sh index 7f8c6d3..442c00f 100755 --- a/scripts/tarballs/publish-tarballs-for-tags.sh +++ b/scripts/tarballs/publish-tarballs-for-tags.sh @@ -13,6 +13,7 @@ libgtpnl libosmo-abis libosmo-dsp + libosmo-gprs libosmo-netif libosmo-pfcp libosmo-sccp-legacy @@ -49,6 +50,7 @@ osmo-upf osmo_dia2gsup osmocom-bb + pyosmocom rtl-sdr simtrace2 strongswan-epdg -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40177?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7eaf8d4091d6261a7e526148075c4a87f9de49b7 Gerrit-Change-Number: 40177 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

2 months, 1 week

1
0
0 0

[S] Change in osmo-ci[master]: jobs/ttcn3-testsuites: display load at start/end

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/40167?usp=email ) Change subject: jobs/ttcn3-testsuites: display load at start/end ...................................................................... jobs/ttcn3-testsuites: display load at start/end Display the load average line from uptime at the start and end of testsuite runs, e.g.: load average: 0.77, 0.68, 0.68 Change-Id: I5f891ae5d9b501e2e111e61d3aaa55ae24cb663b --- M jobs/ttcn3-testsuites-testenv.yml M jobs/ttcn3-testsuites.yml 2 files changed, 20 insertions(+), 3 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/jobs/ttcn3-testsuites-testenv.yml b/jobs/ttcn3-testsuites-testenv.yml index f6a7798..ac1b00e 100644 --- a/jobs/ttcn3-testsuites-testenv.yml +++ b/jobs/ttcn3-testsuites-testenv.yml @@ -533,18 +533,26 @@ export TESTENV_COREDUMP_FROM_LXC_HOST=1 set -x - ./testenv.py run \ + uptime | grep --color=always -o "load.*" + + RC=0 + if ! ./testenv.py run \ {testsuite} \ --podman \ --cache "$PWD"/_cache \ --ccache ~/ccache/testenv \ --log-dir "$PWD"/logs \ - {args} + {args}; then + RC=1 + fi # Free up space from downloaded apt packages, build artifacts etc. # The osmo-ttcn3-hacks deps dir and ccache are persistent. rm -rf _cache .linux + uptime | grep --color=always -o "load.*" + exit $RC + scm: - git: branches: diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index d842fff..6d76961 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -165,7 +165,16 @@ esac cd "$DIR" - ./jenkins.sh + + uptime | grep --color=always -o "load.*" + + RC=0 + if ! ./jenkins.sh; then + RC=1 + fi + + uptime | grep --color=always -o "load.*" + exit $RC scm: - git: branches: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40167?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5f891ae5d9b501e2e111e61d3aaa55ae24cb663b Gerrit-Change-Number: 40167 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 months, 1 week

1
0
0 0

[S] Change in osmo-hnbgw[master]: context_map_sccp: Drop unused MAP_SCCP_EV_CN_LINK_LOST

by laforge

Attention is currently required from: neels, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40175?usp=email ) Change subject: context_map_sccp: Drop unused MAP_SCCP_EV_CN_LINK_LOST ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-hnbgw/+/40175/comment/1d0269e2_e5bc4c17?u… : PS2, Line 9: This event is never called. Furthermore, this kind of "SCCP link went : down" should already be handled by libosmo-sigtran's sccp SAP : internally, and we should simply recieve an N-DISCONNECT.ind when that : happens which dispatches event MAP_SCCP_EV_RX_RELEASED. N-DISCONNECT.ind is the termination of a sinle SCCP connection. The "CN link" is one abstraction level higher. As the comment suggests, that FSM event should be generated upon incoming RANAP RESET. To me it seems more like this code should not be removed, and in fact the bug is that the event is not generated b RANAP RESET as the code suggests? -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40175?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I3a37522da16d9a06764f58c2da9579b397d8a7f2 Gerrit-Change-Number: 40175 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 29 Apr 2025 19:38:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

2 months, 1 week

1
0
0 0

[S] Change in osmo-hnbgw[master]: cosmetic: context_map.h: Document parameters of all map_sccp_fsm_even...

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40174?usp=email ) Change subject: cosmetic: context_map.h: Document parameters of all map_sccp_fsm_event values ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40174?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I53603ade5157ddbccb49864a2edab09376fe8979 Gerrit-Change-Number: 40174 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 29 Apr 2025 19:36:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months, 1 week

1
0
0 0

[XS] Change in osmo-gsm-manuals[master]: bibliography: Add ETS TS 102 671 (MFF2)

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/40173?usp=email ) Change subject: bibliography: Add ETS TS 102 671 (MFF2) ...................................................................... bibliography: Add ETS TS 102 671 (MFF2) This adds a reference to the SIM/UICC form-factor MFF2 Change-Id: I500276c01d79a549601773b6baed39e4cdf76252 --- M common/chapters/bibliography.adoc 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/common/chapters/bibliography.adoc b/common/chapters/bibliography.adoc index bebad30..385c094 100644 --- a/common/chapters/bibliography.adoc +++ b/common/chapters/bibliography.adoc @@ -169,6 +169,9 @@ - [[[etsi-ts101220]]] ETSI TS 101 220: Smart Cards; ETSI numbering system for telecommunication application providers https://www.etsi.org/deliver/etsi_ts/101200_101299/101220/12.00.00_60/ts_10… +- [[[etsi-ts102671]]] ETSI TS 102 671: Smart Cards; Machine to Machine UICC; + Physical and logical characteristics + https://www.etsi.org/deliver/etsi_ts/102600_102699/102671/18.01.00_60/ts_10… - [[[ieee-802.1q]]] IEEE 802.1Q: Bridges and Bridged Networks https://ieeexplore.ieee.org/document/6991462 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/40173?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I500276c01d79a549601773b6baed39e4cdf76252 Gerrit-Change-Number: 40173 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

2 months, 1 week

1
0
0 0

[XS] Change in osmo-gsm-manuals[master]: bibliography: Add ETS TS 102 671 (MFF2)

by laforge

laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/40173?usp=email ) Change subject: bibliography: Add ETS TS 102 671 (MFF2) ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/40173?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I500276c01d79a549601773b6baed39e4cdf76252 Gerrit-Change-Number: 40173 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 29 Apr 2025 19:35:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months, 1 week

1
0
0 0

[S] Change in osmo-hnbgw[master]: cosmetic: context_map.h: Document parameters of all map_sccp_fsm_even...

by pespin

pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40174?usp=email ) Change subject: cosmetic: context_map.h: Document parameters of all map_sccp_fsm_event values ...................................................................... cosmetic: context_map.h: Document parameters of all map_sccp_fsm_event values Change-Id: I53603ade5157ddbccb49864a2edab09376fe8979 --- M include/osmocom/hnbgw/context_map.h 1 file changed, 12 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/74/40174/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40174?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I53603ade5157ddbccb49864a2edab09376fe8979 Gerrit-Change-Number: 40174 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder

2 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log