- gerrit-log - lists.osmocom.org

[L] Change in osmo-trx[master]: feat(usdr): add USDR backend support (osmo-trx-usdr)
by osmith 25 Feb '26

25 Feb '26

Attention is currently required from: Timur Davydov. osmith has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42198?usp=email ) Change subject: feat(usdr): add USDR backend support (osmo-trx-usdr) ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > given the many formatting issues with code completely incompliant to our coding style, I'm actually […] It has been disabled for all header files in osmo-trx: https://gerrit.osmocom.org/c/osmo-trx/+/30436 The linter complained e.g. about trailing whitespaces in .cpp files in an earlier revision of this patchset: https://jenkins.osmocom.org/jenkins/job/gerrit-lint/27101/consoleFull -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5d1d25921514954c4929ae6e7352168b3ceb05df Gerrit-Change-Number: 42198 Gerrit-PatchSet: 3 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Wed, 25 Feb 2026 12:46:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[L] Change in osmo-trx[master]: feat(usdr): add USDR backend support (osmo-trx-usdr)
by laforge 25 Feb '26

25 Feb '26

Attention is currently required from: Timur Davydov. laforge has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42198?usp=email ) Change subject: feat(usdr): add USDR backend support (osmo-trx-usdr) ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: given the many formatting issues with code completely incompliant to our coding style, I'm actually surprised our linter doesn't catch any of them? @osmith@sysmocom.de ? -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5d1d25921514954c4929ae6e7352168b3ceb05df Gerrit-Change-Number: 42198 Gerrit-PatchSet: 3 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Wed, 25 Feb 2026 12:38:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in pysim[master]: tests/pySim-smpp2sim_test: add testcases for AES128 and AES256
by dexter 25 Feb '26

25 Feb '26

Attention is currently required from: laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42189?usp=email ) Change subject: tests/pySim-smpp2sim_test: add testcases for AES128 and AES256 ...................................................................... Patch Set 4: (1 comment) File tests/card_sanitizer/card_backup_3b9f96801f878031e073fe211b674a357530350265f8_8949440000001155314.script: https://gerrit.osmocom.org/c/pysim/+/42189/comment/1f866ebf_bd1dcd34?usp=em… : PS4, Line 2205: update_record 12 fe03623333333333333333333333333333333333333333333333333333333333333333 This was a bit subtle - no wonder that this patch failed the tests after some time. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42189?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1f10504f3a29a8c74a17991632d932819fecfa5a Gerrit-Change-Number: 42189 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 25 Feb 2026 11:45:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-asf4-dfu[master]: dfu: make dfu_state/dfu_status volatile
by lynxis lazus 25 Feb '26

25 Feb '26

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42169?usp=email ) Change subject: dfu: make dfu_state/dfu_status volatile ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > I think @ewild@sysmocom. […] So far I understood that was for the following commit. -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42169?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I7ad5255064917c203cebe5ab54a5d457baa2f5ed Gerrit-Change-Number: 42169 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Feb 2026 11:32:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-remsim[master]: bankd: csv: fail on invalid csv lines
by laforge 25 Feb '26

25 Feb '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42201?usp=email ) Change subject: bankd: csv: fail on invalid csv lines ...................................................................... bankd: csv: fail on invalid csv lines Instead of ignoring invalid regex and non-existent regex for reader. Change-Id: If10889b43c99adb99d0b7dcdb4287952c3a93d69 --- M src/bankd/bankd_pcsc.c 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/bankd/bankd_pcsc.c b/src/bankd/bankd_pcsc.c index 1804d01..1eb7dba 100644 --- a/src/bankd/bankd_pcsc.c +++ b/src/bankd/bankd_pcsc.c @@ -55,6 +55,7 @@ struct bankd *bankd; enum parser_state_name state; struct pcsc_slot_name *cur; + bool invalid_csv; }; @@ -62,6 +63,7 @@ { ps->state = ST_BANK_NR; ps->cur = NULL; + ps->invalid_csv = false; } static void cb1(void *s, size_t len, void *data) @@ -104,6 +106,7 @@ if (!sn->name_regex) { LOGP(DMAIN, LOGL_ERROR, "B%d:%d: No reader name given. Maybe invalid csv.\n", sn->slot.bank_id, sn->slot.slot_nr); + ps->invalid_csv = true; talloc_free(sn); goto out; } @@ -113,8 +116,9 @@ rc = regcomp(&compiled_name, sn->name_regex, REG_EXTENDED); if (rc != 0) { char *errmsg = get_regerror(sn, rc, &compiled_name); - LOGP(DMAIN, LOGL_ERROR, "B%d:%d: Error compiling regex '%s': %s - Ignoring\n", + LOGP(DMAIN, LOGL_ERROR, "B%d:%d: Error compiling regex '%s': %s\n", sn->slot.bank_id, sn->slot.slot_nr, sn->name_regex, errmsg); + ps->invalid_csv = true; talloc_free(errmsg); talloc_free(sn); } else { @@ -162,6 +166,11 @@ fclose(fp); csv_free(&p); + if (ps.invalid_csv) { + LOGP(DMAIN, LOGL_FATAL, "Error parsing bankd PC/SC CSV.\n"); + return -1; + } + return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42201?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: If10889b43c99adb99d0b7dcdb4287952c3a93d69 Gerrit-Change-Number: 42201 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-remsim[master]: bankd: csv: fix crash on invalid lines
by laforge 25 Feb '26

25 Feb '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42200?usp=email ) Change subject: bankd: csv: fix crash on invalid lines ...................................................................... bankd: csv: fix crash on invalid lines When no valid csv line is given (e.g. without any commas), bankd will crash when trying to compile a regex with NULL. Change-Id: Id6059c7dd4a119ffb1658a6cd7345a40bef3a69f --- M src/bankd/bankd_pcsc.c 1 file changed, 10 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/bankd/bankd_pcsc.c b/src/bankd/bankd_pcsc.c index f9651f3..1804d01 100644 --- a/src/bankd/bankd_pcsc.c +++ b/src/bankd/bankd_pcsc.c @@ -101,13 +101,20 @@ LOGP(DMAIN, LOGL_INFO, "PC/SC slot name: %u/%u -> regex '%s'\n", sn->slot.bank_id, sn->slot.slot_nr, sn->name_regex); + if (!sn->name_regex) { + LOGP(DMAIN, LOGL_ERROR, "B%d:%d: No reader name given. Maybe invalid csv.\n", + sn->slot.bank_id, sn->slot.slot_nr); + talloc_free(sn); + goto out; + } + memset(&compiled_name, 0, sizeof(compiled_name)); rc = regcomp(&compiled_name, sn->name_regex, REG_EXTENDED); if (rc != 0) { char *errmsg = get_regerror(sn, rc, &compiled_name); - LOGP(DMAIN, LOGL_ERROR, "Error compiling regex '%s': %s - Ignoring\n", - sn->name_regex, errmsg); + LOGP(DMAIN, LOGL_ERROR, "B%d:%d: Error compiling regex '%s': %s - Ignoring\n", + sn->slot.bank_id, sn->slot.slot_nr, sn->name_regex, errmsg); talloc_free(errmsg); talloc_free(sn); } else { @@ -115,6 +122,7 @@ } regfree(&compiled_name); +out: ps->state = ST_BANK_NR; ps->cur = NULL; } -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42200?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Id6059c7dd4a119ffb1658a6cd7345a40bef3a69f Gerrit-Change-Number: 42200 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-remsim[master]: bankd: csv: fail on invalid csv lines
by laforge 25 Feb '26

25 Feb '26

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42201?usp=email ) Change subject: bankd: csv: fail on invalid csv lines ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42201?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: If10889b43c99adb99d0b7dcdb4287952c3a93d69 Gerrit-Change-Number: 42201 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 25 Feb 2026 11:32:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-remsim[master]: bankd: csv: fix crash on invalid lines
by laforge 25 Feb '26

25 Feb '26

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42200?usp=email ) Change subject: bankd: csv: fix crash on invalid lines ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42200?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Id6059c7dd4a119ffb1658a6cd7345a40bef3a69f Gerrit-Change-Number: 42200 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 25 Feb 2026 11:31:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-asf4-dfu[master]: dfu: mainloop: work on a local copy of dfu_state
by lynxis lazus 25 Feb '26

25 Feb '26

Attention is currently required from: laforge. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42170?usp=email ) Change subject: dfu: mainloop: work on a local copy of dfu_state ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > ok, so I think we agree this is not neccessary after all? Given that all loads/stores are atomic, a […] AFAIU: Pau asked if this assignment itself is atomic (last_dfu_state = dfu_state) and if not would need a CRITICAL section, where we agreed, the assignment itself is atomic. About this assignment, I want to make sure the mainloop would loop over and only does one thing based based on the dfu_state. Trying to keep the code path simple and keep away from side effects. Otherwise a loop run could run through different states and does multiple things -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42170?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: Ic146c8fa5ba25425cf785bae66f9c99b0faab944 Gerrit-Change-Number: 42170 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 25 Feb 2026 11:30:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-asf4-dfu[master]: dfu: protect USB_DFU_STATE_DFU_MANIFEST by a critical section
by laforge 25 Feb '26

25 Feb '26

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42176?usp=email ) Change subject: dfu: protect USB_DFU_STATE_DFU_MANIFEST by a critical section ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Patchset: PS2: > The ISR only reads these variables when dfu_state == DFU_MANIFEST_SYNC, the main loop only writes th […] Thanks for providing context. Do we agree it's still good practice to put it in a critical section? To prevent someone in the future shooting themselves into the foot? It's not like the very brief disabling of interrupts (critical section) for the duration of one load and two stores is going to introduce additional risks in something that doens't strike me as hyper-critical code path? -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42176?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: Idf5fb7d55b4051ba7e235dfa409a4de18a8f208c Gerrit-Change-Number: 42176 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 25 Feb 2026 11:27:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log