Attention is currently required from: neels, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40175?usp=email ) Change subject: context_map_sccp: Drop unused MAP_SCCP_EV_CN_LINK_LOST ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-hnbgw/+/40175/comment/1d0269e2_e5bc4c17?us... : PS2, Line 9: This event is never called. Furthermore, this kind of "SCCP link went : down" should already be handled by libosmo-sigtran's sccp SAP : internally, and we should simply recieve an N-DISCONNECT.ind when that : happens which dispatches event MAP_SCCP_EV_RX_RELEASED. N-DISCONNECT.ind is the termination of a sinle SCCP connection. The "CN link" is one abstraction level higher. As the comment suggests, that FSM event should be generated upon incoming RANAP RESET. To me it seems more like this code should not be removed, and in fact the bug is that the event is not generated b RANAP RESET as the code suggests? -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40175?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I3a37522da16d9a06764f58c2da9579b397d8a7f2 Gerrit-Change-Number: 40175 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Tue, 29 Apr 2025 19:38:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No