lynxis lazus has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42172?usp=email )
Change subject: dfu: irq: GET_STATUS: set state before sending it
......................................................................
Abandoned
Superseeded by https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42178
--
To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42172?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: abandon
Gerrit-Project: osmo-asf4-dfu
Gerrit-Branch: master
Gerrit-Change-Id: I6d28404d6936f7ea79fcee90f0c8191f0f623ad8
Gerrit-Change-Number: 42172
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42200?usp=email )
Change subject: bankd: csv: fix crash on invalid lines
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/bankd/bankd_pcsc.c:
https://gerrit.osmocom.org/c/osmo-remsim/+/42200/comment/bac1708b_3c049777?… :
PS1, Line 105: LOGP(DMAIN, LOGL_ERROR, "B%d:%d: No reader name given. Maybe invalid csv.\n",
looks ike we want to add a LOG define for sn here :)
--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42200?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: Id6059c7dd4a119ffb1658a6cd7345a40bef3a69f
Gerrit-Change-Number: 42200
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 25 Feb 2026 10:38:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: dexter, laforge.
Hello Jenkins Builder, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/pysim/+/42189?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Verified-1 by Jenkins Builder
Change subject: tests/pySim-smpp2sim_test: add testcases for AES128 and AES256
......................................................................
tests/pySim-smpp2sim_test: add testcases for AES128 and AES256
Extend the existing test script so that it can handle multiple
testcases. Also add support for switching eUICC profiles.
Finally, add a testcases to test OTA-SMS (RFM) with AES128 and
AES256 encryption.
Change-Id: I1f10504f3a29a8c74a17991632d932819fecfa5a
Related: OS#6868
---
M tests/card_sanitizer/card_backup_3b9f96801f878031e073fe211b674a357530350265f8_8949440000001155314.script
D tests/pySim-smpp2sim_test/pySim-smpp2sim_test.cfg
M tests/pySim-smpp2sim_test/pySim-smpp2sim_test.sh
A tests/pySim-smpp2sim_test/testcase_3des_cbc2_rfm.cfg
A tests/pySim-smpp2sim_test/testcase_aes128_cbc_cmac_rfm.cfg
A tests/pySim-smpp2sim_test/testcase_aes256_cbc_cmac_rfm.cfg
6 files changed, 164 insertions(+), 49 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/89/42189/4
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42189?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I1f10504f3a29a8c74a17991632d932819fecfa5a
Gerrit-Change-Number: 42189
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: Timur Davydov.
pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42198?usp=email )
Change subject: feat(usdr): add USDR backend support (osmo-trx-usdr)
......................................................................
Patch Set 3: Code-Review-1
(16 comments)
Patchset:
PS3:
This was not a full review, I will review USDRDevice.cpp/.h again once you fix all the formatting there.
File Transceiver52M/device/usdr/USDRDevice.h:
https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/af0bce02_b674c263?usp… :
PS3, Line 54: int txsps; ///< samples count per GSM symbol for Tx
unsigned?
We actually have "size_t tx_sps, rx_sps;" in RadioDevice, why not reusing them?
https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/8b925d17_1efc289a?usp… :
PS3, Line 60: int timeTxCorr = 0; ///< time correction for TX timestamp, in samples, to align it with RX timestamp, which is needed to achieve correct timing of the transmitted signal. This is a device-specific parameter that can be configured via dev_args and defaults to 0 if not specified.
Change all these comments using /* */ and properly split into acceptable width (<=120 chars).
https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/20940c5f_f75af47f?usp… :
PS3, Line 63: TIMESTAMP ts_last_recv = 0;
wrong indentation
https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/12705b92_a891e300?usp… :
PS3, Line 90: Read samples from the USDR.
syntax for comment (at least indentation) is different here and in next block.
We usually tend to have "* yourtexthere" at the start of each comment line.
https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/4574676b_9f77251b?usp… :
PS3, Line 100: TIMESTAMP timestamp = 0xffffffff, bool *underrun = NULL);
wrong indentation here and below.
https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/abf0fde4_f08d4af3?usp… :
PS3, Line 121:
Pleasr get rid of trailing whitespace.
https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/460c17d8_fb1f28b7?usp… :
PS3, Line 132: TIMESTAMP initialReadTimestamp(void) { return ts_initial;}
Please, fix indentation in the whole file.
File Transceiver52M/device/usdr/USDRDevice.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/3ce342ee_589c89f5?usp… :
PS3, Line 49: {"limemini", {tx_offset: 86.769us}}, /* 94 samples at 1083333.33333 sps corresponds to 86.769 us */
are you sure this is correct? isn't it xsdr? maybe add an extra commit explaining?
https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/5d746f23_0af4c7af?usp… :
PS3, Line 52: enum {
I don't see why this should be an enum.
Looks more like 2 defines or 2 const unsigned int.
https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/6f8ee7e3_0dd68be8?usp… :
PS3, Line 85: std::string msg = std::string("Error creating USDR device with connection string '") + connection_string + "' res: " + std::to_string(res) + "(" + strerror(res) + ")";
Fix all lines too long like this. Maximum is 120 chars.
https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/b6291fd4_84385229?usp… :
PS3, Line 180: dev = NULL;
Please fix indentation in the whole file. Better use tabs everywhere.
File debian/osmo-trx-usdr.postinst:
https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/165e1499_770932f1?usp… :
PS3, Line 18: # Fix permissions of previous (root-owned) install (OS#4107)
This is AFAICT not needed here, because there's no previous root-owned install ;)
File doc/manuals/chapters/trx-backends.adoc:
https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/fad6a46c_77479109?usp… :
PS3, Line 85: The backend supports single-channel SDR hardware and is designed for setups
But in the other .adoc (devices) you say xSDR supports multiple channels? Is this simply not implemented yet in osmo-trx?
https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/6486201c_860cc643?usp… :
PS3, Line 86: where multiple small SDRs are combined to present one or more TRX instances
You mean using multiple SDR devices controlled by one osmo-trx-usdr process?
Or multiple SDR devices with multiple osmo-trx-usdr processes each controlling 1 device?
The later is not supported and I can foresee clock sync issues. The former is not supported at least for other backends, dunno for USDR yet (still reviewing).
File doc/manuals/chapters/trx-devices.adoc:
https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/08cb6d24_d39ad6ef?usp… :
PS3, Line 102: scale the number of TRX instances.
I'd welcome some extra documentation here regarding how "multi-unit setups to
scale the number of TRX instances." is accomplished, or at least some link to somewhere explaining it.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42198?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I5d1d25921514954c4929ae6e7352168b3ceb05df
Gerrit-Change-Number: 42198
Gerrit-PatchSet: 3
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Comment-Date: Wed, 25 Feb 2026 10:10:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Timur Davydov.
pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42199?usp=email )
Change subject: fix(threads): support GNU and POSIX strerror_r variants
......................................................................
Patch Set 1:
(2 comments)
File CommonLibs/Threads.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/42199/comment/ab541672_61255e05?usp… :
PS1, Line 58: char *err_str = NULL;
wrong indentation
https://gerrit.osmocom.org/c/osmo-trx/+/42199/comment/e2b5f56f_7e2ee524?usp… :
PS1, Line 59: #if defined(__GLIBC__) && defined(_GNU_SOURCE)
Can we move all this into a helper function above so it can be reused?
char *strerror_buf(int err, char *buf, size_t buf_size)
{
#if defined(__GLIBC__) && defined(_GNU_SOURCE)
char *err_str = NULL;
err_str = strerror_r(err, buf, sizeof(buf));
#else
if (strerror_r(err, buf, sizeof(buf)) == 0) {
err_str = buf;
} else {
snprintf(buf, sizeof(buf), "Unknown error %d", err);
err_str = buf;
}
#endif
return err_str;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42199?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I642aff8a9f98823e117c4debd19384ddf5975039
Gerrit-Change-Number: 42199
Gerrit-PatchSet: 1
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Comment-Date: Wed, 25 Feb 2026 09:45:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No