[M] Change in libosmo-sigtran[master]: ss7_asp_peer: Improvements in ss7_asp_peer_snprintf() - gerrit-log

7 Oct 2026


      Attention is currently required from: fixeria, jolly, osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43753?usp=email )
Change subject: ss7_asp_peer: Improvements in ss7_asp_peer_snprintf()
......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS3:
...
would you mind adding tests showing that this works as expected?
@osmith@sysmocom.de see prepended patches.
File src/ss7_asp_peer.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43753/comment/32f71a66_fc47e1... :
PS3, Line 73: |
...
@osmith@sysmocom.de see prepended patches.
No, becuase it iterates until "< peer->host_cnt - 1", so last one is handled after the loop.
-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43753?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I115951627adb0c6778a9a36159237c3eea130300
Gerrit-Change-Number: 43753
Gerrit-PatchSet: 4
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: jolly andreas@eversberg.eu
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Attention: osmith osmith@sysmocom.de
Gerrit-Attention: jolly andreas@eversberg.eu
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Wed, 07 Oct 2026 10:14:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith osmith@sysmocom.de
Comment-In-Reply-To: pespin pespin@sysmocom.de