- gerrit-log - lists.osmocom.org

[M] Change in pysim[master]: personalization: implement reading back values from a PES
by laforge 23 Feb '26

23 Feb '26

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40198?usp=email ) Change subject: personalization: implement reading back values from a PES ...................................................................... Patch Set 9: (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/40198/comment/e1ec42a7_56d7167a?usp=em… : PS9, Line 54: def file_tuples_content_as_bytes(l: List[Tuple]) -> Optional[bytes]: this is not used anymore now, and should be removed. If any subsequent patches depend on it, those patches should be converted to use the File() class. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I234fc4317f0bdc1a486f0cee4fa432c1dce9b463 Gerrit-Change-Number: 40198 Gerrit-PatchSet: 9 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Feb 2026 17:10:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in pysim[master]: personalization: add param_source.py, add batch.py
by laforge 23 Feb '26

23 Feb '26

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/41845?usp=email ) Change subject: personalization: add param_source.py, add batch.py ...................................................................... Patch Set 4: (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/41845/comment/c6360c68_d9d7d8ef?usp=em… : PS4, Line 20: from typing import List, Tuple, Generator why is it imported here if I don't find any existing or newly-introduced code using it? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41845?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I01ae40a06605eb205bfb409189fcd2b3a128855a Gerrit-Change-Number: 41845 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Feb 2026 17:06:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in pysim[master]: MilenageRotationConstants: set example_input to 3GPP default
by laforge 23 Feb '26

23 Feb '26

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/42123?usp=email ) Change subject: MilenageRotationConstants: set example_input to 3GPP default ...................................................................... Patch Set 2: (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/42123/comment/bfdf1094_cad99d15?usp=em… : PS2, Line 355: this is not a milenage rotation constant? Maybe slipped in by accident? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42123?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I36a9434b2f96d26d710f489d5afce1f0ef05bba1 Gerrit-Change-Number: 42123 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Feb 2026 17:04:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in pysim[master]: tests/pySim-smpp2sim_test: add testcases for AES128 and AES256
by laforge 23 Feb '26

23 Feb '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42189?usp=email ) Change subject: tests/pySim-smpp2sim_test: add testcases for AES128 and AES256 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42189?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1f10504f3a29a8c74a17991632d932819fecfa5a Gerrit-Change-Number: 42189 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Feb 2026 16:57:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: contrib/smpp-ota-tool: fix boolean commandline parameters
by laforge 23 Feb '26

23 Feb '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42188?usp=email ) Change subject: contrib/smpp-ota-tool: fix boolean commandline parameters ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42188?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0652b48d2ea5efbaaf5bc147aa8cef7ab8b0861d Gerrit-Change-Number: 42188 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Feb 2026 16:56:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: contrib/smpp-ota-tool/cosmetic: use lazy formatting for logging
by laforge 23 Feb '26

23 Feb '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42184?usp=email ) Change subject: contrib/smpp-ota-tool/cosmetic: use lazy formatting for logging ...................................................................... contrib/smpp-ota-tool/cosmetic: use lazy formatting for logging Change-Id: I2540472a50b7a49b5a67d088cbdd4a2228eef8f4 Related: OS#6868 --- M contrib/smpp-ota-tool.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/smpp-ota-tool.py b/contrib/smpp-ota-tool.py index f667f84..353f5b5 100755 --- a/contrib/smpp-ota-tool.py +++ b/contrib/smpp-ota-tool.py @@ -141,7 +141,7 @@ tuple containing the last response data and the last status word as byte strings """ - logger.info("C-APDU sending: %s..." % b2h(apdu)) + logger.info("C-APDU sending: %s...", b2h(apdu)) # translate to Secured OTA RFM secured = self.ota_dialect.encode_cmd(self.ota_keyset, self.tar, self.spi, apdu=apdu) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42184?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2540472a50b7a49b5a67d088cbdd4a2228eef8f4 Gerrit-Change-Number: 42184 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: contrib/smpp-ota-tool: use correct kid index
by laforge 23 Feb '26

23 Feb '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42185?usp=email ) Change subject: contrib/smpp-ota-tool: use correct kid index ...................................................................... contrib/smpp-ota-tool: use correct kid index (normally KID index and KIC index should be the same since mixing keys is a concidered as a security violation. However, in this tool we want to allow users to specify different indexes for KIC and KIC so that they can make tests to make sure their cards correctly reject mixed up key indexes) Change-Id: I8847ccc39e4779971187e7877b8902fca7f8bfc1 Related: OS#6868 --- M contrib/smpp-ota-tool.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/contrib/smpp-ota-tool.py b/contrib/smpp-ota-tool.py index 353f5b5..c2e9562 100755 --- a/contrib/smpp-ota-tool.py +++ b/contrib/smpp-ota-tool.py @@ -218,7 +218,7 @@ kic_idx=opts.kic_idx, kic=h2b(opts.kic), algo_auth=opts.algo_auth, - kid_idx=opts.kic_idx, + kid_idx=opts.kid_idx, kid=h2b(opts.kid), cntr=opts.cntr) spi = {'counter' : opts.cntr_req, -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42185?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8847ccc39e4779971187e7877b8902fca7f8bfc1 Gerrit-Change-Number: 42185 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: contrib/smpp-ota-tool: add missing usage helpstrings
by laforge 23 Feb '26

23 Feb '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42187?usp=email ) Change subject: contrib/smpp-ota-tool: add missing usage helpstrings ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42187?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic1521ba11b405f311a30fdb3585ad518375669ae Gerrit-Change-Number: 42187 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Feb 2026 16:56:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: contrib/smpp-ota-tool: warn about mixed up KIC/KIC indexes
by laforge 23 Feb '26

23 Feb '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42186?usp=email ) Change subject: contrib/smpp-ota-tool: warn about mixed up KIC/KIC indexes ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File contrib/smpp-ota-tool.py: https://gerrit.osmocom.org/c/pysim/+/42186/comment/4696b347_1e63106c?usp=em… : PS1, Line 218: differnet spelling: different -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42186?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ieb4e14145baba1c2cb4a237b612b04694940f402 Gerrit-Change-Number: 42186 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Feb 2026 16:55:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: contrib/smpp-ota-tool: use correct kid index
by laforge 23 Feb '26

23 Feb '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42185?usp=email ) Change subject: contrib/smpp-ota-tool: use correct kid index ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42185?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8847ccc39e4779971187e7877b8902fca7f8bfc1 Gerrit-Change-Number: 42185 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Feb 2026 16:53:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log