- gerrit-log - lists.osmocom.org

[XS] Change in pysim[master]: contrib/smpp-ota-tool/cosmetic: use lazy formatting for logging
by laforge 23 Feb '26

23 Feb '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42184?usp=email ) Change subject: contrib/smpp-ota-tool/cosmetic: use lazy formatting for logging ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42184?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2540472a50b7a49b5a67d088cbdd4a2228eef8f4 Gerrit-Change-Number: 42184 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Feb 2026 16:52:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-asf4-dfu[master]: Improve comments on errata 2.6.10
by laforge 23 Feb '26

23 Feb '26

Attention is currently required from: Hoernchen. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42168?usp=email ) Change subject: Improve comments on errata 2.6.10 ...................................................................... Patch Set 1: -Code-Review -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42168?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I3c35f590a4e43d778e70f2f377e0d470c3a652b2 Gerrit-Change-Number: 42168 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Feb 2026 16:38:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in pysim[master]: tests/pySim-smpp2sim_test: add testcases for AES128 and AES256
by dexter 23 Feb '26

23 Feb '26

Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/42189?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: tests/pySim-smpp2sim_test: add testcases for AES128 and AES256 ...................................................................... tests/pySim-smpp2sim_test: add testcases for AES128 and AES256 Extend the existing test script so that it can handle multiple testcases. Also add support for switching eUICC profiles. Finally, add a testcases to test OTA-SMS (RFM) with AES128 and AES256 encryption. Change-Id: I1f10504f3a29a8c74a17991632d932819fecfa5a Related: OS#6868 --- D tests/pySim-smpp2sim_test/pySim-smpp2sim_test.cfg M tests/pySim-smpp2sim_test/pySim-smpp2sim_test.sh A tests/pySim-smpp2sim_test/testcase_3des_cbc2_rfm.cfg A tests/pySim-smpp2sim_test/testcase_aes128_cbc_cmac_rfm.cfg A tests/pySim-smpp2sim_test/testcase_aes256_cbc_cmac_rfm.cfg 5 files changed, 161 insertions(+), 46 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/89/42189/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42189?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1f10504f3a29a8c74a17991632d932819fecfa5a Gerrit-Change-Number: 42189 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: contrib/smpp-ota-tool/cosmetic: fix sourcecode formatting
by dexter 23 Feb '26

23 Feb '26

dexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42183?usp=email ) Change subject: contrib/smpp-ota-tool/cosmetic: fix sourcecode formatting ...................................................................... contrib/smpp-ota-tool/cosmetic: fix sourcecode formatting Change-Id: Icbce41ffac097d2ef8714bc8963536ba54a77db2 Related: OS#6868 --- M contrib/smpp-ota-tool.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: dexter: Looks good to me, approved Jenkins Builder: Verified diff --git a/contrib/smpp-ota-tool.py b/contrib/smpp-ota-tool.py index 3dc2185..f667f84 100755 --- a/contrib/smpp-ota-tool.py +++ b/contrib/smpp-ota-tool.py @@ -224,8 +224,8 @@ spi = {'counter' : opts.cntr_req, 'ciphering' : opts.ciphering, 'rc_cc_ds': opts.rc_cc_ds, - 'por_in_submit':opts.por_in_submit, 'por_shall_be_ciphered':opts.por_shall_be_ciphered, + 'por_in_submit': opts.por_in_submit, 'por_rc_cc_ds': opts.por_rc_cc_ds, 'por': opts.por_req} apdu = h2b("".join(opts.apdu)) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42183?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icbce41ffac097d2ef8714bc8963536ba54a77db2 Gerrit-Change-Number: 42183 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: contrib/smpp-ota-tool/cosmetic: fix sourcecode formatting
by dexter 23 Feb '26

23 Feb '26

dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42183?usp=email ) Change subject: contrib/smpp-ota-tool/cosmetic: fix sourcecode formatting ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42183?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icbce41ffac097d2ef8714bc8963536ba54a77db2 Gerrit-Change-Number: 42183 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Feb 2026 15:50:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in pysim[master]: tests/pySim-smpp2sim_test: add testcases for AES128 and AES256
by Jenkins Builder 23 Feb '26

23 Feb '26

Jenkins Builder has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42189?usp=email ) Change subject: tests/pySim-smpp2sim_test: add testcases for AES128 and AES256 ...................................................................... Patch Set 1: (3 comments) File tests/pySim-smpp2sim_test/testcase_3des_cbc2_rfm.cfg: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/pysim/+/42189/comment/231ea033_25a6c185?usp=em… : PS1, Line 1: # Preperation: 'Preperation' may be misspelled - perhaps 'Preparation'? File tests/pySim-smpp2sim_test/testcase_aes128_cbc_cmac_rfm.cfg: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/pysim/+/42189/comment/b0769943_c49c7a44?usp=em… : PS1, Line 1: # Preperation: 'Preperation' may be misspelled - perhaps 'Preparation'? File tests/pySim-smpp2sim_test/testcase_aes256_cbc_cmac_rfm.cfg: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/pysim/+/42189/comment/ba722dd4_718bc7ef?usp=em… : PS1, Line 1: # Preperation: 'Preperation' may be misspelled - perhaps 'Preparation'? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42189?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1f10504f3a29a8c74a17991632d932819fecfa5a Gerrit-Change-Number: 42189 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 23 Feb 2026 13:56:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in pysim[master]: contrib/smpp-ota-tool: use correct kid index
by dexter 23 Feb '26

23 Feb '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42185?usp=email ) Change subject: contrib/smpp-ota-tool: use correct kid index ...................................................................... contrib/smpp-ota-tool: use correct kid index (normally KID index and KIC index should be the same since mixing keys is a concidered as a security violation. However, in this tool we want to allow users to specify different indexes for KIC and KIC so that they can make tests to make sure their cards correctly reject mixed up key indexes) Change-Id: I8847ccc39e4779971187e7877b8902fca7f8bfc1 Related: OS#6868 --- M contrib/smpp-ota-tool.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/85/42185/1 diff --git a/contrib/smpp-ota-tool.py b/contrib/smpp-ota-tool.py index 353f5b5..c2e9562 100755 --- a/contrib/smpp-ota-tool.py +++ b/contrib/smpp-ota-tool.py @@ -218,7 +218,7 @@ kic_idx=opts.kic_idx, kic=h2b(opts.kic), algo_auth=opts.algo_auth, - kid_idx=opts.kic_idx, + kid_idx=opts.kid_idx, kid=h2b(opts.kid), cntr=opts.cntr) spi = {'counter' : opts.cntr_req, -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42185?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8847ccc39e4779971187e7877b8902fca7f8bfc1 Gerrit-Change-Number: 42185 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: contrib/smpp-ota-tool/cosmetic: use lazy formatting for logging
by dexter 23 Feb '26

23 Feb '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42184?usp=email ) Change subject: contrib/smpp-ota-tool/cosmetic: use lazy formatting for logging ...................................................................... contrib/smpp-ota-tool/cosmetic: use lazy formatting for logging Change-Id: I2540472a50b7a49b5a67d088cbdd4a2228eef8f4 Related: OS#6868 --- M contrib/smpp-ota-tool.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/84/42184/1 diff --git a/contrib/smpp-ota-tool.py b/contrib/smpp-ota-tool.py index f667f84..353f5b5 100755 --- a/contrib/smpp-ota-tool.py +++ b/contrib/smpp-ota-tool.py @@ -141,7 +141,7 @@ tuple containing the last response data and the last status word as byte strings """ - logger.info("C-APDU sending: %s..." % b2h(apdu)) + logger.info("C-APDU sending: %s...", b2h(apdu)) # translate to Secured OTA RFM secured = self.ota_dialect.encode_cmd(self.ota_keyset, self.tar, self.spi, apdu=apdu) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42184?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2540472a50b7a49b5a67d088cbdd4a2228eef8f4 Gerrit-Change-Number: 42184 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: contrib/smpp-ota-tool/cosmetic: fix sourcecode formatting
by dexter 23 Feb '26

23 Feb '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42183?usp=email ) Change subject: contrib/smpp-ota-tool/cosmetic: fix sourcecode formatting ...................................................................... contrib/smpp-ota-tool/cosmetic: fix sourcecode formatting Change-Id: Icbce41ffac097d2ef8714bc8963536ba54a77db2 Related: OS#6868 --- M contrib/smpp-ota-tool.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/83/42183/1 diff --git a/contrib/smpp-ota-tool.py b/contrib/smpp-ota-tool.py index 3dc2185..f667f84 100755 --- a/contrib/smpp-ota-tool.py +++ b/contrib/smpp-ota-tool.py @@ -224,8 +224,8 @@ spi = {'counter' : opts.cntr_req, 'ciphering' : opts.ciphering, 'rc_cc_ds': opts.rc_cc_ds, - 'por_in_submit':opts.por_in_submit, 'por_shall_be_ciphered':opts.por_shall_be_ciphered, + 'por_in_submit': opts.por_in_submit, 'por_rc_cc_ds': opts.por_rc_cc_ds, 'por': opts.por_req} apdu = h2b("".join(opts.apdu)) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42183?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icbce41ffac097d2ef8714bc8963536ba54a77db2 Gerrit-Change-Number: 42183 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: contrib/smpp-ota-tool: add missing usage helpstrings
by dexter 23 Feb '26

23 Feb '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42187?usp=email ) Change subject: contrib/smpp-ota-tool: add missing usage helpstrings ...................................................................... contrib/smpp-ota-tool: add missing usage helpstrings Change-Id: Ic1521ba11b405f311a30fdb3585ad518375669ae Related: OS#6868 --- M contrib/smpp-ota-tool.py 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/87/42187/1 diff --git a/contrib/smpp-ota-tool.py b/contrib/smpp-ota-tool.py index 4e9446b..be08724 100755 --- a/contrib/smpp-ota-tool.py +++ b/contrib/smpp-ota-tool.py @@ -204,9 +204,9 @@ help="PoR check (rc=redundency check, cc=crypt. checksum, ds=digital signature)") option_parser.add_argument("--por_req", choices=POR_REQ.decmapping.values(), default='por_required', help="Proof of Receipt requirements") - option_parser.add_argument('--src-addr', default='12', type=str, help='TODO') - option_parser.add_argument('--dest-addr', default='23', type=str, help='TODO') - option_parser.add_argument('--timeout', default=10, type=int, help='TODO') + option_parser.add_argument('--src-addr', default='12', type=str, help='SMS source address (MSISDN)') + option_parser.add_argument('--dest-addr', default='23', type=str, help='SMS destination address (MSISDN)') + option_parser.add_argument('--timeout', default=10, type=int, help='Maximum response waiting time') option_parser.add_argument('-a', '--apdu', action='append', required=True, type=is_hexstr, help='C-APDU to send') opts = option_parser.parse_args() -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42187?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic1521ba11b405f311a30fdb3585ad518375669ae Gerrit-Change-Number: 42187 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log