- gerrit-log - lists.osmocom.org

[S] Change in osmo-bts[master]: RTP: add vty option for ortp vs twrtp selection
by pespin 23 Feb '26

23 Feb '26

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/42167?usp=email ) Change subject: RTP: add vty option for ortp vs twrtp selection ...................................................................... Patch Set 3: -Code-Review (1 comment) File src/common/vty.c: https://gerrit.osmocom.org/c/osmo-bts/+/42167/comment/485020d9_f84df0c1?usp… : PS3, Line 427: vty_out(vty, " rtp library %s%s", bts->use_twrtp ? "twrtp" : "ortp", write it only in case the non-default option is selected, see https://osmocom.org/issues/6474#note-19 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42167?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iff4e3a399250c16ba8fe4cb12e4e22f4c6b346ec Gerrit-Change-Number: 42167 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 23 Feb 2026 10:13:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-asf4-dfu[master]: dfu: rewrite firmware downloading
by lynxis lazus 23 Feb '26

23 Feb '26

Attention is currently required from: Hoernchen, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174?usp=email ) Change subject: dfu: rewrite firmware downloading ...................................................................... Patch Set 2: (1 comment) File usb/class/dfu/device/dfudf.c: https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174/comment/abd1b3df_77deb12… : PS2, Line 246: if (!(usb_dfu_func_desc->bmAttributes & USB_REQ_DFU_DNLOAD)) { // download is not enabled > Moving this whole block into a function with early returns may make the code a lot easier to follow. […] this whole to_return should be also replaced. -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I345d5948455b25cd8a2efb1abfd9d0986ebd8cef Gerrit-Change-Number: 42174 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Feb 2026 10:07:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-asf4-dfu[master]: dfu: irq: GET_STATUS: set state before sending it
by Hoernchen 23 Feb '26

23 Feb '26

Attention is currently required from: lynxis lazus. Hoernchen has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42172?usp=email ) Change subject: dfu: irq: GET_STATUS: set state before sending it ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42172?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I6d28404d6936f7ea79fcee90f0c8191f0f623ad8 Gerrit-Change-Number: 42172 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 23 Feb 2026 10:05:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-asf4-dfu[master]: dfu: irq: replace if(states) with a switch case
by Hoernchen 23 Feb '26

23 Feb '26

Attention is currently required from: lynxis lazus. Hoernchen has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42171?usp=email ) Change subject: dfu: irq: replace if(states) with a switch case ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: This pointlessly churns code to muddy the blame without improving anything.. -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42171?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: Ic32fe16dff4b7bb933ec62e36a9c7c7829aece1b Gerrit-Change-Number: 42171 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 23 Feb 2026 10:05:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-asf4-dfu[master]: dfu: mainloop: work on a local copy of dfu_state
by Hoernchen 23 Feb '26

23 Feb '26

Attention is currently required from: lynxis lazus, pespin. Hoernchen has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42170?usp=email ) Change subject: dfu: mainloop: work on a local copy of dfu_state ...................................................................... Patch Set 2: Code-Review-2 (1 comment) Patchset: PS2: there are no split 32bit load/stores on m4. -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42170?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: Ic146c8fa5ba25425cf785bae66f9c99b0faab944 Gerrit-Change-Number: 42170 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 23 Feb 2026 10:04:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-asf4-dfu[master]: dfu: MANIFEST: mainloop: wait 5 ms before handling the state
by Hoernchen 23 Feb '26

23 Feb '26

Attention is currently required from: lynxis lazus. Hoernchen has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42177?usp=email ) Change subject: dfu: MANIFEST: mainloop: wait 5 ms before handling the state ...................................................................... Patch Set 2: Code-Review-2 (1 comment) Patchset: PS2: No, see my patch, it is a complete waste of time trying to work around the control transfer based "completion" in particula using random delays, just don't let the dev reset itself. -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42177?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: If9178120eed46f75089abf1898db3176cce93df2 Gerrit-Change-Number: 42177 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 23 Feb 2026 10:02:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-asf4-dfu[master]: dfu: do not reset itself
by Hoernchen 23 Feb '26

23 Feb '26

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42180?usp=email ) Change subject: dfu: do not reset itself ...................................................................... dfu: do not reset itself In theory USB_DFU_ATTRIBUTES_WILL_DETACH is nice, in practice not so much, because usb uses control transfers and "waiting" for status response completion after finishing flashing is cumbersome. There is basically no advantage if the device resets itself, and just waiting for the host to do it like most DFU devices work (and what the BL used to do in the beginning) works around the status issue. Change-Id: I1b9e48470083597640918a8a1126922b31150153 --- M usb/class/dfu/device/dfudf_desc.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-asf4-dfu refs/changes/80/42180/1 diff --git a/usb/class/dfu/device/dfudf_desc.h b/usb/class/dfu/device/dfudf_desc.h index 50a79e4..102d7fc 100644 --- a/usb/class/dfu/device/dfudf_desc.h +++ b/usb/class/dfu/device/dfudf_desc.h @@ -75,7 +75,7 @@ CONF_USB_DFUD_BMATTRI, \ CONF_USB_DFUD_BMAXPOWER) -#define DFUD_IFACE_DESCB USB_DFU_FUNC_DESC_BYTES(USB_DFU_ATTRIBUTES_CAN_DOWNLOAD | USB_DFU_ATTRIBUTES_WILL_DETACH, \ +#define DFUD_IFACE_DESCB USB_DFU_FUNC_DESC_BYTES(USB_DFU_ATTRIBUTES_CAN_DOWNLOAD, \ 0, /**< detaching makes only sense in run-time mode */ \ 512, /**< transfer size corresponds to page size for optimal flash writing */ \ 0x0110 /**< DFU specification version 1.1 used */ ) -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42180?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I1b9e48470083597640918a8a1126922b31150153 Gerrit-Change-Number: 42180 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>

1 0

[S] Change in osmo-asf4-dfu[master]: dfu: fix bState transition/reporting order as per dfu spec
by Hoernchen 23 Feb '26

23 Feb '26

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42178?usp=email ) Change subject: dfu: fix bState transition/reporting order as per dfu spec ...................................................................... dfu: fix bState transition/reporting order as per dfu spec DFU spec wants the next state, not the current one. Change-Id: I06519c73cdb0b082002632da9cfe7436c63f52b0 --- M usb/class/dfu/device/dfudf.c 1 file changed, 10 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-asf4-dfu refs/changes/78/42178/1 diff --git a/usb/class/dfu/device/dfudf.c b/usb/class/dfu/device/dfudf.c index 223999a..5c5682e 100644 --- a/usb/class/dfu/device/dfudf.c +++ b/usb/class/dfu/device/dfudf.c @@ -160,14 +160,9 @@ to_return = ERR_UNSUPPORTED_OP; // stall control pipe (don't reply to the request) break; case USB_DFU_GETSTATUS: // get status - response[0] = dfu_status; // set status - response[1] = 10; // set poll timeout (24 bits, in milliseconds) to small value for periodical poll - response[2] = 0; // set poll timeout (24 bits, in milliseconds) to small value for periodical poll - response[3] = 0; // set poll timeout (24 bits, in milliseconds) to small value for periodical poll - response[4] = dfu_state; // set state - response[5] = 0; // string not used - to_return = usbdc_xfer(ep, response, 6, false); // send back status - if (USB_DFU_STATE_DFU_DNLOAD_SYNC == dfu_state) { // download has not completed + // per DFU 1.1 spec, bState must report the state the device will enter + // after this response, so perform state transitions before building response + if (USB_DFU_STATE_DFU_DNLOAD_SYNC == dfu_state) { dfu_state = USB_DFU_STATE_DFU_DNBUSY; // switch to busy state } else if (USB_DFU_STATE_DFU_MANIFEST_SYNC == dfu_state) { if (!dfu_manifestation_complete) { @@ -178,6 +173,13 @@ dfu_state = USB_DFU_STATE_DFU_MANIFEST_WAIT_RESET; // wait for reset } } + response[0] = dfu_status; // set status + response[1] = 10; // set poll timeout (24 bits, in milliseconds) to small value for periodical poll + response[2] = 0; // set poll timeout (24 bits, in milliseconds) to small value for periodical poll + response[3] = 0; // set poll timeout (24 bits, in milliseconds) to small value for periodical poll + response[4] = dfu_state; // set state (post-transition) + response[5] = 0; // string not used + to_return = usbdc_xfer(ep, response, 6, false); // send back status break; case USB_DFU_GETSTATE: // get state response[0] = dfu_state; // return state -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42178?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I06519c73cdb0b082002632da9cfe7436c63f52b0 Gerrit-Change-Number: 42178 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>

1 0

[XS] Change in osmo-asf4-dfu[master]: dfu: make resp buffer static
by Hoernchen 23 Feb '26

23 Feb '26

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42179?usp=email ) Change subject: dfu: make resp buffer static ...................................................................... dfu: make resp buffer static USB dma uses a buffer depending on alignment, so this can be safe, but it should not be depend on reading and knowing the asf source code... Change-Id: I2f9336143190350817e6352b00751b35b1600b62 --- M usb/class/dfu/device/dfudf.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-asf4-dfu refs/changes/79/42179/1 diff --git a/usb/class/dfu/device/dfudf.c b/usb/class/dfu/device/dfudf.c index 5c5682e..c62cafb 100644 --- a/usb/class/dfu/device/dfudf.c +++ b/usb/class/dfu/device/dfudf.c @@ -153,7 +153,7 @@ } int32_t to_return = ERR_NONE; - uint8_t response[6]; // buffer for the response to this request + static uint8_t response[6]; // static: usbdc_xfer stores a pointer for async DMA switch (req->bRequest) { case USB_DFU_UPLOAD: // upload firmware from flash not supported dfu_state = USB_DFU_STATE_DFU_ERROR; // unsupported class request -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42179?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I2f9336143190350817e6352b00751b35b1600b62 Gerrit-Change-Number: 42179 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>

1 0

[XS] Change in osmo-ccid-firmware[master]: ccid_common: iso_handle_fsm_events: add missing return
by laforge 23 Feb '26

23 Feb '26

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42160?usp=email ) Change subject: ccid_common: iso_handle_fsm_events: add missing return ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42160?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I4066c8a1ab1eadb3d8f8cbaf5aa0afbbb2e5dd80 Gerrit-Change-Number: 42160 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 23 Feb 2026 09:46:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log