- gerrit-log - lists.osmocom.org

[S] Change in osmo-asf4-dfu[master]: dfu: MANIFEST_SYNC: stay in MANIFEST_SYNC when manifestationIntoleran...
by pespin 23 Feb '26

23 Feb '26

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42175?usp=email ) Change subject: dfu: MANIFEST_SYNC: stay in MANIFEST_SYNC when manifestationIntolerant & completed ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File usb/class/dfu/device/dfudf.c: https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42175/comment/1411a2aa_328d3c0… : PS2, Line 184: if (!dfu_manifestation_complete) { may make sense to actually switch the if path to be "if (dfu_manifestation_complete)" now. -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42175?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I8c34a18e2336731126a8c01070d86e2547578e3d Gerrit-Change-Number: 42175 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 23 Feb 2026 09:15:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-asf4-dfu[master]: dfu: rewrite firmware downloading
by pespin 23 Feb '26

23 Feb '26

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174?usp=email ) Change subject: dfu: rewrite firmware downloading ...................................................................... Patch Set 2: (3 comments) File usb/class/dfu/device/dfudf.c: https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174/comment/88d2526a_8eb7d9b… : PS2, Line 246: if (!(usb_dfu_func_desc->bmAttributes & USB_REQ_DFU_DNLOAD)) { // download is not enabled Moving this whole block into a function with early returns may make the code a lot easier to follow. In that case you can also drop the "else if" and have them as "if". Actually, you can already remove the "else if" now and have them as "if" in here? File usb_start.c: https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174/comment/0ef86264_e459cb6… : PS2, Line 171: /* FIXME: check if dfu_download_offset / length are valid */ is this related to the changes in this commit? https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174/comment/cf4cfe39_170c546… : PS2, Line 178: CRITICAL_SECTION_ENTER(); why do you need the critical section here exactly? to increment dfu_download_offset? -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I345d5948455b25cd8a2efb1abfd9d0986ebd8cef Gerrit-Change-Number: 42174 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 23 Feb 2026 09:14:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-bts[master]: RTP: add vty option for ortp vs twrtp selection
by falconia 23 Feb '26

23 Feb '26

Attention is currently required from: pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/42167?usp=email ) Change subject: RTP: add vty option for ortp vs twrtp selection ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > What I lack here (or follow-up patch) is the possibility to build osmo-bts with --disable-ortp. I plan on producing that patch after the present series is accepted and merged. Don't get me wrong, I also want to be able to build `osmo-bts-trx` on machines that don't have Belledonne dependency chain installed! Doesn't really matter for sysmoBTS given that the SDK already has all those dependencies in it, but eventually I will want to play with `osmo-bts-trx` and CSD too... -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42167?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iff4e3a399250c16ba8fe4cb12e4e22f4c6b346ec Gerrit-Change-Number: 42167 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Feb 2026 09:09:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in osmo-bts[master]: RTP: implement RTP socket abstraction layer
by falconia 23 Feb '26

23 Feb '26

Attention is currently required from: pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/42165?usp=email ) Change subject: RTP: implement RTP socket abstraction layer ...................................................................... Patch Set 3: (3 comments) File src/common/rtp_abstract.c: https://gerrit.osmocom.org/c/osmo-bts/+/42165/comment/83a67ca3_8c3347b5?usp… : PS3, Line 14: #define HAVE_ORTP > s/tab/space/ ? I will change it in the next iteration if Osmocom style preference is to use space here. https://gerrit.osmocom.org/c/osmo-bts/+/42165/comment/51e6e1f8_937a0c61?usp… : PS3, Line 54: #ifdef HAVE_ORTP > I think splitting the whole implementation into 2 different main blocks (reimplementing functions on […] How do you propose doing so? Each function needs to check if the `rtp_abst_socket` it operates on was created in ortp or twrtp mode. https://gerrit.osmocom.org/c/osmo-bts/+/42165/comment/c538eb24_f08a3a2b?usp… : PS3, Line 169: osmo_twrtp_twjit_rx_ctrl(rs->twrtp, true); > is it needed to call this every time we poll? Not needed, but no harm either. We do need to make sure that it is only called when we are truly ready to commit to polling, and I couldn't find a better way. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42165?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic945f6d753ec7f5c0ac5cecc9f71049464de7e8f Gerrit-Change-Number: 42165 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Feb 2026 09:05:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-asf4-dfu[master]: dfu: usb_dfu() convert if() intos switch/case
by pespin 23 Feb '26

23 Feb '26

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42173?usp=email ) Change subject: dfu: usb_dfu() convert if() intos switch/case ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42173?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: Ie0abcdb51612598e77cacf7772276919ded17d5a Gerrit-Change-Number: 42173 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 23 Feb 2026 09:04:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-asf4-dfu[master]: dfu: irq: GET_STATUS: set state before sending it
by pespin 23 Feb '26

23 Feb '26

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42172?usp=email ) Change subject: dfu: irq: GET_STATUS: set state before sending it ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42172?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I6d28404d6936f7ea79fcee90f0c8191f0f623ad8 Gerrit-Change-Number: 42172 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 23 Feb 2026 09:03:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-asf4-dfu[master]: dfu: irq: replace if(states) with a switch case
by pespin 23 Feb '26

23 Feb '26

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42171?usp=email ) Change subject: dfu: irq: replace if(states) with a switch case ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42171?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: Ic32fe16dff4b7bb933ec62e36a9c7c7829aece1b Gerrit-Change-Number: 42171 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 23 Feb 2026 09:02:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-asf4-dfu[master]: dfu: mainloop: work on a local copy of dfu_state
by pespin 23 Feb '26

23 Feb '26

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42170?usp=email ) Change subject: dfu: mainloop: work on a local copy of dfu_state ...................................................................... Patch Set 2: (1 comment) File usb_start.c: https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42170/comment/47a0f68e_8e61a09… : PS2, Line 162: enum usb_dfu_state last_dfu_state = dfu_state; is this assignment atomic actually? -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42170?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: Ic146c8fa5ba25425cf785bae66f9c99b0faab944 Gerrit-Change-Number: 42170 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 23 Feb 2026 09:01:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-asf4-dfu[master]: dfu: make dfu_state/dfu_status volatile
by pespin 23 Feb '26

23 Feb '26

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42169?usp=email ) Change subject: dfu: make dfu_state/dfu_status volatile ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42169?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I7ad5255064917c203cebe5ab54a5d457baa2f5ed Gerrit-Change-Number: 42169 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 23 Feb 2026 09:01:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bts[master]: RTP: add vty configuration for twjit
by falconia 23 Feb '26

23 Feb '26

Attention is currently required from: pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/42164?usp=email ) Change subject: RTP: add vty configuration for twjit ...................................................................... Patch Set 2: (1 comment) File src/common/vty.c: https://gerrit.osmocom.org/c/osmo-bts/+/42164/comment/81dfc1e2_1bea9b78?usp… : PS2, Line 494: > shouldn't vty indentation be " " here (2space)? No, it is correct - there is one more space added inside the library. (The original version emitted the `twjit` line inside the library too.) I also tested this code on a sysmoBTS, and the output of `show running-config` looks correct, all indentation is as it should be. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42164?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I9ccd060fce8416e01356fccd9ae465a7298a9ce5 Gerrit-Change-Number: 42164 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Feb 2026 09:00:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log