Attention is currently required from: osmith.
pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40142?usp=email )
Change subject: jobs: run ttcn3-bts-test-* between 01:00 - 06:00
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
tbh with some fake_trx delays I saw myself on my own laptop I doubt it will improve a lot the problem, but will see.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40142?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I0162f7299c8e37f893ffa10ddc4c8edece29ed7f
Gerrit-Change-Number: 40142
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 24 Apr 2025 13:49:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/40119?usp=email )
Change subject: edit_{binary,record}_decoded: Support hex-decode of bytes
......................................................................
edit_{binary,record}_decoded: Support hex-decode of bytes
We've created + used osmocom.utils.JsonEncoder as an encoder class
for json.{dump,dumps} for quite some time. However, we missed to
use this decoder class from the edit_{binary,record}_decoded commands
in the pySim-shell VTY.
Change-Id: I158e028f9920d8085cd20ea022be2437c64ad700
Related: OS#6774
---
M pySim/filesystem.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/pySim/filesystem.py b/pySim/filesystem.py
index 2d9a07e..6712755 100644
--- a/pySim/filesystem.py
+++ b/pySim/filesystem.py
@@ -661,7 +661,7 @@
filename = '%s/file' % dirname
# write existing data as JSON to file
with open(filename, 'w') as text_file:
- json.dump(orig_json, text_file, indent=4)
+ json.dump(orig_json, text_file, indent=4, cls=JsonEncoder)
# run a text editor
self._cmd.run_editor(filename)
with open(filename, 'r') as text_file:
@@ -963,7 +963,7 @@
filename = '%s/file' % dirname
# write existing data as JSON to file
with open(filename, 'w') as text_file:
- json.dump(orig_json, text_file, indent=4)
+ json.dump(orig_json, text_file, indent=4, cls=JsonEncoder)
# run a text editor
self._cmd.run_editor(filename)
with open(filename, 'r') as text_file:
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/40119?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I158e028f9920d8085cd20ea022be2437c64ad700
Gerrit-Change-Number: 40119
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>