Attention is currently required from: falconia, pespin.
laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/42165?usp=email )
Change subject: RTP: implement RTP socket abstraction layer
......................................................................
Patch Set 3:
(1 comment)
File src/common/rtp_abstract.c:
https://gerrit.osmocom.org/c/osmo-bts/+/42165/comment/5d424732_d6519008?usp… :
PS3, Line 109: const struct in_addr *ip, uint16_t port)
> Ah I see, we didn't support IPv6 here yet because ortp doesn't support it? […]
well, I think the Abis-over-IP protocol doesn't even contain features to use IPv6 addresses for the RTP sockets in the IPAC_{CRCX,MDCX} messages. So while in general I think every code should be IPv6 ready for 20 or more years by now, supporting IPv6 in this rtp code here would just mean we end up with dead and inaccessible code, unless we invent some osmocom-specific extension to the IPA Abis dialect :(
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42165?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ic945f6d753ec7f5c0ac5cecc9f71049464de7e8f
Gerrit-Change-Number: 42165
Gerrit-PatchSet: 3
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 23 Feb 2026 09:37:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174?usp=email )
Change subject: dfu: rewrite firmware downloading
......................................................................
Patch Set 2:
(2 comments)
File usb_start.c:
https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174/comment/fec43c96_70cd59e… :
PS2, Line 171: /* FIXME: check if dfu_download_offset / length are valid */
> is this related to the changes in this commit?
the fixme or the lines above?
Maybe I can improve the dfu_download_ffset / length -> they should be within the flash region, but not sure if flash_write will also handle those.
https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174/comment/e45fb764_6a6cd6d… :
PS2, Line 178: CRITICAL_SECTION_ENTER();
> why do you need the critical section here exactly? to increment dfu_download_offset?
yes, for dfu_download_offset and to ensure `dfu_flash_done = true` isn't set without dfu_flash_status.
--
To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-asf4-dfu
Gerrit-Branch: master
Gerrit-Change-Id: I345d5948455b25cd8a2efb1abfd9d0986ebd8cef
Gerrit-Change-Number: 42174
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 23 Feb 2026 09:36:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: neels.
laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/42155?usp=email )
Change subject: esim/http_json_api.py: support text/plain response Content-Type
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42155?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Iba6e4cef1048b376050a435a900c0f395655a790
Gerrit-Change-Number: 42155
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 23 Feb 2026 09:33:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: falconia.
pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/42167?usp=email )
Change subject: RTP: add vty option for ortp vs twrtp selection
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42167?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iff4e3a399250c16ba8fe4cb12e4e22f4c6b346ec
Gerrit-Change-Number: 42167
Gerrit-PatchSet: 3
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Comment-Date: Mon, 23 Feb 2026 09:21:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: falconia.
pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/42164?usp=email )
Change subject: RTP: add vty configuration for twjit
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/common/vty.c:
https://gerrit.osmocom.org/c/osmo-bts/+/42164/comment/d52e0464_4f563479?usp… :
PS2, Line 494:
> No, it is correct - there is one more space added inside the library. […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42164?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I9ccd060fce8416e01356fccd9ae465a7298a9ce5
Gerrit-Change-Number: 42164
Gerrit-PatchSet: 2
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Comment-Date: Mon, 23 Feb 2026 09:20:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: falconia <falcon(a)freecalypso.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42177?usp=email )
Change subject: dfu: MANIFEST: mainloop: wait 5 ms before handling the state
......................................................................
Patch Set 2:
(1 comment)
File usb_start.c:
https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42177/comment/7b637967_5758498… :
PS2, Line 203: the board might go into reset to fast through MANIFEST_WAIT_RESET */
too fast
--
To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42177?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-asf4-dfu
Gerrit-Branch: master
Gerrit-Change-Id: If9178120eed46f75089abf1898db3176cce93df2
Gerrit-Change-Number: 42177
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 23 Feb 2026 09:19:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No