- gerrit-log - lists.osmocom.org

[XS] Change in ...osmo_dia2gsup[master]: osmo_dia2gsup: set sndbuf/recbuf explicitly for SCTP

by fixeria

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40127?usp=email ) Change subject: osmo_dia2gsup: set sndbuf/recbuf explicitly for SCTP ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > we should probably prepare a new release of osmo_dia2gsup after this. Ack, see https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40150. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40127?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I793f1295ab42bfc548511fc5ffbda9070280745f Gerrit-Change-Number: 40127 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Apr 2025 20:13:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[XS] Change in ...osmo_dia2gsup[master]: rebar.config: relx: fix wrong sys_config, drop vm_args

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40148?usp=email ) Change subject: rebar.config: relx: fix wrong sys_config, drop vm_args ...................................................................... rebar.config: relx: fix wrong sys_config, drop vm_args * The config files are in the 'examples' folder (not 'config'). * The file 'config/vm.args' does not exist at all. Change-Id: I07c161e0cabd479864ec8e927e8d45b523ae4b83 --- M rebar.config 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/48/40148/1 diff --git a/rebar.config b/rebar.config index 3bda3e5..b1a6e60 100644 --- a/rebar.config +++ b/rebar.config @@ -37,8 +37,7 @@ {relx, [{release, {'osmo-dia2gsup', {git, long}}, [osmo_dia2gsup]}, - {sys_config, "./config/sys.config"}, - {vm_args, "./config/vm.args"}, + {sys_config, "./examples/sys.config"}, {dev_mode, false}, {include_erts, true}, {extended_start_script, true}]}. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40148?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I07c161e0cabd479864ec8e927e8d45b523ae4b83 Gerrit-Change-Number: 40148 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[S] Change in ...osmo dia2gsup[master]: Bump version: 0.3.2-7-gf9e423b → 0.3.3

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40150?usp=email ) Change subject: Bump version: 0.3.2-7-gf9e423b → 0.3.3 ...................................................................... Bump version: 0.3.2-7-gf9e423b → 0.3.3 Change-Id: I5d2d487bd49ee3159422edf93f8dee3b035ed3bb --- M debian/changelog 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/50/40150/1 diff --git a/debian/changelog b/debian/changelog index eaa669e..9bf0542 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,15 @@ +osmo-diameter2gsup (0.3.3) unstable; urgency=medium + + * osmo_dia2gsup: add get_env/2 for convenience + * osmo_dia2gsup: add and use parse_addr/1 + * osmo_dia2gsup: move env parsing and logging to listen/1 + * osmo_dia2gsup: disable Nagle for TCP/SCTP by default + * osmo_dia2gsup: set sndbuf/recbuf explicitly for SCTP + * rebar.config: relx: fix wrong sys_config, drop vm_args + * rebar.config: relx: use semver instead of long git hash + + -- Vadim Yanitskiy <vyanitskiy(a)sysmocom.de> Fri, 25 Apr 2025 03:04:10 +0700 + osmo-diameter2gsup (0.3.2) unstable; urgency=medium [ Vadim Yanitskiy ] -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40150?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I5d2d487bd49ee3159422edf93f8dee3b035ed3bb Gerrit-Change-Number: 40150 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[XS] Change in ...osmo_dia2gsup[master]: rebar.config: relx: use semver instead of long git hash

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40149?usp=email ) Change subject: rebar.config: relx: use semver instead of long git hash ...................................................................... rebar.config: relx: use semver instead of long git hash * '{git, long}' renders: osmo-dia2gsup-9db314e3fd1598e58d65843770789fec9e090a54.tar.gz * 'semver' renders: osmo-dia2gsup-0.3.2+build.6.ref9db314e.tar.gz Change-Id: I6270e2057eba21d0727a54586b1e2fb1022159cf --- M rebar.config 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/49/40149/1 diff --git a/rebar.config b/rebar.config index b1a6e60..455fd6c 100644 --- a/rebar.config +++ b/rebar.config @@ -35,8 +35,7 @@ {escript_name, "osmo-dia2gsup"}. {relx, - [{release, {'osmo-dia2gsup', {git, long}}, - [osmo_dia2gsup]}, + [{release, {'osmo-dia2gsup', semver}, [osmo_dia2gsup]}, {sys_config, "./examples/sys.config"}, {dev_mode, false}, {include_erts, true}, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40149?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I6270e2057eba21d0727a54586b1e2fb1022159cf Gerrit-Change-Number: 40149 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[XS] Change in ...osmo_dia2gsup[master]: osmo_dia2gsup.app.src: add missing 'crypto' app

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40147?usp=email ) Change subject: osmo_dia2gsup.app.src: add missing 'crypto' app ...................................................................... osmo_dia2gsup.app.src: add missing 'crypto' app This fixes the following warning when generating a release tarball: ===> server_cb:compute_kasme/4 calls undefined function crypto:macN/5 Change-Id: I59d21522b99c0ab1a02a57a8cbb898f222a94ec4 --- M src/osmo_dia2gsup.app.src 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/47/40147/1 diff --git a/src/osmo_dia2gsup.app.src b/src/osmo_dia2gsup.app.src index 941573a..d7f4a7f 100644 --- a/src/osmo_dia2gsup.app.src +++ b/src/osmo_dia2gsup.app.src @@ -5,6 +5,7 @@ {applications, [ kernel, stdlib, + crypto, lager, diameter, osmo_gsup, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40147?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I59d21522b99c0ab1a02a57a8cbb898f222a94ec4 Gerrit-Change-Number: 40147 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[XS] Change in ...osmo_dia2gsup[master]: rebar.{config,lock}: bump lager version: 3.9.1 -> 3.9.2

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40144?usp=email ) Change subject: rebar.{config,lock}: bump lager version: 3.9.1 -> 3.9.2 ...................................................................... rebar.{config,lock}: bump lager version: 3.9.1 -> 3.9.2 This fixes tons of false-positive "a term is constructed, but never used" warnings. For more details, see: https://github.com/erlang-lager/lager/issues/546 https://github.com/erlang-lager/lager/pull/547 Change-Id: Id17900cb1b6fbcd6fbc13d16b90b67b82342accb --- M rebar.config M rebar.lock 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/44/40144/1 diff --git a/rebar.config b/rebar.config index 3bda3e5..1b69b87 100644 --- a/rebar.config +++ b/rebar.config @@ -2,7 +2,7 @@ {deps, [ {setup, "2.0.2"}, - {lager, {git, "https://github.com/erlang-lager/lager", {tag, "3.9.1"}}}, + {lager, {git, "https://github.com/erlang-lager/lager", {tag, "3.9.2"}}}, {osmo_ss7, {git, "https://gitea.osmocom.org/erlang/osmo_ss7", {branch, "master"}}}, {osmo_gsup, {git, "https://gitea.osmocom.org/erlang/osmo_gsup", {branch, "master"}}} ]}. diff --git a/rebar.lock b/rebar.lock index 2114e56..92484a9 100644 --- a/rebar.lock +++ b/rebar.lock @@ -6,7 +6,7 @@ {<<"goldrush">>,{pkg,<<"goldrush">>,<<"0.1.9">>},1}, {<<"lager">>, {git,"https://github.com/erlang-lager/lager", - {ref,"c5447d2d85a0d446d41a79bffe0a6a66bd50c901"}}, + {ref,"459a3b2cdd9eadd29e5a7ce5c43932f5ccd6eb88"}}, 0}, {<<"osmo_gsup">>, {git,"https://gitea.osmocom.org/erlang/osmo_gsup", @@ -18,7 +18,7 @@ 0}, {<<"parse_trans">>, {git,"https://github.com/uwiger/parse_trans", - {ref,"d443908e0a8e3842c4763cefd4b37457b892c121"}}, + {ref,"d99fb36755c813a5db23e6f93741aa58323ef911"}}, 1}, {<<"pkt">>, {git,"https://github.com/msantos/pkt", -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40144?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: Id17900cb1b6fbcd6fbc13d16b90b67b82342accb Gerrit-Change-Number: 40144 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[XS] Change in ...osmo_dia2gsup[master]: osmo_dia2gsup: remove unused start/0

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40146?usp=email ) Change subject: osmo_dia2gsup: remove unused start/0 ...................................................................... osmo_dia2gsup: remove unused start/0 This function is not used anywhere. It's also not consistent with the start_link/0, which is starting the gen_server instance. Change-Id: Ibd4e1d86dc59d792f7f6ac027ee63fc2086b31c3 --- M src/osmo_dia2gsup.erl 1 file changed, 1 insertion(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/46/40146/1 diff --git a/src/osmo_dia2gsup.erl b/src/osmo_dia2gsup.erl index cda616b..47ca2a4 100644 --- a/src/osmo_dia2gsup.erl +++ b/src/osmo_dia2gsup.erl @@ -40,7 +40,7 @@ % API -export([start_link/0]). --export([start/0, stop/0]). +-export([stop/0]). % gen_server callbacks -export([init/1, handle_call/3, handle_cast/2, handle_info/2]). @@ -80,10 +80,6 @@ start_link() -> gen_server:start_link({local, ?SERVER}, ?MODULE, [], []). -start() -> - application:ensure_all_started(?MODULE), - start_link(). - stop() -> gen_server:cast(?SERVER, stop). -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40146?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: Ibd4e1d86dc59d792f7f6ac027ee63fc2086b31c3 Gerrit-Change-Number: 40146 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[XS] Change in ...osmo_dia2gsup[master]: server_cb: comment out unused fields in handle_request/3

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40145?usp=email ) Change subject: server_cb: comment out unused fields in handle_request/3 ...................................................................... server_cb: comment out unused fields in handle_request/3 This fixes the following warnings: * Warning: variable 'RatType' is unused * Warning: variable 'UlrFlags' is unused Change-Id: I3b709cfc723418c1ec88d15bc25bb2cef462a4d3 --- M src/server_cb.erl 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/45/40145/1 diff --git a/src/server_cb.erl b/src/server_cb.erl index 815eaf6..f51bb5c 100644 --- a/src/server_cb.erl +++ b/src/server_cb.erl @@ -287,8 +287,8 @@ % extract relevant fields from DIAMETER ULR #diameter_caps{origin_host = {OH,_}, origin_realm = {OR,_}} = Caps, #'ULR'{'Session-Id' = SessionId, - 'RAT-Type' = RatType, - 'ULR-Flags' = UlrFlags, +%% XXX 'RAT-Type' = RatType, +%% XXX 'ULR-Flags' = UlrFlags, 'User-Name' = UserName} = Req, % construct GSUP UpdateLocation request to HLR and transceive it; expect InsertSubscrDataReq -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40145?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I3b709cfc723418c1ec88d15bc25bb2cef462a4d3 Gerrit-Change-Number: 40145 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[M] Change in osmo-ci[master]: jobs: run ttcn3-bts-test-* between 01:00 - 06:00

by fixeria

fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40142?usp=email ) Change subject: jobs: run ttcn3-bts-test-* between 01:00 - 06:00 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40142?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0162f7299c8e37f893ffa10ddc4c8edece29ed7f Gerrit-Change-Number: 40142 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Apr 2025 19:24:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months, 2 weeks

1
0
0 0

[M] Change in osmo-ci[master]: jobs: run ttcn3-bts-test-* between 01:00 - 06:00

by fixeria

fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40142?usp=email ) Change subject: jobs: run ttcn3-bts-test-* between 01:00 - 06:00 ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > tbh with some fake_trx delays I saw myself on my own laptop I doubt it will improve a lot the proble […] I guess you're talking about recent master, which is doing queuing? FYI: I created a branch called `ttcn3-bts-test`, which points to the point predating Kirill's patches. So fake_trx.py is "reverted" back to a known working state, but we're still seeing clock issues in ttcn3-bts-test. Running 4 variants of ttcn3-bts-test (and thus 4 fake_trx.py instances and 4 osmo-bts-trx instances) on the same machine at the same time is prone to latency issues. Even when we had `respawn.sh` in place, this was likely the reason of sporadic testcase failures that I was unable to reproduce locally. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40142?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0162f7299c8e37f893ffa10ddc4c8edece29ed7f Gerrit-Change-Number: 40142 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Apr 2025 19:22:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log