Attention is currently required from: fixeria, pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43753?usp=email )
Change subject: ss7_asp_peer: Improvements in ss7_asp_peer_snprintf()
......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS3:
would you mind adding tests showing that this works as expected?
File src/ss7_asp_peer.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43753/comment/cd2fe9a0_8a6f60... :
PS3, Line 73: |
this looks like it would always add an extra |?
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43753?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I115951627adb0c6778a9a36159237c3eea130300
Gerrit-Change-Number: 43753
Gerrit-PatchSet: 3
Gerrit-Owner: pespin
pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: jolly
andreas@eversberg.eu
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Tue, 06 Oct 2026 09:52:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No