Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43047?usp=email )
Change subject: V1.2: Add TERMINAL CAPABILITY for IoT support
......................................................................
Patch Set 1:
(3 comments)
File src/ipa/libipa/euicc.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43047/comment/c3e90e4c_96c611d1… :
PS1, Line 360: /* Send terminal capablilities, see also 3gpp TS 102.221 V16.2.0, section 11.1.19.2.4 */
I would change the section to 11.1.19 only, this function is now about the TERMINAL CAPABILITY command in general.
https://gerrit.osmocom.org/c/onomondo-ipa/+/43047/comment/545dd5e2_ed2e0a19… :
PS1, Line 534: {
I think we should add a spec reference here:
3gpp TS 102.221, section 11.1.19.2.4
GSMA SGP.32, section 3.8.2
https://gerrit.osmocom.org/c/onomondo-ipa/+/43047/comment/e4fb86d3_6a2fe84e… :
PS1, Line 545: if (!ctx->cfg->iot_euicc_emu_enabled) {
I think we should pack termcap_euicc and termcap_iot into one TLV object and send it with a single TERMINAL CAPABILITY command. The spec does not say it absolutely, but I don't think that you can send multiple TERMINAL CAPABILITY commands where each one activates a different feature. I think that a consecutive TERMINAL CAPABILTY command will overwrite the changes of the previous one. - correct me if I am wrong.
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43047?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I1116bee93b31ee4a159125d840d7c5866be6fdb4
Gerrit-Change-Number: 43047
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Wed, 22 Jul 2026 14:26:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43046?usp=email )
Change subject: V1.2: Add new flags to eUICCMemoryReset
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/ipa/libipa/ipad.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43046/comment/494dded3_b8257b13… :
PS1, Line 257: * \returns 0 on success, negative on error. */
The apidoc also needs to be updated.
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43046?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I8c683e93c2a10ff64c3ef14767000c59f81be090
Gerrit-Change-Number: 43046
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Wed, 22 Jul 2026 14:04:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43043?usp=email )
Change subject: V1.2: Add function ES10b.EnableEmergencyProfile
......................................................................
Patch Set 1:
(1 comment)
File src/ipa/main.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43043/comment/c112bd19_37277b07… :
PS1, Line 314: ipa_enable_emergency_profile(ctx, getopt_refresh_flag);
(see comments regarding the refresh_flag in the previous patches)
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43043?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I0304b869a14a36b82cc2d1676b2a5f613e1da171
Gerrit-Change-Number: 43043
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Wed, 22 Jul 2026 13:50:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43042?usp=email )
Change subject: V1.2: Add function ES10b.ReturnFromFallback
......................................................................
Patch Set 1:
(2 comments)
File src/ipa/libipa/ipad.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43042/comment/0f89eb64_0f8d8c2f… :
PS1, Line 299: {
(see comments from the previous patch)
File src/ipa/main.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43042/comment/e4c3b44d_4d48a810… :
PS1, Line 304: ipa_return_from_fallback(ctx, getopt_refresh_flag);
(see comments in the patch below this one)
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43042?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: Ib49a8ef3a5ea5639d881ca51eaeeea24f083fe0e
Gerrit-Change-Number: 43042
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Wed, 22 Jul 2026 13:48:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43041?usp=email )
Change subject: V1.2: Add function ES10b.ExecuteFallbackMechanism
......................................................................
Patch Set 1:
(1 comment)
File src/ipa/libipa/ipad.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43041/comment/42a56427_3c87207b… :
PS1, Line 272: {
I would suggest to drop the refresh_flag parameter and use ctx->cfg->refresh_flag instead. The current architecture expects the API user to configure the refresh_flag in advance via struct ipa_config (see ipad.h).
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43041?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: Ia751f0888c36f39ddfadf7f8bb923a8ee50178dc
Gerrit-Change-Number: 43041
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Wed, 22 Jul 2026 12:16:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43041?usp=email )
Change subject: V1.2: Add function ES10b.ExecuteFallbackMechanism
......................................................................
Patch Set 1:
(4 comments)
File src/ipa/libipa/ipad.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43041/comment/ba0a982d_cab0ec0c… :
PS1, Line 282: exec_fallback_mech.req.refreshFlag = refresh_flag;
You could put the whole setup into ipa_es10b_exec_fallback_mech and call the function like this:
rc = ipa_es10b_exec_fallback_mech(refresh_flag)
if rc != 0
return -EINVAL
File src/ipa/main.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43041/comment/0ee9fa51_4b6b0c07… :
PS1, Line 52: printf(" --execute-fallback-mechanism Trigger enabling of fallback profile\n");
This is the only long option now. (maybe we should have long options for all parameters in addition to the short ones?)
https://gerrit.osmocom.org/c/onomondo-ipa/+/43041/comment/c11b9866_cdb3c341… :
PS1, Line 53: printf(" --refresh-flag.............. Make eUICC send a CAT refresh after switchting profile with the triggers above.\n");
I think we should use the refresh_flag from (cfg.refresh_flag, see ipad.h).
(see also comment below)
https://gerrit.osmocom.org/c/onomondo-ipa/+/43041/comment/3e47a09a_58cbf977… :
PS1, Line 209: getopt_refresh_flag = true;
maybe set
cfg.refresh_flag = true
here. Then the new command line option can be used in a more general way. (at the moment we have no means to influence the refreshFlag from the commandline. Its always false.
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43041?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: Ia751f0888c36f39ddfadf7f8bb923a8ee50178dc
Gerrit-Change-Number: 43041
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Wed, 22 Jul 2026 12:12:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43039?usp=email )
Change subject: V1.2: Change names and structure in IpaEuiccData
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
Looks correct on the first look. I also see this gets rewritten in a follow-up-patch when the ESipa API change is addressed in full.
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43039?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I0dc80706bff5b2020cbd31a57c9526aae9d50169
Gerrit-Change-Number: 43039
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Wed, 22 Jul 2026 11:59:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes