Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42965?usp=email )
Change subject: Add close function to HTTP_Server_Emulation
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
File library/HTTP_Server_Emulation.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42965/comment/57d29f4c_83d0… :
PS4, Line 125: inout HTTPMessage, Close;
I would give the close a separate line.
When I understand this correctly, then the it should be
in Close;
because we currently only receive the Close event from the CLIENT, but the CLIENT does not get any Close event back, so its input only. - Correct me if I have overlooked something.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42965?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id09976800c7498a7173b5d8911fe545504cfa266
Gerrit-Change-Number: 42965
Gerrit-PatchSet: 4
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Thu, 23 Jul 2026 12:30:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43032?usp=email )
Change subject: V1.2: Add new fields to ProfileInfo list
......................................................................
Patch Set 1: Code-Review-1
(2 comments)
Patchset:
PS1:
Unfortunately we have introduced a crash here.
File src/ipa/libipa/es10c_get_prfle_info.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43032/comment/adb071fa_95873056… :
PS1, Line 116: memcpy(conv_req, req, sizeof(struct ipa_es10c_get_prfle_info_req));
somewhere below here is a heap-buffer-overflow, you can provoke it by using the current eIM (pmaier/wip) with ./tryme_listProfileInfo.sh A
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43032?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I6667dba8dd84817cfee69daa1c44b98239fa171c
Gerrit-Change-Number: 43032
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Thu, 23 Jul 2026 11:13:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43073?usp=email )
Change subject: V1.2: Cange remaining ASN1 definition to SGP.32 V1.2
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
There are some changes that are more than just a cosmetic change (transactionId renamed to eimTransactionId and size constraints)
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43073?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: Ifa2546784a6d75170e4f5aae2a5e98edb2c0627a
Gerrit-Change-Number: 43073
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Thu, 23 Jul 2026 10:22:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43070?usp=email )
Change subject: V1.2: Change tag in TransferEimPackageResponse
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43070?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I4c9cdd1b79ec22a1d5e36d1720cf5c703890c28b
Gerrit-Change-Number: 43070
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Thu, 23 Jul 2026 10:16:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43069?usp=email )
Change subject: V1.2: Rename field in PSMO
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43069?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I9336f18aaf104629845948877294437188979376
Gerrit-Change-Number: 43069
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Thu, 23 Jul 2026 10:15:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43068?usp=email )
Change subject: V1.2: Rename field in GetBoundProfilePackageResponseEsipa
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43068?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I87965b68bde39d29317f9848aa3a88d9966c4e78
Gerrit-Change-Number: 43068
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Thu, 23 Jul 2026 10:13:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43066?usp=email )
Change subject: V1.2: Add error codes to GetEimPackageResponse
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/ipa/libipa/esipa_get_eim_pkg.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43066/comment/997ab200_557b5092… :
PS1, Line 27: { GetEimPackageResponse__eimPackageError_missingEid, "missingEid" },
strange, eidValue in GetEimPackageRequest is not optional, how can it be missing then?
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43066?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: Ic0cdce1f5269794f37c5da3a63985706a7959184
Gerrit-Change-Number: 43066
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Thu, 23 Jul 2026 09:44:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43065?usp=email )
Change subject: V1.2: Change tag of eimIdType in EimIdInfo
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43065?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: Id96353ef74ffe51aa7de4848832f32e8f58ab4df
Gerrit-Change-Number: 43065
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Thu, 23 Jul 2026 09:39:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes