July 2026 - gerrit-log - lists.osmocom.org

[XS] Change in libosmocore[master]: tests/osmo_io: Remove unused variable
by pespin 27 Jul '26

27 Jul '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/43097?usp=email ) Change subject: tests/osmo_io: Remove unused variable ...................................................................... tests/osmo_io: Remove unused variable gcc 16.1.1 warns about it. Change-Id: I0bdfe5ed6803042277ed8d21171b5f9c11495ca3 --- M tests/osmo_io/osmo_io_backpressure_test.c 1 file changed, 1 insertion(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/97/43097/1 diff --git a/tests/osmo_io/osmo_io_backpressure_test.c b/tests/osmo_io/osmo_io_backpressure_test.c index 69bbb35..87259dc 100644 --- a/tests/osmo_io/osmo_io_backpressure_test.c +++ b/tests/osmo_io/osmo_io_backpressure_test.c @@ -106,7 +106,6 @@ file_bytes_write_compl = 0; char drain_buffer[512]; - int messages_queued = 0; for (int i = 0; i < 10; i++) { /* Add a message */ @@ -114,9 +113,7 @@ memset(msgb_put(msg, 1024), 0xAA + (i % 16), 1024); rc = osmo_iofd_write_msgb(iofd, msg); - if (rc == 0) - messages_queued++; - else + if (rc != 0) msgb_free(msg); /* Process events with explicit timeout */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43097?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0bdfe5ed6803042277ed8d21171b5f9c11495ca3 Gerrit-Change-Number: 43097 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in onomondo-ipa[master]: V1.2: Update from "EnableUsingDD" to "ImmediateEnable" function
by jolly 27 Jul '26

27 Jul '26

Attention is currently required from: dexter. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43025?usp=email ) Change subject: V1.2: Update from "EnableUsingDD" to "ImmediateEnable" function ...................................................................... Patch Set 2: (1 comment) File src/ipa/libipa/proc_prfle_inst.c: https://gerrit.osmocom.org/c/onomondo-ipa/+/43025/comment/2188e0a3_e24fd4e8… : PS1, Line 45: ipa_es10b_immediate_enable(ctx); > (this refers to WIP: Add refreshFlag, read the review comments there first) […] The 'WIP' patch is now changed as discussed and merged with this patch, because it is part of the function update. -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43025?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: Id750b2f5ca6c08a013aa30f876aa37e6291a30d5 Gerrit-Change-Number: 43025 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Jul 2026 11:42:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[L] Change in onomondo-ipa[master]: V1.2: Rename "Automatic" -> "Immediate"
by jolly 27 Jul '26

27 Jul '26

Attention is currently required from: dexter. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43023?usp=email ) Change subject: V1.2: Rename "Automatic" -> "Immediate" ...................................................................... Patch Set 2: (1 comment) File src/ipa/libipa/es10b_euicc_mem_rst.c: https://gerrit.osmocom.org/c/onomondo-ipa/+/43023/comment/537ecac7_0befa639… : PS1, Line 153: if (req->auto_enable_cfg) > Now I see, its renamed in a follow up patch. […] Done -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43023?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I2b18e5cf65269347ce40e5e9560ab934e75a92a6 Gerrit-Change-Number: 43023 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Jul 2026 11:40:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[L] Change in onomondo-ipa[master]: V1.2: Update from "EnableUsingDD" to "ImmediateEnable" function
by jolly 27 Jul '26

27 Jul '26

Attention is currently required from: jolly. Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43025?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: V1.2: Update from "EnableUsingDD" to "ImmediateEnable" function ...................................................................... V1.2: Update from "EnableUsingDD" to "ImmediateEnable" function Rename function to Version 1.2 of ASN.1 specification. A refresh flag can be set via context. Also add a command line option to set the refresh flag. If the immediate enable of an installed profile was requested via PSMO, forward the refresh flag to the eUICC. The eUICC will perform CAT refresh after switching profile. The refresh flag will be used for other profile operations in later patches. Reference: SGP.32 Section 5.9.15 Related: SYS#8101 Change-Id: Id750b2f5ca6c08a013aa30f876aa37e6291a30d5 --- M asn1/SGP32Definitions.asn M src/ipa/libasn/CMakeLists.txt D src/ipa/libasn/EnableUsingDDRequest.c D src/ipa/libasn/EnableUsingDDResponse.c D src/ipa/libasn/EnableUsingDDResponse.h A src/ipa/libasn/ImmediateEnableRequest.c R src/ipa/libasn/ImmediateEnableRequest.h A src/ipa/libasn/ImmediateEnableResponse.c A src/ipa/libasn/ImmediateEnableResponse.h M src/ipa/libipa/CMakeLists.txt M src/ipa/libipa/context.h D src/ipa/libipa/es10b_enable_using_dd.c A src/ipa/libipa/es10b_immediate_enable.c R src/ipa/libipa/es10b_immediate_enable.h M src/ipa/libipa/es10b_load_bnd_prfle_pkg.c M src/ipa/libipa/proc_prfle_inst.c M src/ipa/main.c 17 files changed, 407 insertions(+), 369 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/25/43025/2 -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43025?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: Id750b2f5ca6c08a013aa30f876aa37e6291a30d5 Gerrit-Change-Number: 43025 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu>

1 0

[L] Change in onomondo-ipa[master]: V1.2: Rename "Automatic" -> "Immediate"
by jolly 27 Jul '26

27 Jul '26

Attention is currently required from: dexter, jolly. Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43023?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: V1.2: Rename "Automatic" -> "Immediate" ...................................................................... V1.2: Rename "Automatic" -> "Immediate" Rename all ASN.1 occurrences of "Automatic" or "AutomaticEnable" or similar to "Immediate" or "ImmediateEnable" or similar respectively. Also rename internal structure names from "auto" or similar to "immediate" or similar respectively. Reference: SGP.32 Section 2.9.2 Related: SYS#8101 Change-Id: I2b18e5cf65269347ce40e5e9560ab934e75a92a6 --- M asn1/SGP32Definitions.asn M include/onomondo/ipa/ipad.h M src/ipa/libasn/CMakeLists.txt D src/ipa/libasn/ConfigureAutoEnableResult.c D src/ipa/libasn/ConfigureAutoEnableResult.h D src/ipa/libasn/ConfigureAutoProfileEnablingRequest.c D src/ipa/libasn/ConfigureAutoProfileEnablingRequest.h D src/ipa/libasn/ConfigureAutoProfileEnablingResponse.c D src/ipa/libasn/ConfigureAutoProfileEnablingResponse.h A src/ipa/libasn/ConfigureImmediateEnableResult.c A src/ipa/libasn/ConfigureImmediateEnableResult.h A src/ipa/libasn/ConfigureImmediateProfileEnablingRequest.c A src/ipa/libasn/ConfigureImmediateProfileEnablingRequest.h A src/ipa/libasn/ConfigureImmediateProfileEnablingResponse.c A src/ipa/libasn/ConfigureImmediateProfileEnablingResponse.h M src/ipa/libasn/EnableUsingDDResponse.h M src/ipa/libasn/EuiccResultData.c M src/ipa/libasn/EuiccResultData.h M src/ipa/libasn/Psmo.c M src/ipa/libasn/Psmo.h M src/ipa/libasn/SGP32-EuiccMemoryResetRequest.h M src/ipa/libasn/SGP32-EuiccMemoryResetResponse.c M src/ipa/libasn/SGP32-EuiccMemoryResetResponse.h M src/ipa/libipa/context.h M src/ipa/libipa/es10b_enable_using_dd.c M src/ipa/libipa/es10b_euicc_mem_rst.c M src/ipa/libipa/es10b_euicc_mem_rst.h M src/ipa/libipa/es10b_load_bnd_prfle_pkg.c M src/ipa/libipa/es10b_load_euicc_pkg.c M src/ipa/libipa/ipad.c 30 files changed, 476 insertions(+), 474 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/23/43023/2 -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43023?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I2b18e5cf65269347ce40e5e9560ab934e75a92a6 Gerrit-Change-Number: 43023 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: TCAP: implement fallback routing when no TCAP ASP can be found.
by pespin 27 Jul '26

27 Jul '26

Attention is currently required from: daniel, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008?usp=email ) Change subject: TCAP: implement fallback routing when no TCAP ASP can be found. ...................................................................... Patch Set 3: (5 comments) File src/ss7_as_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/d8484ea1_cee72… : PS3, Line 266: DEFUN_USRATTR(as_tcap_unroutable_route_fallback, as_tcap_unroutable_route_fallback_cmd, It probably make much more sense to have a VTY cmd "tcap-unroutable-sessions route-fallback DPC" instead of extending the previous one and then adding a new extra config which only applies when the former is set. File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/6e40f49b_5be06… : PS3, Line 470: if (as->cfg.loadshare.tcap.unroutable_tcap_fallback_dpc == 0) this is imho incorrect. 0 is a valid DPC afaiu. Maybe add OSMO_ASSERT(as->cfg.loadshare.tcap.unroutable_tcap_msg == SS7_AS_TCAP_UNROUTABLE_LOAD_SHARE_AS) if you want instead. https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/7f194af7_215a0… : PS3, Line 474: new_mtp.opc = orig_mtp->opc; this line is a noop, cam be dropped. https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/750090c0_c998c… : PS3, Line 487: * \return 0 on success and asp is set, < 0 on error, > 0 when message is routed elsewhere I see you are updating the return signature here, but I see no modficiation on any code using the function. As so, is it really needed to make the function more complex? https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/db1bd9c0_d2501… : PS3, Line 508: /* Message is handled and will be routed else where */ elsewhere -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3e4e634b38a1845c2ce62a3805ff91a530520d88 Gerrit-Change-Number: 43008 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 27 Jul 2026 09:10:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in libosmo-sigtran[master]: TCAP: Refactoring unroutable messages into own function
by pespin 27 Jul '26

27 Jul '26

Attention is currently required from: daniel, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43007?usp=email ) Change subject: TCAP: Refactoring unroutable messages into own function ...................................................................... Patch Set 2: (3 comments) File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43007/comment/a870b372_d955f… : PS2, Line 466: static int asp_loadshare_tcap_unroutable(struct osmo_ss7_asp **rasp, asp_loadshare_tcap_unroutable_fallback() may be more descriptive. Otherwise it seems ike you are testing wether a msg is unroutable, which is not really the case here. https://gerrit.osmocom.org/c/libosmo-sigtran/+/43007/comment/c414a3d5_2c81e… : PS2, Line 608: rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_ASP_FALLBACK); AFAIU this patch could be reduce to only adding the following line here: if (!asp) goto out_free_sua; https://gerrit.osmocom.org/c/libosmo-sigtran/+/43007/comment/0dca39ef_0abbd… : PS2, Line 636: rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_ASP_FALLBACK); AFAIU this patch could be reduce to only adding the following line here: if (!asp) goto out_free_sua; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43007?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ib4d114273423730418458767d17b11de9bd815d4 Gerrit-Change-Number: 43007 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 27 Jul 2026 09:01:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in ...osmo_dia2gsup[master]: translate AUTS field in UTRAN as well as E-UTRAN requests
by pespin 27 Jul '26

27 Jul '26

Attention is currently required from: daniel, fixeria, laforge, lynxis lazus, theenbyperor. pespin has posted comments on this change by theenbyperor. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/43096?usp=email ) Change subject: translate AUTS field in UTRAN as well as E-UTRAN requests ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/43096?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: Ie3ecfc668cff50ebdbc190e8384e891e05e7ad27 Gerrit-Change-Number: 43096 Gerrit-PatchSet: 1 Gerrit-Owner: theenbyperor <q(a)magicalcodewit.ch> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: theenbyperor <q(a)magicalcodewit.ch> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 27 Jul 2026 08:38:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in simtrace2[master]: firmware: Implement debug command via USB control vendor class
by pespin 27 Jul '26

27 Jul '26

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43005?usp=email ) Change subject: firmware: Implement debug command via USB control vendor class ...................................................................... Patch Set 8: Code-Review+1 (1 comment) File firmware/libcommon/source/mode_cardemu.c: https://gerrit.osmocom.org/c/simtrace2/+/43005/comment/1a09c2c2_4bb5612d?us… : PS8, Line 710: talloc_report_buf(&info.talloc_blocks, ARRAY_SIZE(info.talloc_report) + 1); "sizeof(info.talloc_blocks) + ARRAY_SIZE(info.talloc_report)" would be more descriptive here, to imply you expect a certain order in memory. -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43005?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I1f4d29335eb0d2feef376b8ecdfe57a0162914d6 Gerrit-Change-Number: 43005 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 27 Jul 2026 08:27:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in simtrace2[master]: firmware: Add talloc_report_buf() encode the allocation by bits
by pespin 27 Jul '26

27 Jul '26

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43004?usp=email ) Change subject: firmware: Add talloc_report_buf() encode the allocation by bits ...................................................................... Patch Set 6: (1 comment) File firmware/libcommon/source/pseudo_talloc.c: https://gerrit.osmocom.org/c/simtrace2/+/43004/comment/e40a9b6c_20bfac26?us… : PS6, Line 101: return bitoff + 1; are you sure the +1 in here is correct? -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43004?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I3a8ddbe4100f342db2c59ad1fb9aa0014efc62b8 Gerrit-Change-Number: 43004 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 27 Jul 2026 08:22:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2026

2025

2024

2023

2022

gerrit-log July 2026