July 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bts[master]: common: stop buffering UL measurements when SACCH is deactivated
by fixeria 27 Jul '26

27 Jul '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/42911?usp=email ) Change subject: common: stop buffering UL measurements when SACCH is deactivated ...................................................................... common: stop buffering UL measurements when SACCH is deactivated When the BSC sends RSL DEACT SACCH, the per-SACCH UL measurement drain stops (it runs on SACCH timing), but the producer in lchan_new_ul_meas() keeps appending the measurement contributions from every received TCH/SDCCH burst. After one SACCH period (104 frames) the 104-slot uplink measurement buffer fills up, yielding a flood of: NOTICE measurement.c:336 no space for uplink measurement, num_ul_meas=104 Add a bool sacch_active flag to gsm_lchan, set to true in the common l1sap_chan_act() and clear in l1sap_chan_deact_sacch(). Guard lchan_new_ul_meas() with this flag so that measurements are silently discarded while SACCH is inactive - there is nothing to drain the buffer and no SACCH channel on which to report the results to the BSC. Change-Id: I3943c788cab5d2411b06ac681d4d412852bac0a7 AI-Assisted: yes (Claude) --- M include/osmo-bts/lchan.h M src/common/l1sap.c M src/common/measurement.c M tests/meas/meas_test.c 4 files changed, 11 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/include/osmo-bts/lchan.h b/include/osmo-bts/lchan.h index 071197d..909768d 100644 --- a/include/osmo-bts/lchan.h +++ b/include/osmo-bts/lchan.h @@ -210,6 +210,7 @@ * want_dl_sacch_active indicates whether dl SACCH should be activated on CHAN ACT. */ bool want_dl_sacch_active; + bool ul_sacch_active; /* UL SACCH measurements active (cleared by RSL DEACT SACCH) */ /* Number of different GsmL1_Sapi_t used in osmo_bts_sysmo is 23. * Currently we don't share these headers so this is a magic number. */ diff --git a/src/common/l1sap.c b/src/common/l1sap.c index f11bb2c..e0d0bba 100644 --- a/src/common/l1sap.c +++ b/src/common/l1sap.c @@ -3013,6 +3013,8 @@ lchan->ts->vamos.is_shadow ? "-shadow" : ""); OSMO_ASSERT(rc == 0); } + + lchan->ul_sacch_active = true; return 0; } @@ -3055,6 +3057,8 @@ LOGPLCHAN(lchan, DL1C, LOGL_INFO, "Deactivating SACCH on channel %s\n", rsl_chan_nr_str(chan_nr)); + lchan->ul_sacch_active = false; + return l1sap_chan_act_dact_modify(trx, chan_nr, PRIM_INFO_DEACTIVATE, 1); } diff --git a/src/common/measurement.c b/src/common/measurement.c index afbdc84..8bb3e6e 100644 --- a/src/common/measurement.c +++ b/src/common/measurement.c @@ -332,6 +332,11 @@ gsm_lchans_name(lchan->state), lchan->meas.num_ul_meas, fn_mod); } + /* No point buffering measurements when SACCH is deactivated: the drain + * runs on SACCH timing, so the buffer would fill up and overflow. */ + if (!lchan->ul_sacch_active) + return 0; + if (lchan->meas.num_ul_meas >= ARRAY_SIZE(lchan->meas.uplink)) { LOGPLCFN(lchan, fn, DMEAS, LOGL_NOTICE, "no space for uplink measurement, num_ul_meas=%d, fn_mod=%u\n", lchan->meas.num_ul_meas, diff --git a/tests/meas/meas_test.c b/tests/meas/meas_test.c index 4c93421..d2b6199 100644 --- a/tests/meas/meas_test.c +++ b/tests/meas/meas_test.c @@ -68,6 +68,7 @@ static void reset_lchan_meas(struct gsm_lchan *lchan) { lchan->state = LCHAN_S_ACTIVE; + lchan->ul_sacch_active = true; memset(&lchan->meas, 0, sizeof(lchan->meas)); } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42911?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3943c788cab5d2411b06ac681d4d412852bac0a7 Gerrit-Change-Number: 42911 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-bts[master]: common: stop buffering UL measurements when SACCH is deactivated
by fixeria 27 Jul '26

27 Jul '26

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42911?usp=email ) Change subject: common: stop buffering UL measurements when SACCH is deactivated ...................................................................... Patch Set 3: Code-Review+2 (1 comment) File tests/meas/meas_test.c: https://gerrit.osmocom.org/c/osmo-bts/+/42911/comment/797cfd84_a51b47dc?usp… : PS3, Line 71: lchan->ul_sacch_active = true; > Because the testcases actually use this function as an initializer, not as a shutdown cleanup helper […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42911?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3943c788cab5d2411b06ac681d4d412852bac0a7 Gerrit-Change-Number: 42911 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Jul 2026 17:11:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: stp: add ASP_SCCP_N_NOTICE_req support and f_asp_tx_notice()
by pespin 27 Jul '26

27 Jul '26

Attention is currently required from: daniel. pespin has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42935?usp=email ) Change subject: stp: add ASP_SCCP_N_NOTICE_req support and f_asp_tx_notice() ...................................................................... Patch Set 2: (1 comment) File stp/STP_Tests_TCAP.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42935/comment/e6081a6a_a1b5… : PS2, Line 222: private function f_asp_tx_notice(template (value) SCCP_PAR_UserData userData, I don't see this function ever being used here nor in current master. What am I missing? why was this added? It needs to be dropped in a new commit. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42935?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I74c05405f1c99d43b4bf863f959275ee51301f2e Gerrit-Change-Number: 42935 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Jul 2026 15:34:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-ttcn3-hacks[master]: deps: use a fork of titan.ProtocolEmulations.SCCP
by pespin 27 Jul '26

27 Jul '26

Attention is currently required from: daniel, fixeria. pespin has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42934?usp=email ) Change subject: deps: use a fork of titan.ProtocolEmulations.SCCP ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > @daniel I fail to see any active PR in https://gitlab.eclipse.org/eclipse/titan/titan. […] @vyanitskiy@sysmocom.de The patch is "SCCP_Emulation: add ASP_SCCP_N_NOTICE_req to send UDTS" https://github.com/osmocom/titan.ProtocolEmulations.SCCP/commit/c6d29978155… and so far looks wrong to me. ITU Q.711 doesn't specify a "N-NOTICE" Request, only an Indication, so we are probably doing something wrong there? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42934?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8c0de4dab088930d5d7a9febcbebcb5e1f9411e8 Gerrit-Change-Number: 42934 Gerrit-PatchSet: 3 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Jul 2026 15:24:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in onomondo-ipa[master]: V1.2: Add EimConfigurationData.indirectProfileDownload
by jolly 27 Jul '26

27 Jul '26

Attention is currently required from: dexter, jolly. Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43029?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: V1.2: Add EimConfigurationData.indirectProfileDownload ...................................................................... V1.2: Add EimConfigurationData.indirectProfileDownload The flag indicates, if eIM supports indirect download. As the current version of IPA only supports indirect download, this flag is checked. If it is not supported, profile download is rejected. get_euicc_ci_pkid() is renamed to get_euicc_ci_pkid_ipd(), to indicate that it also gets this flag. This also requires an update of contrib/sample_eim_cfg.ber, which is a BER encoded EimConfigurationData. Reference: SGP.32 Section 2.11.1.1.1 Related: SYS#8101 Change-Id: Ic40111531e6f35d5ea7f3789de6cae0f1c0d5ba7 --- M asn1/SGP32Definitions.asn M contrib/sample_eim_cfg.ber M src/ipa/libasn/EimConfigurationData.c M src/ipa/libasn/EimConfigurationData.h M src/ipa/libipa/proc_eim_pkg_retr.c 5 files changed, 42 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/29/43029/3 -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43029?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: Ic40111531e6f35d5ea7f3789de6cae0f1c0d5ba7 Gerrit-Change-Number: 43029 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[M] Change in onomondo-ipa[master]: V1.2: Add EimConfigurationData.indirectProfileDownload
by jolly 27 Jul '26

27 Jul '26

Attention is currently required from: dexter. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43029?usp=email ) Change subject: V1.2: Add EimConfigurationData.indirectProfileDownload ...................................................................... Patch Set 2: (1 comment) File src/ipa/libipa/proc_eim_pkg_retr.c: https://gerrit.osmocom.org/c/onomondo-ipa/+/43029/comment/a3e06b3c_4bc6cc96… : PS1, Line 122: "Indirect profile download is not suppoted by eIM, we don't support direct profile download, -- cannot continue!\n"); > Its probably difficult for end users to understand what "we" refers to. […] Done -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43029?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: Ic40111531e6f35d5ea7f3789de6cae0f1c0d5ba7 Gerrit-Change-Number: 43029 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Jul 2026 14:12:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[M] Change in onomondo-ipa[master]: V1.2: Add EimConfigurationData.indirectProfileDownload
by Jenkins Builder 27 Jul '26

27 Jul '26

Attention is currently required from: dexter, jolly. Jenkins Builder has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43029?usp=email ) Change subject: V1.2: Add EimConfigurationData.indirectProfileDownload ...................................................................... Patch Set 2: (1 comment) File src/ipa/libipa/proc_eim_pkg_retr.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-ipa/+/43029/comment/7fba8529_38f406ed… : PS2, Line 122: "Indirect profile download is not suppoted by eIM and this IPAd does not support direct profile download, -- cannot continue!\n"); 'suppoted' may be misspelled - perhaps 'supported'? -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43029?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: Ic40111531e6f35d5ea7f3789de6cae0f1c0d5ba7 Gerrit-Change-Number: 43029 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Jul 2026 14:11:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in onomondo-ipa[master]: V1.2: EuiccResultData.setFallbackAttribute / unsetFallbackAttribute
by jolly 27 Jul '26

27 Jul '26

Attention is currently required from: dexter. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43030?usp=email ) Change subject: V1.2: EuiccResultData.setFallbackAttribute / unsetFallbackAttribute ...................................................................... Patch Set 2: (2 comments) File src/ipa/libipa/es10b_load_euicc_pkg.c: https://gerrit.osmocom.org/c/onomondo-ipa/+/43030/comment/68aba28b_410d8479… : PS1, Line 278: > I would suggest not to pretend that the setFallbackAttribute command was successful. […] I used the result that was specified and fixed the 'present' enumeration. https://gerrit.osmocom.org/c/onomondo-ipa/+/43030/comment/4e6a70ba_8bc60341… : PS1, Line 291: > (see comment above) […] I used the result that was specified and fixed the 'present' enumeration. -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43030?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I59fba32cb12de22f71b3238adcbab5fc7f66e991 Gerrit-Change-Number: 43030 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Jul 2026 14:11:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[L] Change in onomondo-ipa[master]: V1.2: Add setDefaultDpAddress function
by jolly 27 Jul '26

27 Jul '26

Attention is currently required from: dexter. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43031?usp=email ) Change subject: V1.2: Add setDefaultDpAddress function ...................................................................... Patch Set 2: (1 comment) File src/ipa/libipa/es10c_set_def_dp_addr.h: https://gerrit.osmocom.org/c/onomondo-ipa/+/43031/comment/74bcdd5d_47af538a… : PS1, Line 20: > This is correct. However when the input and output parameters are simple, I sometimes use those ASN. […] Done (please check for memory leaks) -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43031?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I514b03240289469142e6a41a7290a4afce199318 Gerrit-Change-Number: 43031 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Jul 2026 14:11:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[L] Change in onomondo-ipa[master]: V1.2: EuiccResultData.setFallbackAttribute / unsetFallbackAttribute
by jolly 27 Jul '26

27 Jul '26

Attention is currently required from: dexter, jolly. Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43030?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: V1.2: EuiccResultData.setFallbackAttribute / unsetFallbackAttribute ...................................................................... V1.2: EuiccResultData.setFallbackAttribute / unsetFallbackAttribute Add setFallbackAttribute and unsetFallbackAttribute to EuiccResultData. The IoT eUICC emulation just acknowledges the operation with a log message and does nothing. A non IoT eUICC does not support fallback. Reference: SGP.32 Section 2.11.1.1.3 Related: SYS#8101 Change-Id: I59fba32cb12de22f71b3238adcbab5fc7f66e991 --- M asn1/SGP32Definitions.asn M src/ipa/libasn/CMakeLists.txt M src/ipa/libasn/EuiccResultData.c M src/ipa/libasn/EuiccResultData.h M src/ipa/libasn/Psmo.c M src/ipa/libasn/Psmo.h A src/ipa/libasn/SetFallbackAttributeResult.c A src/ipa/libasn/SetFallbackAttributeResult.h A src/ipa/libasn/UnsetFallbackAttributeResult.c A src/ipa/libasn/UnsetFallbackAttributeResult.h M src/ipa/libipa/es10b_load_euicc_pkg.c 11 files changed, 377 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/30/43030/2 -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43030?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I59fba32cb12de22f71b3238adcbab5fc7f66e991 Gerrit-Change-Number: 43030 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log July 2026