July 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-hlr[master]: run osmo-hlr as non-root
by osmith 15 Jul '26

15 Jul '26

osmith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/28356?usp=email ) Change subject: run osmo-hlr as non-root ...................................................................... Abandoned https://gerrit.osmocom.org/c/osmo-hlr/+/29311 was merged instead -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/28356?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I2a51c0242fd109270d5b0326f68ee80082021061 Gerrit-Change-Number: 28356 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder

1 0

[S] Change in osmo-hlr[master]: systemd: run db-upgrade script in ExecStartPre
by osmith 15 Jul '26

15 Jul '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/43010?usp=email ) Change subject: systemd: run db-upgrade script in ExecStartPre ...................................................................... systemd: run db-upgrade script in ExecStartPre We have seen in CI jobs that calling the DB upgrade script from debian/postinst does not work reliably. When doing a fresh install of osmo-hlr, it usually works as expected: Setting up osmo-hlr (1.9.2) ... osmo-hlr-post-upgrade: nothing to do (no existing database) But sometimes: Setting up osmo-hlr (1.9.2) ... osmo-hlr-post-upgrade: database upgrade is required osmo-hlr-post-upgrade: stopping osmo-hlr service osmo-hlr-post-upgrade: creating backup: /var/lib/osmocom/hlr.db.20260706135658.bak osmo-hlr-post-upgrade: performing database upgrade <0001> db.c:600 using database: /var/lib/osmocom/hlr.db <0001> db.c:103 (283) recovered 4 frames from WAL file /var/lib/osmocom/hlr.db-wal <0001> db.c:679 Database '/var/lib/osmocom/hlr.db' has HLR DB schema version 0 <0001> db.c:103 (1) duplicate column name: last_lu_seen in "ALTER TABLE subscriber ADD COLUMN last_lu_seen TIMESTAMP default NULL" <0001> db.c:248 Unable to prepare SQL statement 'ALTER TABLE subscriber ADD COLUMN last_lu_seen TIMESTAMP default NULL' <0001> db.c:318 Unable to update HLR database schema to version 1 <0001> db.c:685 Failed to upgrade HLR DB schema to version 1: (rc=1) duplicate column name: last_lu_seen <0000> hlr_db_tool.c:509 Error opening database It seems that osmo-hlr can get started before the osmo-hlr-post-upgrade script runs, then starts to create the database with the current schema, and gets stopped before it is done, leading to the failure above. Rename the script to osmo-hlr-db-upgrade.sh, remove logic for stopping and starting the service and let systemd call it in ExecStartPre. That way we are sure that it runs *before* osmo-hlr starts up. Related: SYS#8125 Change-Id: If13f4c8b49397e6630956e92a7825843c7d55ebd --- M contrib/Makefile.am R contrib/osmo-hlr-db-upgrade.sh M contrib/systemd/osmo-hlr.service M debian/osmo-hlr.install M debian/postinst 5 files changed, 6 insertions(+), 41 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/10/43010/1 diff --git a/contrib/Makefile.am b/contrib/Makefile.am index 37c4aa4..fa3f1a2 100644 --- a/contrib/Makefile.am +++ b/contrib/Makefile.am @@ -3,12 +3,12 @@ dgsm \ $(NULL) -EXTRA_DIST = osmo-hlr-post-upgrade.sh +EXTRA_DIST = osmo-hlr-db-upgrade.sh install-data-hook: - install -Dm755 $(srcdir)/osmo-hlr-post-upgrade.sh \ + install -Dm755 $(srcdir)/osmo-hlr-db-upgrade.sh \ -t $(DESTDIR)$(datadir)/osmocom/ uninstall-hook: @$(PRE_UNINSTALL) - $(RM) $(DESTDIR)$(datadir)/osmocom/osmo-hlr-post-upgrade.sh + $(RM) $(DESTDIR)$(datadir)/osmocom/osmo-hlr-db-upgrade.sh diff --git a/contrib/osmo-hlr-post-upgrade.sh b/contrib/osmo-hlr-db-upgrade.sh similarity index 68% rename from contrib/osmo-hlr-post-upgrade.sh rename to contrib/osmo-hlr-db-upgrade.sh index eaef417..ff1eef8 100644 --- a/contrib/osmo-hlr-post-upgrade.sh +++ b/contrib/osmo-hlr-db-upgrade.sh @@ -6,10 +6,9 @@ # upgrade the database scheme if required. DB="/var/lib/osmocom/hlr.db" -IS_ACTIVE=0 msg() { - echo "osmo-hlr-post-upgrade: $@" + echo "osmo-hlr-db-upgrade: $@" } err() { @@ -36,27 +35,6 @@ msg "database upgrade is required" } -stop_service() { - if systemctl is-active -q osmo-hlr; then - IS_ACTIVE=1 - msg "stopping osmo-hlr service" - systemctl stop osmo-hlr - - # Verify that it stopped - for i in $(seq 1 100); do - if ! systemctl is-active -q osmo-hlr; then - return - fi - sleep 0.1 - done - - err "failed to stop osmo-hlr service" - exit 1 - else - msg "osmo-hlr service is not running" - fi -} - create_backup() { backup="$DB.$(date +%Y%m%d%H%M%S).bak" msg "creating backup: $backup" @@ -81,15 +59,6 @@ msg "database upgrade successful" } -start_service() { - if [ "$IS_ACTIVE" = "1" ]; then - msg "starting osmo-hlr service" - systemctl start osmo-hlr - fi -} - check_upgrade_required -stop_service create_backup upgrade -start_service diff --git a/contrib/systemd/osmo-hlr.service b/contrib/systemd/osmo-hlr.service index 2822f13..a28a989 100644 --- a/contrib/systemd/osmo-hlr.service +++ b/contrib/systemd/osmo-hlr.service @@ -11,6 +11,7 @@ WorkingDirectory=%S/osmocom User=osmocom Group=osmocom +ExecStartPre=/usr/share/osmocom/osmo-hlr-db-upgrade.sh ExecStart=/usr/bin/osmo-hlr -c /etc/osmocom/osmo-hlr.cfg -l /var/lib/osmocom/hlr.db RestartSec=2 ProtectHome=true diff --git a/debian/osmo-hlr.install b/debian/osmo-hlr.install index 7c8c398..bb13183 100644 --- a/debian/osmo-hlr.install +++ b/debian/osmo-hlr.install @@ -6,4 +6,4 @@ /usr/share/doc/osmo-hlr/sql/hlr_data.sql /usr/share/doc/osmo-hlr/examples/osmo-hlr.cfg /usr/share/doc/osmo-hlr/examples/osmo-hlr-dgsm.cfg -/usr/share/osmocom/osmo-hlr-post-upgrade.sh +/usr/share/osmocom/osmo-hlr-db-upgrade.sh diff --git a/debian/postinst b/debian/postinst index 34fb79d..327ba00 100755 --- a/debian/postinst +++ b/debian/postinst @@ -1,9 +1,4 @@ #!/bin/sh -e -# Debian's postinst script is called on both installation and upgrade. Call the -# post-upgrade script in both cases, it won't do anything if there is nothing -# to do. -/usr/share/osmocom/osmo-hlr-post-upgrade.sh - case "$1" in configure) # Create the osmocom group and user (if it doesn't exist yet) -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/43010?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: If13f4c8b49397e6630956e92a7825843c7d55ebd Gerrit-Change-Number: 43010 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in simtrace2[master]: firmware: Add talloc_report_buf() encode the allocation by bits
by lynxis lazus 14 Jul '26

14 Jul '26

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43004?usp=email ) Change subject: firmware: Add talloc_report_buf() encode the allocation by bits ...................................................................... Patch Set 4: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43004?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I3a8ddbe4100f342db2c59ad1fb9aa0014efc62b8 Gerrit-Change-Number: 43004 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 14 Jul 2026 16:26:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in simtrace2[master]: firmware: Drop CEMU_TX_DATA when sim is in-active
by lynxis lazus 14 Jul '26

14 Jul '26

Attention is currently required from: laforge. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43003?usp=email ) Change subject: firmware: Drop CEMU_TX_DATA when sim is in-active ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: @laforge@osmocom.org I'm unsure if a silent drop is the right way here. Should the simtrace report an error message it dropped a PDU? -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43003?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I796e548225a742cddfde12bd6a60e4d2e5c04c8f Gerrit-Change-Number: 43003 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 14 Jul 2026 16:26:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in simtrace2[master]: firmware: Drop CEMU_TX_DATA when sim is in-active
by lynxis lazus 14 Jul '26

14 Jul '26

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43003?usp=email ) Change subject: firmware: Drop CEMU_TX_DATA when sim is in-active ...................................................................... Patch Set 4: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43003?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I796e548225a742cddfde12bd6a60e4d2e5c04c8f Gerrit-Change-Number: 43003 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 14 Jul 2026 16:25:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in simtrace2[master]: firmware: card_emu.h: declare usb_buf_upd_len_and_submit()
by lynxis lazus 14 Jul '26

14 Jul '26

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43002?usp=email ) Change subject: firmware: card_emu.h: declare usb_buf_upd_len_and_submit() ...................................................................... Patch Set 3: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43002?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I734d4b2d782223dd2f735f140d8c9bc6fc00a086 Gerrit-Change-Number: 43002 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 14 Jul 2026 16:25:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in simtrace2[master]: README.md: describe the debug uart
by lynxis lazus 14 Jul '26

14 Jul '26

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43000?usp=email ) Change subject: README.md: describe the debug uart ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43000?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I4cf929fded962e7ffb4c01628279385b2af04157 Gerrit-Change-Number: 43000 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 14 Jul 2026 16:25:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in simtrace2[master]: firmware: card_emu.h: add missing header stdbool.h.
by lynxis lazus 14 Jul '26

14 Jul '26

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43001?usp=email ) Change subject: firmware: card_emu.h: add missing header stdbool.h. ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43001?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I4ad6d5cf0b4477cbd5f761d70c4cd92fb3ca1fcd Gerrit-Change-Number: 43001 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 14 Jul 2026 16:24:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in simtrace2[master]: README.md: fix typo in firmware
by lynxis lazus 14 Jul '26

14 Jul '26

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/42999?usp=email ) Change subject: README.md: fix typo in firmware ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/42999?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I16721418fce55322c8730920ceaa4e65f91a8a7e Gerrit-Change-Number: 42999 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 14 Jul 2026 16:23:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in osmo-ttcn3-hacks[master]: stp: Add TCAP_N_NOTICE_req to send a UDTS with TCAP payload
by daniel 14 Jul '26

14 Jul '26

daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42936?usp=email ) Change subject: stp: Add TCAP_N_NOTICE_req to send a UDTS with TCAP payload ...................................................................... stp: Add TCAP_N_NOTICE_req to send a UDTS with TCAP payload Change-Id: Ie13cecc2f2fc8a20d9646f0fb010b91c2ecf7766 --- M library/tcap/TCAP_CodecPort.ttcn 1 file changed, 30 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified daniel: Looks good to me, approved diff --git a/library/tcap/TCAP_CodecPort.ttcn b/library/tcap/TCAP_CodecPort.ttcn index 5bec2c4..d2ad994 100644 --- a/library/tcap/TCAP_CodecPort.ttcn +++ b/library/tcap/TCAP_CodecPort.ttcn @@ -241,6 +241,25 @@ importance := * } +type record TCAP_N_NOTICE_req +{ + SCCP_PAR_Address calledAddress , + SCCP_PAR_Address callingAddress , + SCCP_PAR_Reason_For_Return reasonForReturn , + TCMessage userData , + SCCP_PAR_Importance importance optional +} + +template (value) TCAP_N_NOTICE_req ts_TCAP_N_NOTICE_req(SCCP_PAR_Address called, + SCCP_PAR_Address calling, + template (value) SCCP_PAR_Reason_For_Return reason, + template (value) TCMessage payload) := { + calledAddress := called, + callingAddress := calling, + reasonForReturn := reason, + userData := payload, + importance := omit +} private function f_dec_ConnectInd(in ASP_SCCP_N_CONNECT_ind pin, out TCAP_N_CONNECT_ind pout) { pout.calledAddress := pin.calledAddress; @@ -370,12 +389,22 @@ //port.setstate(0); } with {extension "prototype(fast)" } +private function f_enc_NoticeReq(in TCAP_N_NOTICE_req pin, out ASP_SCCP_N_NOTICE_req pout) { + pout.calledAddress := pin.calledAddress; + pout.callingAddress := pin.callingAddress; + pout.reasonForReturn := pin.reasonForReturn; + pout.userData := enc_TCAP_TCMessage(pin.userData); + pout.importance := pin.importance; + //port.setstate(0); +} with {extension "prototype(fast)" } + type port TCAP_CODEC_PT message { out TCAP_N_CONNECT_req, TCAP_N_CONNECT_res, TCAP_N_DATA_req, TCAP_N_DISCONNECT_req, TCAP_N_UNITDATA_req, + TCAP_N_NOTICE_req, ASP_SCCP_N_RESET_req, ASP_SCCP_N_NOTICE_req; in TCAP_N_CONNECT_ind, @@ -394,6 +423,7 @@ TCAP_N_DATA_req -> ASP_SCCP_N_DATA_req: function(f_enc_DataReq); TCAP_N_DISCONNECT_req -> ASP_SCCP_N_DISCONNECT_req: function(f_enc_DisconnectReq); TCAP_N_UNITDATA_req -> ASP_SCCP_N_UNITDATA_req: function(f_enc_UnitdataReq); + TCAP_N_NOTICE_req -> ASP_SCCP_N_NOTICE_req: function(f_enc_NoticeReq); ASP_SCCP_N_RESET_req -> ASP_SCCP_N_RESET_req: simple; ASP_SCCP_N_NOTICE_req -> ASP_SCCP_N_NOTICE_req: simple) in(ASP_SCCP_N_CONNECT_ind -> TCAP_N_CONNECT_ind: function(f_dec_ConnectInd); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42936?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie13cecc2f2fc8a20d9646f0fb010b91c2ecf7766 Gerrit-Change-Number: 42936 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

2026

2025

2024

2023

2022

gerrit-log July 2026