July 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-trx[master]: libosmo-trx/ep: flush pending TRXC messages on endpoint teardown
by pespin 28 Jul '26

28 Jul '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43112?usp=email ) Change subject: libosmo-trx/ep: flush pending TRXC messages on endpoint teardown ...................................................................... Patch Set 1: (1 comment) File libosmo-trx/src/trx_ep.c: https://gerrit.osmocom.org/c/osmo-trx/+/43112/comment/4839803a_419d92b7?usp… : PS1, Line 353: /*! Close all sockets of the given endpoint. See osmo-pcap.git src/osmo_pcap_wr_file.c, osmo_pcap_wr_file_set_flush_completed_cb(), osmo_pcap_wr_file_is_flushing(), osmo_pcap_wr_file_flush(), etc. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43112?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I69e6a3bcf49afc3cfca4a72afdf459625cb91e56 Gerrit-Change-Number: 43112 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jul 2026 11:26:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in osmo-trx[master]: libosmo-trx/ep: add TRX endpoint module
by pespin 28 Jul '26

28 Jul '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43111?usp=email ) Change subject: libosmo-trx/ep: add TRX endpoint module ...................................................................... Patch Set 1: (4 comments) File libosmo-trx/include/osmocom/trx/ep.h: https://gerrit.osmocom.org/c/osmo-trx/+/43111/comment/8209a7f2_c432ddb6?usp… : PS1, Line 27: struct osmo_trx_ep_cfg { Let's please have separate setter functions for all these, like osmo_stream, so we don't need to break ABI in the future. File libosmo-trx/src/trx_ep.c: https://gerrit.osmocom.org/c/osmo-trx/+/43111/comment/dd48d19b_8fc72c33?usp… : PS1, Line 60: uint8_t pdu_ver; /* TRXD PDU version in use */ iirc PDU VER stuff is defined/envisioned only for TRX0, so this can be moved to struct osmo_trx_ep. https://gerrit.osmocom.org/c/osmo-trx/+/43111/comment/896192e5_e31a77da?usp… : PS1, Line 70: struct osmo_trx_ep_chan *chans; /* array of cfg.num_chans channels */ If the chans array is allocated at the end of the struct, it probably makes sense to use "struct osmo_trx_ep_chan chans[]" here? https://gerrit.osmocom.org/c/osmo-trx/+/43111/comment/ab46a500_80719b45?usp… : PS1, Line 302: ep->chans = talloc_zero_array(ep, struct osmo_trx_ep_chan, cfg->num_chans); Ah I see you are allocating the array here as a pointer to a seaprate memory region. It probably makes sense to allocate it at the end just by defining it with the array [0] (see comment at the start of the file), and then doing: ep = talloc_zero(ctx, sizeof(struct osmo_trx_ep) + sizeof(struct osmo_trx_ep_chan) * cfg->num_chans); This way you avoid fragmenting memory and probably already preload mem cache of the channels, which may be useful here for performance of trxd. Up to you. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43111?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I767fa43a9ca88be40c385f6dcb9de22891a6afc3 Gerrit-Change-Number: 43111 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jul 2026 11:24:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-trx[master]: libosmo-trx/client: make public API operate on parsed messages
by pespin 28 Jul '26

28 Jul '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43110?usp=email ) Change subject: libosmo-trx/client: make public API operate on parsed messages ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43110?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Idf53513d06be2337383601494b225b5722c93129 Gerrit-Change-Number: 43110 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jul 2026 11:08:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-trx[master]: libosmo-trx/client: add optional limit for retransmissions
by pespin 28 Jul '26

28 Jul '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43109?usp=email ) Change subject: libosmo-trx/client: add optional limit for retransmissions ...................................................................... Patch Set 1: (1 comment) File libosmo-trx/src/trxc_client.c: https://gerrit.osmocom.org/c/osmo-trx/+/43109/comment/065f1e76_ed3cefcb?usp… : PS1, Line 118: LOGCL(client, LOGL_NOTICE, "No response from transceiver for '" CMD_NAME_FMT "'\n", log e->n_retrans here. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43109?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ib90a032b38c69ae26023e726992d3f5f7e502fcf Gerrit-Change-Number: 43109 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jul 2026 11:05:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XL] Change in osmo-trx[master]: libosmo-trx/client: add TRXC client (command queue) API
by pespin 28 Jul '26

28 Jul '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43108?usp=email ) Change subject: libosmo-trx/client: add TRXC client (command queue) API ...................................................................... Patch Set 1: (4 comments) File libosmo-trx/include/osmocom/trx/trxc_client.h: https://gerrit.osmocom.org/c/osmo-trx/+/43108/comment/7ee841b0_1d42ce2b?usp… : PS1, Line 32: struct osmo_trxc_client_ops { I'd rather add APIs to set each callbacks and private pointers, as done in osmo_stream, to allow for future extensions more easily. File libosmo-trx/src/trxc_client.c: https://gerrit.osmocom.org/c/osmo-trx/+/43108/comment/abf617ca_0c65a80c?usp… : PS1, Line 190: void osmo_trxc_client_set_retrans(struct osmo_trxc_client *client, unsigned int sec) set_restrans_timeout?Is 0 allowed? document it and if not allowed return an error. https://gerrit.osmocom.org/c/osmo-trx/+/43108/comment/f9eb6ba4_d5d43498?usp… : PS1, Line 267: void osmo_trxc_client_flush(struct osmo_trxc_client *client) See osmo-pcap.git src/osmo_pcap_wr_file.c on how to accomplish it, eg. osmo_pcap_wr_file_flush(), osmo_pcap_wr_file_set_flush_completed_cb(), etc. https://gerrit.osmocom.org/c/osmo-trx/+/43108/comment/98bb68ed_e44784a9?usp… : PS1, Line 481: client->setformat_ver_req = ver_max; I'd rather store the user cb + cb_data in a struct, pass it to osmo_trxc_client_send_cmd() below instead of NULL, and free in setformat_rsp_cb(), to avoid several calls to osmo_trxc_client_negotiate_format() tweak the pointer. This way each call has its proper cmd+resp callbck. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43108?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I817e394f74a10e3adae4a0b58342c82acdf0794e Gerrit-Change-Number: 43108 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jul 2026 11:01:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in osmo-trx[master]: libosmo-trx/trxc: add SETSLOT parameter parser/builder
by pespin 28 Jul '26

28 Jul '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43107?usp=email ) Change subject: libosmo-trx/trxc: add SETSLOT parameter parser/builder ...................................................................... Patch Set 1: (1 comment) File libosmo-trx/include/osmocom/trx/trxc.h: https://gerrit.osmocom.org/c/osmo-trx/+/43107/comment/51372d63_a0244d7c?usp… : PS1, Line 68: /* SETSLOT: "<tn> <chan_comb> [C<tsc>/S<tsc_set> ...]" */ It probably makes sense to put all this before the IND CLOCK stuff above, which is a separate socket/connection. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43107?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I17a1176b1418edd0caf750d50acda0482d4ad04a Gerrit-Change-Number: 43107 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jul 2026 10:46:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-trx[master]: libosmo-trx/trxc: enlarge the params buffer
by pespin 28 Jul '26

28 Jul '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43106?usp=email ) Change subject: libosmo-trx/trxc: enlarge the params buffer ...................................................................... Patch Set 1: (1 comment) File libosmo-trx/include/osmocom/trx/trxc.h: https://gerrit.osmocom.org/c/osmo-trx/+/43106/comment/ea6746d3_7f89ca0e?usp… : PS1, Line 16: #define OSMO_TRXC_PARAMS_LEN_MAX (OSMO_TRXC_MSG_BUF_SIZE - OSMO_TRXC_CMD_LEN_MAX - 32) The -32 here is to account for whitespace? -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43106?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I2f65b213f5ada499eea4abae87d3727057e03e22 Gerrit-Change-Number: 43106 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jul 2026 10:42:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-trx[master]: libosmo-trx/trxd: support NOPE.{ind,req} in TRXDv0/v1 PDUs
by pespin 28 Jul '26

28 Jul '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43105?usp=email ) Change subject: libosmo-trx/trxd: support NOPE.{ind,req} in TRXDv0/v1 PDUs ...................................................................... Patch Set 1: (1 comment) File libosmo-trx/src/trxd.c: https://gerrit.osmocom.org/c/osmo-trx/+/43105/comment/05cf9169_ee718553?usp… : PS1, Line 470: return buf_len; don't you need to set "br->burst_len = 0" here before returning? -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43105?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I1a59f31d0f00c8509a016dc2bac71b6aa467f3a4 Gerrit-Change-Number: 43105 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jul 2026 10:40:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-trx[master]: tests: speed up InterthreadTest by shrinking the fuzz sleep
by pespin 28 Jul '26

28 Jul '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43103?usp=email ) Change subject: tests: speed up InterthreadTest by shrinking the fuzz sleep ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43103?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Id6bc453f9217ae392dcd3288dfa6784c533f8eb6 Gerrit-Change-Number: 43103 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jul 2026 10:16:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: deps: Update nas.git to rebased branch on top of v1.2.1
by osmith 28 Jul '26

28 Jul '26

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43118?usp=email ) Change subject: deps: Update nas.git to rebased branch on top of v1.2.1 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43118?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I731c37324de93fe2bf35dac7e64304fc5057ee5f Gerrit-Change-Number: 43118 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jul 2026 10:02:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log July 2026