July 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: ruff: ignore new failing default rules
by osmith 28 Jul '26

28 Jul '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43119?usp=email ) Change subject: ruff: ignore new failing default rules ...................................................................... ruff: ignore new failing default rules With the new ruff 0.16 version, a lot of new default rules have been added. Ignore the ones that are failing for now to make the linter pass again. Related: https://astral.sh/blog/ruff-v0.16.0#better-default-rule-set Change-Id: If95dc72c1826b4b96961453b2c2ed1d2c81ba149 --- M .ruff.toml 1 file changed, 23 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/19/43119/1 diff --git a/.ruff.toml b/.ruff.toml index ad8c0b5..ad4de47 100644 --- a/.ruff.toml +++ b/.ruff.toml @@ -2,3 +2,26 @@ exclude = [ "compare-results.py", ] + +[lint] +ignore = [ + "B006", + "B026", + "BLE001", + "DTZ001", + "DTZ004", + "DTZ005", + "DTZ007", + "FURB105", + "I001", + "LOG015", + "PIE808", + "PLC0206", + "PLW0602", + "PLW1510", + "RUF012", + "SIM102", + "SIM103", + "SIM118", + "UP032", +] -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43119?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If95dc72c1826b4b96961453b2c2ed1d2c81ba149 Gerrit-Change-Number: 43119 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[L] Change in onomondo-ipa[master]: V1.2: Add new fields to ProfileInfo list
by jolly 28 Jul '26

28 Jul '26

Attention is currently required from: dexter. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43032?usp=email ) Change subject: V1.2: Add new fields to ProfileInfo list ...................................................................... Patch Set 4: (1 comment) File src/ipa/libipa/es10c_get_prfle_info.c: https://gerrit.osmocom.org/c/onomondo-ipa/+/43032/comment/f0b97130_0556fe56… : PS1, Line 116: memcpy(conv_req, req, sizeof(struct ipa_es10c_get_prfle_info_req)); > somewhere below here is a heap-buffer-overflow, you can provoke it by using the current eIM (pmaier/ […] Fixed and tested. -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43032?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I6667dba8dd84817cfee69daa1c44b98239fa171c Gerrit-Change-Number: 43032 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jul 2026 12:04:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[L] Change in onomondo-ipa[master]: V1.2: Add new fields to ProfileInfo list
by jolly 28 Jul '26

28 Jul '26

Attention is currently required from: dexter, jolly. Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43032?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: V1.2: Add new fields to ProfileInfo list ...................................................................... V1.2: Add new fields to ProfileInfo list Add new tags for ecallIndication, fallbackAttribute and fallbackAllowed. They new are not supported by non IoT eUICC. The IoT eUICC emulation will remove the unsupported tags from the ProfileInfoListRequest and later adds the requested fields to the ProfileInfoListResponse with the value 'false'. Reference SGP.32 Section 2.11.1.1.3 Related: SYS#8101 Change-Id: I6667dba8dd84817cfee69daa1c44b98239fa171c --- M asn1/SGP32Definitions.asn M src/ipa/libasn/CMakeLists.txt A src/ipa/libasn/SGP32-ProfileInfo.c A src/ipa/libasn/SGP32-ProfileInfo.h M src/ipa/libasn/SGP32-ProfileInfoListResponse.c M src/ipa/libasn/SGP32-ProfileInfoListResponse.h M src/ipa/libipa/es10c_get_prfle_info.c M src/ipa/libipa/es10c_get_prfle_info.h 8 files changed, 666 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/32/43032/4 -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43032?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I6667dba8dd84817cfee69daa1c44b98239fa171c Gerrit-Change-Number: 43032 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[L] Change in onomondo-ipa[master]: V1.2: Add new fields to ProfileInfo list
by Jenkins Builder 28 Jul '26

28 Jul '26

Attention is currently required from: dexter, jolly. Jenkins Builder has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43032?usp=email ) Change subject: V1.2: Add new fields to ProfileInfo list ...................................................................... Patch Set 3: (1 comment) File src/ipa/libipa/es10c_get_prfle_info.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-ipa/+/43032/comment/bacbaef2_79466ce3… : PS3, Line 78: if (conv_req && conv_req->fallback_attribute_removed) { braces {} are not necessary for single statement blocks -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43032?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I6667dba8dd84817cfee69daa1c44b98239fa171c Gerrit-Change-Number: 43032 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jul 2026 12:00:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in onomondo-ipa[master]: V1.2: Add new fields to ProfileInfo list
by jolly 28 Jul '26

28 Jul '26

Attention is currently required from: dexter, jolly. Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43032?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: V1.2: Add new fields to ProfileInfo list ...................................................................... V1.2: Add new fields to ProfileInfo list Add new tags for ecallIndication, fallbackAttribute and fallbackAllowed. They new are not supported by non IoT eUICC. The IoT eUICC emulation will remove the unsupported tags from the ProfileInfoListRequest and later adds the requested fields to the ProfileInfoListResponse with the value 'false'. Reference SGP.32 Section 2.11.1.1.3 Related: SYS#8101 Change-Id: I6667dba8dd84817cfee69daa1c44b98239fa171c --- M asn1/SGP32Definitions.asn M src/ipa/libasn/CMakeLists.txt A src/ipa/libasn/SGP32-ProfileInfo.c A src/ipa/libasn/SGP32-ProfileInfo.h M src/ipa/libasn/SGP32-ProfileInfoListResponse.c M src/ipa/libasn/SGP32-ProfileInfoListResponse.h M src/ipa/libipa/es10c_get_prfle_info.c M src/ipa/libipa/es10c_get_prfle_info.h 8 files changed, 667 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/32/43032/3 -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43032?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I6667dba8dd84817cfee69daa1c44b98239fa171c Gerrit-Change-Number: 43032 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in osmo-trx[master]: Transceiver52M: make TRXDv2 burst batching configurable
by pespin 28 Jul '26

28 Jul '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43117?usp=email ) Change subject: Transceiver52M: make TRXDv2 burst batching configurable ...................................................................... Patch Set 1: (1 comment) File CommonLibs/trx_vty.c: https://gerrit.osmocom.org/c/osmo-trx/+/43117/comment/4ab97809_bb9e0699?usp… : PS1, Line 649: "trxd-batch (disable|enable)", trxd-pdu-batch ? "trxd batch" sounds too generic to me. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43117?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I2f58f87d85de5254bae6d7a606dffcd0ad4069d5 Gerrit-Change-Number: 43117 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jul 2026 11:50:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-trx[master]: Transceiver52M: implement TRXDv2 support
by pespin 28 Jul '26

28 Jul '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43116?usp=email ) Change subject: Transceiver52M: implement TRXDv2 support ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/43116/comment/ee587980_a1a089e1?usp… : PS1, Line 1200: } while (br.flags & OSMO_TRXD_F_BATCH_IND); I wonder whether we can end in a infinite loop here with req_parse returning eg. rc=0 above. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43116?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ie6a33e3980b3ca4ab05a3d4221d5a8ba0132233d Gerrit-Change-Number: 43116 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jul 2026 11:48:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[L] Change in osmo-trx[master]: Transceiver52M: migrate to libosmo-trx
by pespin 28 Jul '26

28 Jul '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43115?usp=email ) Change subject: Transceiver52M: migrate to libosmo-trx ...................................................................... Patch Set 1: (5 comments) Patchset: PS1: I think I'll wait to see if you can split this commit into smaller chunks. File Transceiver52M/Makefile.am: https://gerrit.osmocom.org/c/osmo-trx/+/43115/comment/ef46fdd7_30324bc5?usp… : PS1, Line 100: $(top_builddir)/libosmo-trx/src/libosmotrx.la \ Let's better put this above the LIBOSMOCORE_LIBS, since this in not only osmo-trx specific library code. File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/43115/comment/9e5b2cf8_0035c17a?usp… : PS1, Line 660: /* Convert a soft bit normalized to 0..1 (1.0 = confident '1') into the I wonder where this change come from. Could it be possible to move this to a previous preparation commit? https://gerrit.osmocom.org/c/osmo-trx/+/43115/comment/8a490c99_a5a7e444?usp… : PS1, Line 695: float soft_bits[OSMO_TRXD_BURST_LEN_MAX]; this can also probably be split onto the mentioned previous preparation patch? https://gerrit.osmocom.org/c/osmo-trx/+/43115/comment/1c20bbaa_bf27312f?usp… : PS1, Line 801: bi->toa256 = (int16_t) lround(ebp.toa * 256.0); I see tons of changes in how the bi fields are being set, do you mind explaining why? Can this be done in a seaprate previous commit? -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43115?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I458ec85c56e2101d073c8c35f11c147191c4ea0c Gerrit-Change-Number: 43115 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jul 2026 11:41:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-trx[master]: debian: add packaging for libosmo-trx
by pespin 28 Jul '26

28 Jul '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43114?usp=email ) Change subject: debian: add packaging for libosmo-trx ...................................................................... Patch Set 1: (1 comment) File debian/control: https://gerrit.osmocom.org/c/osmo-trx/+/43114/comment/f43951f7_2eafc17c?usp… : PS1, Line 58: libosmotrx0 (= ${binary:Version}) I find it utterly distrubing that we name it libosmo-trx in some places and libosmotrx in some others. Please use libosmo-trx everywhere. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43114?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I56f0074ad121ecacb076b508d1adfdd71cce99ec Gerrit-Change-Number: 43114 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jul 2026 11:34:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XL] Change in osmo-trx[master]: libosmo-trx: generate Doxygen API documentation
by pespin 28 Jul '26

28 Jul '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43113?usp=email ) Change subject: libosmo-trx: generate Doxygen API documentation ...................................................................... Patch Set 1: (1 comment) File libosmo-trx/src/trxc.c: https://gerrit.osmocom.org/c/osmo-trx/+/43113/comment/e445982b_66f9bea7?usp… : PS1, Line 171: * \param[in] buf message buffer (not necessarily zero-terminated) I think we can squash this change into a previous commit? -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43113?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I54cf8c0c60215c666d8fa55dafec53379a2382d5 Gerrit-Change-Number: 43113 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jul 2026 11:32:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2026

2025

2024

2023

2022

gerrit-log July 2026