Attention is currently required from: fixeria.

pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43115?usp=email )

Change subject: Transceiver52M: migrate to libosmo-trx ......................................................................

Patch Set 1:

(5 comments)

Patchset:

PS1: I think I'll wait to see if you can split this commit into smaller chunks.

File Transceiver52M/Makefile.am:

https://gerrit.osmocom.org/c/osmo-trx/+/43115/comment/ef46fdd7_30324bc5?usp=... : PS1, Line 100: $(top_builddir)/libosmo-trx/src/libosmotrx.la \ Let's better put this above the LIBOSMOCORE_LIBS, since this in not only osmo-trx specific library code.

File Transceiver52M/Transceiver.cpp:

https://gerrit.osmocom.org/c/osmo-trx/+/43115/comment/9e5b2cf8_0035c17a?usp=... : PS1, Line 660: /* Convert a soft bit normalized to 0..1 (1.0 = confident '1') into the I wonder where this change come from. Could it be possible to move this to a previous preparation commit?

https://gerrit.osmocom.org/c/osmo-trx/+/43115/comment/8a490c99_a5a7e444?usp=... : PS1, Line 695: float soft_bits[OSMO_TRXD_BURST_LEN_MAX]; this can also probably be split onto the mentioned previous preparation patch?

https://gerrit.osmocom.org/c/osmo-trx/+/43115/comment/1c20bbaa_bf27312f?usp=... : PS1, Line 801: bi->toa256 = (int16_t) lround(ebp.toa * 256.0); I see tons of changes in how the bi fields are being set, do you mind explaining why? Can this be done in a seaprate previous commit?