Attention is currently required from: fixeria.
5 comments:
Patchset:
I think I'll wait to see if you can split this commit into smaller chunks.
File Transceiver52M/Makefile.am:
Patch Set #1, Line 100: $(top_builddir)/libosmo-trx/src/libosmotrx.la \
Let's better put this above the LIBOSMOCORE_LIBS, since this in not only osmo-trx specific library code.
File Transceiver52M/Transceiver.cpp:
Patch Set #1, Line 660: /* Convert a soft bit normalized to 0..1 (1.0 = confident '1') into the
I wonder where this change come from. Could it be possible to move this to a previous preparation commit?
Patch Set #1, Line 695: float soft_bits[OSMO_TRXD_BURST_LEN_MAX];
this can also probably be split onto the mentioned previous preparation patch?
Patch Set #1, Line 801: bi->toa256 = (int16_t) lround(ebp.toa * 256.0);
I see tons of changes in how the bi fields are being set, do you mind explaining why? Can this be done in a seaprate previous commit?
To view, visit change 43115. To unsubscribe, or for help writing mail filters, visit settings.