July 2026 - gerrit-log - lists.osmocom.org

[S] Change in simtrace2[master]: firmware: Drop CEMU_TX_DATA when sim is in-active
by lynxis lazus 15 Jul '26

15 Jul '26

Attention is currently required from: laforge. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43003?usp=email ) Change subject: firmware: Drop CEMU_TX_DATA when sim is in-active ...................................................................... Patch Set 4: (2 comments) File firmware/libcommon/include/card_emu.h: https://gerrit.osmocom.org/c/simtrace2/+/43003/comment/9de837d4_4c88bb33?us… : PS4, Line 75: bool card_ready(struct card_handle *ch); > const struct Done File firmware/libcommon/source/card_emu.c: https://gerrit.osmocom.org/c/simtrace2/+/43003/comment/3ad7c432_15446bb3?us… : PS4, Line 219: bool card_ready(struct card_handle *ch) > const struct ... Done -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43003?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I796e548225a742cddfde12bd6a60e4d2e5c04c8f Gerrit-Change-Number: 43003 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 15 Jul 2026 17:42:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[M] Change in libosmo-sigtran[master]: TCAP: implement a fallback routing
by lynxis lazus 15 Jul '26

15 Jul '26

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008?usp=email ) Change subject: TCAP: implement a fallback routing ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3e4e634b38a1845c2ce62a3805ff91a530520d88 Gerrit-Change-Number: 43008 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Wed, 15 Jul 2026 17:04:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[M] Change in libosmo-sigtran[master]: TCAP: Refactoring unroutable messages into own function
by lynxis lazus 15 Jul '26

15 Jul '26

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43007?usp=email ) Change subject: TCAP: Refactoring unroutable messages into own function ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43007?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ib4d114273423730418458767d17b11de9bd815d4 Gerrit-Change-Number: 43007 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Wed, 15 Jul 2026 17:03:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[M] Change in onomondo-eim[master]: restop.py, tryme_*.sh: improve log output and handling
by dexter 15 Jul '26

15 Jul '26

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-eim/+/43014?usp=email to look at the new patch set (#2). Change subject: restop.py, tryme_*.sh: improve log output and handling ...................................................................... restop.py, tryme_*.sh: improve log output and handling The tryme scripts and the restop.py script produce lots of distracting and difficult to read log output. Let's renovate the scripts a bit so that the useful information is displayed in a readable way. Change-Id: Id257e7a541fc92386cecee5af3dad2077b62709c Related: SYS#8100 --- M contrib/restop.py M contrib/tryme_addEim.sh M contrib/tryme_configureImmediateEnable.sh M contrib/tryme_delete.sh M contrib/tryme_deleteEim.sh M contrib/tryme_disable.sh M contrib/tryme_download.sh M contrib/tryme_enable.sh M contrib/tryme_euiccDataRequest.sh M contrib/tryme_euicc_get_state.sh M contrib/tryme_euicc_set_state.sh M contrib/tryme_getRAT.sh M contrib/tryme_listEim.sh M contrib/tryme_listProfileInfo.sh M contrib/tryme_lookup.sh M contrib/tryme_updateEim.sh 16 files changed, 38 insertions(+), 39 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/14/43014/2 -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43014?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: Id257e7a541fc92386cecee5af3dad2077b62709c Gerrit-Change-Number: 43014 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[XS] Change in onomondo-eim[master]: esipa_asn1_handler_utils: use eimTransactionId in EuiccPackageErrorUn...
by dexter 15 Jul '26

15 Jul '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43015?usp=email ) Change subject: esipa_asn1_handler_utils: use eimTransactionId in EuiccPackageErrorUnsigned ...................................................................... esipa_asn1_handler_utils: use eimTransactionId in EuiccPackageErrorUnsigned EuiccPackageErrorUnsigned contains an eimTransactionId, let's make sure that it is used (if it is present). Change-Id: Ibfbc6debcd36d2aae1f4530a608db823caf3a394 Related: SYS#8100 --- M src/esipa_asn1_handler_utils.erl 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/15/43015/1 diff --git a/src/esipa_asn1_handler_utils.erl b/src/esipa_asn1_handler_utils.erl index ead177f..8d6e59a 100644 --- a/src/esipa_asn1_handler_utils.erl +++ b/src/esipa_asn1_handler_utils.erl @@ -24,6 +24,8 @@ euiccPackageErrorDataSigned, EuiccPackageErrorSigned ), maps:get(eimTransactionId, EuiccPackageErrorDataSigned, none); + {euiccPackageErrorUnsigned, EuiccPackageErrorUnsigned} -> + maps:get(eimTransactionId, EuiccPackageErrorUnsigned, none); _ -> none end. -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43015?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: Ibfbc6debcd36d2aae1f4530a608db823caf3a394 Gerrit-Change-Number: 43015 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[M] Change in onomondo-eim[master]: esipa_asn1_handler_utils: clean up handling of EuiccPackageResult
by dexter 15 Jul '26

15 Jul '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43016?usp=email ) Change subject: esipa_asn1_handler_utils: clean up handling of EuiccPackageResult ...................................................................... esipa_asn1_handler_utils: clean up handling of EuiccPackageResult The function that handles the parsing and processing of the EuiccPackageResult is written in a confusing way and also seems to be slightly wrong (we do not want to re-bind any work item to a eimTransactionId here). Let's clean it up in a way that is easier to follow. Change-Id: Ic2f64c254f3e07ce8dfdf43af977decf3514627b Related: SYS#8100 --- M src/crypto_utils.erl M src/esipa_asn1_handler_utils.erl 2 files changed, 83 insertions(+), 84 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/16/43016/1 diff --git a/src/crypto_utils.erl b/src/crypto_utils.erl index 21929b5..7d051a1 100644 --- a/src/crypto_utils.erl +++ b/src/crypto_utils.erl @@ -12,6 +12,7 @@ -export([ sign_euiccPackageSigned/2, verify_euiccPackageResultSigned/2, + verify_euiccPackageErrorSigned/2, store_euicc_pubkey_from_authenticateResponseOk/2, store_euicc_pubkey_from_ipaEuiccDataResponse/2 ]). @@ -107,52 +108,57 @@ error end. -verify_euiccPackageResultSigned(EuiccPackageResult, EidValue) -> +verify_euiccPackageResultSigned(EuiccPackageResultSigned, EidValue) -> {ok, ConsumerEuicc} = mnesia_db_euicc:state_get(EidValue, consumerEuicc), case ConsumerEuicc of false -> % Read the AssociationToken {ok, AssociationToken} = mnesia_db_euicc:state_get(EidValue, associationToken), - case EuiccPackageResult of - {euiccPackageResultSigned, EuiccPackageResultSigned} -> - EuiccPackageResultDataSigned = maps:get( - euiccPackageResultDataSigned, EuiccPackageResultSigned - ), - EuiccSignEPR = maps:get(euiccSignEPR, EuiccPackageResultSigned), - {ok, EuiccPackageResultDataSigned_enc} = 'SGP32Definitions':encode( - 'EuiccPackageResultDataSigned', - EuiccPackageResultDataSigned - ), - % "euiccSignEPR SHALL apply on the concatenated data objects euiccPackageResultDataSigned and - % eimSignature." (see also GSMA SGP.32, section 2.11.2.1) - MsgToBeVerfied = utils:join_binary_list([ - EuiccPackageResultDataSigned_enc, - enc_association_token(AssociationToken) - ]), - verify_signature(MsgToBeVerfied, EuiccSignEPR, EidValue); - {euiccPackageErrorSigned, EuiccPackageErrorSigned} -> - EuiccPackageErrorDataSigned = maps:get( - euiccPackageErrorDataSigned, EuiccPackageErrorSigned - ), - EuiccSignEPE = maps:get(euiccSignEPE, EuiccPackageErrorSigned), - {ok, EuiccPackageErrorDataSigned_enc} = 'SGP32Definitions':encode( - 'EuiccPackageErrorDataSigned', - EuiccPackageErrorDataSigned - ), - % "euiccSignEPE SHALL apply on the concatenated data objects euiccPackageErrorDataSigned and - % eimSignature." (see also GSMA SGP.32, section 2.11.2.1) - MsgToBeVerfied = utils:join_binary_list([ - EuiccPackageErrorDataSigned_enc, - enc_association_token(AssociationToken) - ]), - verify_signature(MsgToBeVerfied, EuiccSignEPE, EidValue); - {euiccPackageErrorUnsigned, _} -> - % This result has no signature - ok; - _ -> - error - end; + EuiccPackageResultDataSigned = maps:get( + euiccPackageResultDataSigned, EuiccPackageResultSigned + ), + EuiccSignEPR = maps:get(euiccSignEPR, EuiccPackageResultSigned), + {ok, EuiccPackageResultDataSigned_enc} = 'SGP32Definitions':encode( + 'EuiccPackageResultDataSigned', + EuiccPackageResultDataSigned + ), + % "euiccSignEPR SHALL apply on the concatenated data objects euiccPackageResultDataSigned and + % eimSignature." (see also GSMA SGP.32, section 2.11.2.1) + MsgToBeVerfied = utils:join_binary_list([ + EuiccPackageResultDataSigned_enc, + enc_association_token(AssociationToken) + ]), + verify_signature(MsgToBeVerfied, EuiccSignEPR, EidValue); + _ -> + logger:info( + "omitting signature check for euiccPackageResultSigned from eID ~p (consumer eUICC)~n", + [utils:binary_to_hex(EidValue)] + ), + ok + end. + +verify_euiccPackageErrorSigned(EuiccPackageErrorSigned, EidValue) -> + {ok, ConsumerEuicc} = mnesia_db_euicc:state_get(EidValue, consumerEuicc), + case ConsumerEuicc of + false -> + % Read the AssociationToken + {ok, AssociationToken} = mnesia_db_euicc:state_get(EidValue, associationToken), + EuiccPackageErrorDataSigned = maps:get( + euiccPackageErrorDataSigned, EuiccPackageErrorSigned + ), + EuiccSignEPE = maps:get(euiccSignEPE, EuiccPackageErrorSigned), + {ok, EuiccPackageErrorDataSigned_enc} = 'SGP32Definitions':encode( + 'EuiccPackageErrorDataSigned', + EuiccPackageErrorDataSigned + ), + % "euiccSignEPE SHALL apply on the concatenated data objects euiccPackageErrorDataSigned and + % eimSignature." (see also GSMA SGP.32, section 2.11.2.1) + MsgToBeVerfied = utils:join_binary_list([ + EuiccPackageErrorDataSigned_enc, + enc_association_token(AssociationToken) + ]), + verify_signature(MsgToBeVerfied, EuiccSignEPE, EidValue); _ -> logger:info( "omitting signature check for euiccPackageResultSigned from eID ~p (consumer eUICC)~n", diff --git a/src/esipa_asn1_handler_utils.erl b/src/esipa_asn1_handler_utils.erl index 8d6e59a..373922f 100644 --- a/src/esipa_asn1_handler_utils.erl +++ b/src/esipa_asn1_handler_utils.erl @@ -40,18 +40,13 @@ none end. -process_euiccPackageResult(Pid, EuiccPackageResult, Debuginfo, EimTransactionId) -> - WorkBind = fun(Map) -> - case maps:find(eimTransactionId, Map) of - {ok, Value} -> - mnesia_db_work:bind(Pid, Value); - _ -> - ok - end - end, +% Handle an EuiccPackageResult, this includes everything from the handling of the work items in mnesia_db, down to +% signature checks and the generation of an appropriate outcome for the REST API. +handle_euiccPackageResult(Pid, EuiccPackageResult, Debuginfo) -> + EimTransactionId = eimTransactionId_from_euiccPackageResult(EuiccPackageResult), + {EidValue, _, _} = mnesia_db_work:pickup(Pid, EimTransactionId), CheckCounterValue = fun(Map) -> - {EidValue, _, _} = mnesia_db_work:pickup(Pid, EimTransactionId), CounterValueIpad = maps:get(counterValue, Map), {ok, CounterValueEim} = mnesia_db_euicc:state_get(EidValue, counterValue), case CounterValueIpad of @@ -59,7 +54,7 @@ ok; _ -> logger:error( - "invalid euiccPackageResultSigned, counterValue mismatch: CounterValueIpad=~p, CounterValueEim=~p~n", + "invalid eUICC signature, counterValue mismatch: CounterValueIpad=~p, CounterValueEim=~p~n", [CounterValueIpad, CounterValueEim] ), error @@ -69,31 +64,43 @@ Outcome = case EuiccPackageResult of {euiccPackageResultSigned, EuiccPackageResultSigned} -> - EuiccPackageResultDataSigned = maps:get( - euiccPackageResultDataSigned, EuiccPackageResultSigned - ), - WorkBind(EuiccPackageResultDataSigned), - case CheckCounterValue(EuiccPackageResultDataSigned) of + case + crypto_utils:verify_euiccPackageResultSigned(EuiccPackageResultSigned, EidValue) + of ok -> - esipa_rest_utils:euiccPackageResultDataSigned_to_outcome( - EuiccPackageResultDataSigned - ); + EuiccPackageResultDataSigned = maps:get( + euiccPackageResultDataSigned, EuiccPackageResultSigned + ), + case CheckCounterValue(EuiccPackageResultDataSigned) of + ok -> + esipa_rest_utils:euiccPackageResultDataSigned_to_outcome( + EuiccPackageResultDataSigned + ); + _ -> + [{[{euiccPackageErrorCode, counterValueMismatch}]}] + end; _ -> - [{[{euiccPackageErrorCode, counterValueMismatch}]}] + [{[{procedureError, euiccSignatureInvalid}]}] end; {euiccPackageErrorSigned, EuiccPackageErrorSigned} -> - EuiccPackageErrorDataSigned = maps:get( - euiccPackageErrorDataSigned, EuiccPackageErrorSigned - ), - WorkBind(EuiccPackageErrorDataSigned), - EuiccPackageErrorCode = maps:get( - euiccPackageErrorCode, EuiccPackageErrorDataSigned - ), - case CheckCounterValue(EuiccPackageErrorDataSigned) of + case + crypto_utils:verify_euiccPackageErrorSigned(EuiccPackageErrorSigned, EidValue) + of ok -> - [{[{euiccPackageErrorCode, EuiccPackageErrorCode}]}]; + EuiccPackageErrorDataSigned = maps:get( + euiccPackageErrorDataSigned, EuiccPackageErrorSigned + ), + EuiccPackageErrorCode = maps:get( + euiccPackageErrorCode, EuiccPackageErrorDataSigned + ), + case CheckCounterValue(EuiccPackageErrorDataSigned) of + ok -> + [{[{euiccPackageErrorCode, EuiccPackageErrorCode}]}]; + _ -> + [{[{euiccPackageErrorCode, counterValueMismatch}]}] + end; _ -> - [{[{euiccPackageErrorCode, counterValueMismatch}]}] + [{[{procedureError, euiccSignatureInvalid}]}] end; {euiccPackageErrorUnsigned, _} -> [{[{euiccPackageErrorCode, undefinedError}]}] @@ -101,20 +108,6 @@ mnesia_db_work:finish(Pid, Outcome, Debuginfo). -% Handle an EuiccPackageResult, this includes everything from the handling of the work items in mnesia_db, down to -% signature checks and the generation of an appropriate outcome for the REST API. -handle_euiccPackageResult(Pid, EuiccPackageResult, Debuginfo) -> - EimTransactionId = eimTransactionId_from_euiccPackageResult(EuiccPackageResult), - {EidValue, _, _} = mnesia_db_work:pickup(Pid, EimTransactionId), - case crypto_utils:verify_euiccPackageResultSigned(EuiccPackageResult, EidValue) of - ok -> - process_euiccPackageResult(Pid, EuiccPackageResult, Debuginfo, EimTransactionId); - _ -> - mnesia_db_work:finish( - Pid, [{[{procedureError, euiccSignatureInvalid}]}], Debuginfo - ) - end. - % Handle an IpaEuiccDataResponse, this includes everything from the handling of the work items in mnesia_db as well % as the generation of an appropriate outcome for the REST API. In case IpaEuiccDataResponse contains an eUICC public % key, we will automatically store it so that we can use it to check the signatures of PSMOs and eCOs. -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43016?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: Ic2f64c254f3e07ce8dfdf43af977decf3514627b Gerrit-Change-Number: 43016 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[XL] Change in osmo-ttcn3-hacks[master]: Add old eUICC library to run IPA with SGP.32 V1.0.1
by dexter 15 Jul '26

15 Jul '26

Attention is currently required from: jolly. dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42997?usp=email ) Change subject: Add old eUICC library to run IPA with SGP.32 V1.0.1 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42997?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6d4a2bef08847cd58e75f88a02d0299ce694516e Gerrit-Change-Number: 42997 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 15 Jul 2026 13:45:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ccid-firmware[master]: Rework default IRQ handler and osmo panic handler
by Hoernchen 15 Jul '26

15 Jul '26

Attention is currently required from: lynxis lazus. Hoernchen has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42616?usp=email ) Change subject: Rework default IRQ handler and osmo panic handler ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42616?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ibcabe0c58ff14ebe76159470dd90fdef064febea Gerrit-Change-Number: 42616 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 15 Jul 2026 13:24:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XL] Change in onomondo-eim[master]: mnesia_db: split functionality into dedicated modules
by laforge 15 Jul '26

15 Jul '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42946?usp=email ) Change subject: mnesia_db: split functionality into dedicated modules ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42946?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: Ifc649337ab7ce7eb9dc602a1439293130f002f41 Gerrit-Change-Number: 42946 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jul 2026 12:25:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in simtrace2[master]: firmware: card_emu.h: declare usb_buf_upd_len_and_submit()
by laforge 15 Jul '26

15 Jul '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/43002?usp=email ) Change subject: firmware: card_emu.h: declare usb_buf_upd_len_and_submit() ...................................................................... firmware: card_emu.h: declare usb_buf_upd_len_and_submit() usb_buf_upd_len_and_submit() is already a non-static function and should be accessible. Change-Id: I734d4b2d782223dd2f735f140d8c9bc6fc00a086 --- M firmware/libcommon/include/card_emu.h 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/firmware/libcommon/include/card_emu.h b/firmware/libcommon/include/card_emu.h index 8b571bb..c2d3b68 100644 --- a/firmware/libcommon/include/card_emu.h +++ b/firmware/libcommon/include/card_emu.h @@ -19,6 +19,7 @@ #include <stdint.h> struct card_handle; +struct msgb; enum card_io { CARD_IO_VCC, @@ -75,3 +76,5 @@ struct cardemu_usb_msg_config; int card_emu_set_config(struct card_handle *ch, const struct cardemu_usb_msg_config *scfg, unsigned int scfg_len); + +void usb_buf_upd_len_and_submit(struct msgb *msg); -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43002?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I734d4b2d782223dd2f735f140d8c9bc6fc00a086 Gerrit-Change-Number: 43002 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

2026

2025

2024

2023

2022

gerrit-log July 2026