July 2026 - gerrit-log - lists.osmocom.org

[S] Change in simtrace2[master]: firmware: iso7816_3: fix F/D ratio for Di 8 and 9
by Hoernchen 28 Jul '26

28 Jul '26

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/43124?usp=email ) Change subject: firmware: iso7816_3: fix F/D ratio for Di 8 and 9 ...................................................................... firmware: iso7816_3: fix F/D ratio for Di 8 and 9 iso7816_3_compute_fd_ratio() multiplied F by D for every d_index >= 8, presumably because the upper half of ISO 7816-3 Table 8 encodes 1/D. But 7816-3 2006 and 1997 differ! That assumption is only true for the range 1010..1111, which in the 2006 version is RFU. Indices 1000 and 1001 are Di = 12 and Di = 20, see iso7816_3_di_table[]. So right now Fi=372/Di=12 -> 372 * 12 = 4464 instead of 372 / 12 = 31. In the cemu value is rejected in emu_update_fidi() and the old baud rate is silently kept. In the sniffer update_fidi() programs US_FIDI as 4464 & 0x7ff = 368, which is garbage. Use F/D for indices 1..9 and keep the legacy 1/D reading only for the RFU range, where we cant really do anything useful anyway. Change-Id: I44d6451d8b04aea2b0db7291b06a812afe84e52f --- M firmware/libcommon/source/iso7816_fidi.c 1 file changed, 7 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/24/43124/1 diff --git a/firmware/libcommon/source/iso7816_fidi.c b/firmware/libcommon/source/iso7816_fidi.c index 024663b..4e87dbd 100644 --- a/firmware/libcommon/source/iso7816_fidi.c +++ b/firmware/libcommon/source/iso7816_fidi.c @@ -48,9 +48,13 @@ if (d == 0) return -EINVAL; - /* See table 7 of ISO 7816-3: From 1000 on we divide by 1/d, - * which equals a multiplication by d */ - if (d_index < 8) + /* DI defined in Table 8 of ISO/IEC 7816-3:2006 + * has values 0001..1001 as div 1, 2, 4, 8, 16, 32, 64, 12, 20 + * so indices 1..9 are all divisors and the ratio is F/D. + * But Indices 1010..1111 are RFU in the 2006 edition! + * 1997 used those for 1/2 .. 1/64, where dividing by 1/d equals multiplying by d. + * Keep that legacy interpretation for the RFU range only. */ + if (d_index < 10) ret = f / d; else ret = f * d; -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43124?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I44d6451d8b04aea2b0db7291b06a812afe84e52f Gerrit-Change-Number: 43124 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>

1 0

[XS] Change in onomondo-eim[master]: Integrate 'rebar3 get-deps' into Makefile
by dexter 28 Jul '26

28 Jul '26

Attention is currently required from: jolly. dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43123?usp=email ) Change subject: Integrate 'rebar3 get-deps' into Makefile ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43123?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I382fef54a97891b6f8992115837ea52197056cc8 Gerrit-Change-Number: 43123 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 28 Jul 2026 14:45:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in onomondo-eim[master]: Integrate 'rebar3 get-deps' into Makefile
by jolly 28 Jul '26

28 Jul '26

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43123?usp=email ) Change subject: Integrate 'rebar3 get-deps' into Makefile ...................................................................... Integrate 'rebar3 get-deps' into Makefile Related: SYS#8100 Change-Id: I382fef54a97891b6f8992115837ea52197056cc8 --- M Makefile 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/23/43123/1 diff --git a/Makefile b/Makefile index 9ca1dee..f2d7de3 100644 --- a/Makefile +++ b/Makefile @@ -11,6 +11,9 @@ GEN_FILES = src/* +deps: $(GEN_FILES) + rebar3 get-deps + build: $(GEN_FILES) rebar3 compile -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43123?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I382fef54a97891b6f8992115837ea52197056cc8 Gerrit-Change-Number: 43123 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu>

1 0

[XS] Change in onomondo-eim[master]: Add missing depenency 'jsx'
by jolly 28 Jul '26

28 Jul '26

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43122?usp=email ) Change subject: Add missing depenency 'jsx' ...................................................................... Add missing depenency 'jsx' Related: SYS#8100 Change-Id: I56426d70fdf6ccd5735b094b19c47341c76dca98 --- M rebar.config M rebar.lock 2 files changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/22/43122/1 diff --git a/rebar.config b/rebar.config index 1380062..8108230 100644 --- a/rebar.config +++ b/rebar.config @@ -9,7 +9,8 @@ {hackney, "1.20.1"}, {jiffy, "1.1.2"}, {quickrand, "2.0.7"}, - {uuid, "2.0.7", {pkg, uuid_erl}} + {uuid, "2.0.7", {pkg, uuid_erl}}, + {jsx, "~> 3.1"} ]}. {project_plugins, [rebar3_asn1_compiler, erlfmt]}. diff --git a/rebar.lock b/rebar.lock index 33eaecf..5216b5c 100644 --- a/rebar.lock +++ b/rebar.lock @@ -5,6 +5,7 @@ {<<"hackney">>,{pkg,<<"hackney">>,<<"1.20.1">>},0}, {<<"idna">>,{pkg,<<"idna">>,<<"6.1.1">>},1}, {<<"jiffy">>,{pkg,<<"jiffy">>,<<"1.1.2">>},0}, + {<<"jsx">>,{pkg,<<"jsx">>,<<"3.1.0">>},0}, {<<"metrics">>,{pkg,<<"metrics">>,<<"1.0.1">>},1}, {<<"mimerl">>,{pkg,<<"mimerl">>,<<"1.4.0">>},1}, {<<"parse_trans">>,{pkg,<<"parse_trans">>,<<"3.4.1">>},1}, @@ -21,6 +22,7 @@ {<<"hackney">>, <<"8D97AEC62DDDDD757D128BFD1DF6C5861093419F8F7A4223823537BAD5D064E2">>}, {<<"idna">>, <<"8A63070E9F7D0C62EB9D9FCB360A7DE382448200FBBD1B106CC96D3D8099DF8D">>}, {<<"jiffy">>, <<"A9B6C9A7EC268E7CF493D028F0A4C9144F59CCB878B1AFE42841597800840A1B">>}, + {<<"jsx">>, <<"D12516BAA0BB23A59BB35DCCAF02A1BD08243FCBB9EFE24F2D9D056CCFF71268">>}, {<<"metrics">>, <<"25F094DEA2CDA98213CECC3AEFF09E940299D950904393B2A29D191C346A8486">>}, {<<"mimerl">>, <<"3882A5CA67FBBE7117BA8947F27643557ADEC38FA2307490C4C4207624CB213B">>}, {<<"parse_trans">>, <<"6E6AA8167CB44CC8F39441D05193BE6E6F4E7C2946CB2759F015F8C56B76E5FF">>}, @@ -36,6 +38,7 @@ {<<"hackney">>, <<"FE9094E5F1A2A2C0A7D10918FEE36BFEC0EC2A979994CFF8CFE8058CD9AF38E3">>}, {<<"idna">>, <<"92376EB7894412ED19AC475E4A86F7B413C1B9FBB5BD16DCCD57934157944CEA">>}, {<<"jiffy">>, <<"BB61BC42A720BBD33CB09A410E48BB79A61012C74CB8B3E75F26D988485CF381">>}, + {<<"jsx">>, <<"0C5CC8FDC11B53CC25CF65AC6705AD39E54ECC56D1C22E4ADB8F5A53FB9427F3">>}, {<<"metrics">>, <<"69B09ADDDC4F74A40716AE54D140F93BEB0FB8978D8636EADED0C31B6F099F16">>}, {<<"mimerl">>, <<"13AF15F9F68C65884ECCA3A3891D50A7B57D82152792F3E19D88650AA126B144">>}, {<<"parse_trans">>, <<"620A406CE75DADA827B82E453C19CF06776BE266F5A67CFF34E1EF2CBB60E49A">>}, -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43122?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I56426d70fdf6ccd5735b094b19c47341c76dca98 Gerrit-Change-Number: 43122 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu>

1 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: fix B006
by pespin 28 Jul '26

28 Jul '26

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43120?usp=email ) Change subject: testenv: fix B006 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43120?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id860c1cba20c0218aa1d1bb17378a0f5a521cfe0 Gerrit-Change-Number: 43120 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jul 2026 13:18:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in onomondo-ipa[master]: V1.2: Add eimTransactionId to IpaEuiccDataRequest and IpaEuiccDataRes...
by jolly 28 Jul '26

28 Jul '26

Attention is currently required from: dexter. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43035?usp=email ) Change subject: V1.2: Add eimTransactionId to IpaEuiccDataRequest and IpaEuiccDataResponse ...................................................................... Patch Set 2: (1 comment) File src/ipa/libipa/proc_euicc_data_req.c: https://gerrit.osmocom.org/c/onomondo-ipa/+/43035/comment/657e4f7e_46aea480… : PS1, Line 211: > I think at this point it is too late to set the eimTransactionId. […] Done -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43035?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I34db78c4eb8461c154459204ec13a2184085e96a Gerrit-Change-Number: 43035 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jul 2026 13:14:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[L] Change in onomondo-ipa[master]: V1.2: Add eimTransactionId to IpaEuiccDataRequest and IpaEuiccDataRes...
by jolly 28 Jul '26

28 Jul '26

Attention is currently required from: dexter, jolly. Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43035?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: V1.2: Add eimTransactionId to IpaEuiccDataRequest and IpaEuiccDataResponse ...................................................................... V1.2: Add eimTransactionId to IpaEuiccDataRequest and IpaEuiccDataResponse Add eimTransactionId to IpaEuiccDataRequest and to IpaEuiccDataResponseError or IpaEuiccData of IpaEuiccDataResponse. The IPA takes the transaction ID from the request, if exists, and sets it in the response. The eIM can use it to match the request with the successful or unsuccessful outcome. Note that there is no error handling if the requested data fails to be received from eUICC. This means that there is no transaction ID set at IpaEuiccDataResponseError. Reference: SGP.32 Section 2.11.1.2 Related: SYS#8101 Change-Id: I34db78c4eb8461c154459204ec13a2184085e96a --- M asn1/SGP32Definitions.asn M src/ipa/libasn/CMakeLists.txt M src/ipa/libasn/IpaEuiccData.c M src/ipa/libasn/IpaEuiccData.h A src/ipa/libasn/IpaEuiccDataErrorCode.c A src/ipa/libasn/IpaEuiccDataErrorCode.h M src/ipa/libasn/IpaEuiccDataRequest.c M src/ipa/libasn/IpaEuiccDataRequest.h M src/ipa/libasn/IpaEuiccDataResponse.c M src/ipa/libasn/IpaEuiccDataResponse.h A src/ipa/libasn/IpaEuiccDataResponseError.c A src/ipa/libasn/IpaEuiccDataResponseError.h M src/ipa/libipa/proc_euicc_data_req.c 13 files changed, 267 insertions(+), 44 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/35/43035/2 -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43035?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I34db78c4eb8461c154459204ec13a2184085e96a Gerrit-Change-Number: 43035 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: ruff: ignore new failing default rules
by pespin 28 Jul '26

28 Jul '26

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43119?usp=email ) Change subject: ruff: ignore new failing default rules ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43119?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If95dc72c1826b4b96961453b2c2ed1d2c81ba149 Gerrit-Change-Number: 43119 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jul 2026 13:10:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-dev[master]: ruff: ignore new failing default rules
by osmith 28 Jul '26

28 Jul '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-dev/+/43121?usp=email ) Change subject: ruff: ignore new failing default rules ...................................................................... ruff: ignore new failing default rules With the new ruff 0.16 version, a lot of new default rules have been added. Ignore the ones that are failing for now to make the linter pass again. Related: https://astral.sh/blog/ruff-v0.16.0#better-default-rule-set Change-Id: I7d22481e9238e8155beb923a120ac8baea21df9d --- M .ruff.toml 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/21/43121/1 diff --git a/.ruff.toml b/.ruff.toml index c673c3a..e39a704 100644 --- a/.ruff.toml +++ b/.ruff.toml @@ -13,7 +13,16 @@ [lint] # E741: Ambiguous variable name: `l` -ignore = ["E741"] +ignore = [ + "B026", + "E741", + "EXE001", + "I001", + "PLR1730", + "SIM103", + "SIM115", + "UP031", +] [format] exclude = [ -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/43121?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I7d22481e9238e8155beb923a120ac8baea21df9d Gerrit-Change-Number: 43121 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: fix B006
by osmith 28 Jul '26

28 Jul '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43120?usp=email ) Change subject: testenv: fix B006 ...................................................................... testenv: fix B006 Fix "B006 Do not use mutable data structures for argument defaults". I ran into bugs caused by this a couple of times actually, it is good to check for that. Related: https://docs.astral.sh/ruff/rules/mutable-argument-default/ Change-Id: Id860c1cba20c0218aa1d1bb17378a0f5a521cfe0 --- M .ruff.toml M _testenv/testenv/cmd.py M _testenv/testenv/podman.py 3 files changed, 14 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/20/43120/1 diff --git a/.ruff.toml b/.ruff.toml index ad4de47..5b6da16 100644 --- a/.ruff.toml +++ b/.ruff.toml @@ -5,7 +5,6 @@ [lint] ignore = [ - "B006", "B026", "BLE001", "DTZ001", diff --git a/_testenv/testenv/cmd.py b/_testenv/testenv/cmd.py index c14f694..97e5c0d 100644 --- a/_testenv/testenv/cmd.py +++ b/_testenv/testenv/cmd.py @@ -88,7 +88,8 @@ raise RuntimeError("shell command related error, find details right above this python trace") -def generate_env(env={}, podman=False): +def generate_env(env=None, podman=False): + env = env or {} ret = dict(env_extra) path = os.path.join(testenv.data_dir, "scripts") path += f":{os.path.join(testenv.data_dir, 'scripts/qemu')}" @@ -120,7 +121,8 @@ return ret -def run(cmd, check=True, env={}, no_podman=False, stdin=subprocess.DEVNULL, *args, **kwargs): +def run(cmd, check=True, env=None, no_podman=False, stdin=subprocess.DEVNULL, *args, **kwargs): + env = env or {} if not no_podman and testenv.args.podman: return testenv.podman.exec_cmd(cmd, check=check, env=env, *args, **kwargs) diff --git a/_testenv/testenv/podman.py b/_testenv/testenv/podman.py index a3e7948..eefa911 100644 --- a/_testenv/testenv/podman.py +++ b/_testenv/testenv/podman.py @@ -82,7 +82,8 @@ ) -def generate_env_podman(env={}): +def generate_env_podman(env=None): + env = env or {} ret = [] for key, val in testenv.cmd.generate_env(env, True).items(): @@ -136,7 +137,10 @@ run_shell_on_stop = True -def exec_cmd(cmd, podman_opts=[], cwd=None, env={}, *args, **kwargs): +def exec_cmd(cmd, podman_opts=None, cwd=None, env=None, *args, **kwargs): + podman_opts = podman_opts or [] + env = env or {} + if not container_name: raise RuntimeError(f"Attempting to execute a command in podman, but the container isn't running anymore: {cmd}") @@ -159,7 +163,10 @@ ) -def exec_cmd_background(cmd, podman_opts=[], cwd=None, env={}): +def exec_cmd_background(cmd, podman_opts=None, cwd=None, env=None): + podman_opts = podman_opts or [] + env = env or {} + podman_opts = list(podman_opts) + generate_env_podman(env) if cwd: -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43120?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id860c1cba20c0218aa1d1bb17378a0f5a521cfe0 Gerrit-Change-Number: 43120 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log July 2026