July 2026 - gerrit-log - lists.osmocom.org

[L] Change in onomondo-ipa[master]: V1.2: Add setDefaultDpAddress function
by jolly 27 Jul '26

27 Jul '26

Attention is currently required from: dexter, jolly. Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43031?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by dexter, Verified-1 by Jenkins Builder Change subject: V1.2: Add setDefaultDpAddress function ...................................................................... V1.2: Add setDefaultDpAddress function Add setDefaultDpAddress to EuiccResultData. Implement the SGP.32 function SetDefaultDpAddress and handle the setDefaultDpAddress PSMO. The IoT eUICC emulation uses the non-IoT eUICC SGP.22 function SetDefaultDpAddress. Reference: SGP.32 Section 2.11.1.1.3 Related: SYS#8101 Change-Id: I514b03240289469142e6a41a7290a4afce199318 --- M asn1/SGP32Definitions.asn M src/ipa/libasn/CMakeLists.txt M src/ipa/libasn/EuiccResultData.c M src/ipa/libasn/EuiccResultData.h M src/ipa/libasn/Psmo.c M src/ipa/libasn/Psmo.h A src/ipa/libasn/SGP32-SetDefaultDpAddressRequest.c A src/ipa/libasn/SGP32-SetDefaultDpAddressRequest.h A src/ipa/libasn/SGP32-SetDefaultDpAddressResponse.c A src/ipa/libasn/SGP32-SetDefaultDpAddressResponse.h M src/ipa/libipa/CMakeLists.txt M src/ipa/libipa/es10b_load_euicc_pkg.c A src/ipa/libipa/es10c_set_def_dp_addr.c A src/ipa/libipa/es10c_set_def_dp_addr.h 14 files changed, 383 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/31/43031/2 -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43031?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I514b03240289469142e6a41a7290a4afce199318 Gerrit-Change-Number: 43031 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[M] Change in onomondo-ipa[master]: V1.2: Add EimConfigurationData.indirectProfileDownload
by jolly 27 Jul '26

27 Jul '26

Attention is currently required from: dexter, jolly. Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43029?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by dexter, Verified-1 by Jenkins Builder Change subject: V1.2: Add EimConfigurationData.indirectProfileDownload ...................................................................... V1.2: Add EimConfigurationData.indirectProfileDownload The flag indicates, if eIM supports indirect download. As the current version of IPA only supports indirect download, this flag is checked. If it is not supported, profile download is rejected. get_euicc_ci_pkid() is renamed to get_euicc_ci_pkid_ipd(), to indicate that it also gets this flag. This also requires an update of contrib/sample_eim_cfg.ber, which is a BER encoded EimConfigurationData. Reference: SGP.32 Section 2.11.1.1.1 Related: SYS#8101 Change-Id: Ic40111531e6f35d5ea7f3789de6cae0f1c0d5ba7 --- M asn1/SGP32Definitions.asn M contrib/sample_eim_cfg.ber M src/ipa/libasn/EimConfigurationData.c M src/ipa/libasn/EimConfigurationData.h M src/ipa/libipa/proc_eim_pkg_retr.c 5 files changed, 42 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/29/43029/2 -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43029?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: Ic40111531e6f35d5ea7f3789de6cae0f1c0d5ba7 Gerrit-Change-Number: 43029 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in osmo-sgsn[master]: tests/v42bis: Remove unused variable
by osmith 27 Jul '26

27 Jul '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43100?usp=email ) Change subject: tests/v42bis: Remove unused variable ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43100?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I715e57513ee62b7c61492a1d206232a5db107ea0 Gerrit-Change-Number: 43100 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Jul 2026 13:47:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-sgsn[master]: sndcp: Remove unused variable
by osmith 27 Jul '26

27 Jul '26

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43099?usp=email ) Change subject: sndcp: Remove unused variable ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43099?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ie2bd3d2935cd7e0ad023a163c9be9a05b83fbc5e Gerrit-Change-Number: 43099 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Jul 2026 13:47:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-sgsn[master]: tests/v42bis: Remove unused variable
by pespin 27 Jul '26

27 Jul '26

pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43100?usp=email ) Change subject: tests/v42bis: Remove unused variable ...................................................................... tests/v42bis: Remove unused variable gcc 16.1.1 warns about it. Change-Id: I715e57513ee62b7c61492a1d206232a5db107ea0 --- M tests/v42bis/v42bis_test.c 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/00/43100/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43100?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I715e57513ee62b7c61492a1d206232a5db107ea0 Gerrit-Change-Number: 43100 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-sgsn[master]: tests/v42bis: Remove unused variable
by pespin 27 Jul '26

27 Jul '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43100?usp=email ) Change subject: tests/v42bis: Remove unused variable ...................................................................... tests/v42bis: Remove unused variable Change-Id: I715e57513ee62b7c61492a1d206232a5db107ea0 --- M tests/v42bis/v42bis_test.c 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/00/43100/1 diff --git a/tests/v42bis/v42bis_test.c b/tests/v42bis/v42bis_test.c index 7ada0e2..513e333 100644 --- a/tests/v42bis/v42bis_test.c +++ b/tests/v42bis/v42bis_test.c @@ -333,7 +333,6 @@ uint8_t *uncompressed; v42bis_state_t *rx_state; int rc; - int rc_sum = 0; int len; struct v42bis_output_buffer uncompressed_data; @@ -363,13 +362,10 @@ rx_state->decompress.user_data = (&uncompressed_data); rc = v42bis_decompress_flush(rx_state); printf("v42bis_decompress_flush() rc=%d\n", rc); - rc_sum += rc; rc = v42bis_decompress(rx_state, compressed, compressed_len); printf("v42bis_decompress() rc=%d\n", rc); - rc_sum += rc; rc = v42bis_decompress_flush(rx_state); printf("v42bis_decompress_flush() rc=%d\n", rc); - rc_sum += rc; /* Check results */ printf("compressed= %s ASCII:", -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43100?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I715e57513ee62b7c61492a1d206232a5db107ea0 Gerrit-Change-Number: 43100 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-sgsn[master]: sndcp: Remove unused variable
by pespin 27 Jul '26

27 Jul '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43099?usp=email ) Change subject: sndcp: Remove unused variable ...................................................................... sndcp: Remove unused variable gcc 16.1.1 warns about it. Change-Id: Ie2bd3d2935cd7e0ad023a163c9be9a05b83fbc5e --- M src/sgsn/gprs_sndcp_xid.c 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/99/43099/1 diff --git a/src/sgsn/gprs_sndcp_xid.c b/src/sgsn/gprs_sndcp_xid.c index a19f645..344fda4 100644 --- a/src/sgsn/gprs_sndcp_xid.c +++ b/src/sgsn/gprs_sndcp_xid.c @@ -1352,7 +1352,6 @@ uint8_t tag; uint16_t tag_len; const uint8_t *val; - int byte_counter = 0; int rc; int tlv_count = 0; @@ -1403,8 +1402,7 @@ if (rc < 0) { talloc_free(comp_fields); return -EINVAL; - } else - byte_counter += rc; + } } /* Stop when no further TLV elements can be expected */ -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43099?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ie2bd3d2935cd7e0ad023a163c9be9a05b83fbc5e Gerrit-Change-Number: 43099 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-gprs[master]: sndcp: Remove unused variable
by osmith 27 Jul '26

27 Jul '26

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/43098?usp=email ) Change subject: sndcp: Remove unused variable ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/43098?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I110e3bca19f726382beff673bc91b494e0fba912 Gerrit-Change-Number: 43098 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Jul 2026 13:40:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-gprs[master]: sndcp: Remove unused variable
by pespin 27 Jul '26

27 Jul '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/43098?usp=email ) Change subject: sndcp: Remove unused variable ...................................................................... sndcp: Remove unused variable gcc 16.1.1 warns about it. Change-Id: I110e3bca19f726382beff673bc91b494e0fba912 --- M src/sndcp/sndcp_xid.c 1 file changed, 1 insertion(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/98/43098/1 diff --git a/src/sndcp/sndcp_xid.c b/src/sndcp/sndcp_xid.c index 05098cf..4442f18 100644 --- a/src/sndcp/sndcp_xid.c +++ b/src/sndcp/sndcp_xid.c @@ -1345,7 +1345,6 @@ uint8_t tag; uint16_t tag_len; const uint8_t *val; - int byte_counter = 0; int rc; int tlv_count = 0; @@ -1390,11 +1389,8 @@ || (tag == SNDCP_XID_DATA_COMPRESSION)) { rc = decode_xid_block(comp_fields, tag, tag_len, val, lt, lt_len); - - if (rc < 0) { + if (rc < 0) return -EINVAL; - } - byte_counter += rc; } /* Stop when no further TLV elements can be expected */ -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/43098?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I110e3bca19f726382beff673bc91b494e0fba912 Gerrit-Change-Number: 43098 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: tests/osmo_io: Remove unused variable
by osmith 27 Jul '26

27 Jul '26

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/43097?usp=email ) Change subject: tests/osmo_io: Remove unused variable ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43097?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0bdfe5ed6803042277ed8d21171b5f9c11495ca3 Gerrit-Change-Number: 43097 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Jul 2026 13:30:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log July 2026