[M] Change in simtrace2[master]: firmware: Implement debug command via USB control vendor class - gerrit-log

27 Jul 2026


      Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43005?usp=email )
Change subject: firmware: Implement debug command via USB control vendor class
......................................................................
Patch Set 8: Code-Review+1
(1 comment)
File firmware/libcommon/source/mode_cardemu.c:
https://gerrit.osmocom.org/c/simtrace2/+/43005/comment/1a09c2c2_4bb5612d?usp... :
PS8, Line 710: 		talloc_report_buf(&info.talloc_blocks, ARRAY_SIZE(info.talloc_report) + 1);
"sizeof(info.talloc_blocks) + ARRAY_SIZE(info.talloc_report)" would be more descriptive here, to imply you expect a certain order in memory.
-- 
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43005?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I1f4d29335eb0d2feef376b8ecdfe57a0162914d6
Gerrit-Change-Number: 43005
Gerrit-PatchSet: 8
Gerrit-Owner: lynxis lazus lynxis@fe80.eu
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: lynxis lazus lynxis@fe80.eu
Gerrit-Comment-Date: Mon, 27 Jul 2026 08:27:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes