Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43041?usp=email )
Change subject: V1.2: Add function ES10b.ExecuteFallbackMechanism ......................................................................
Patch Set 1:
(4 comments)
File src/ipa/libipa/ipad.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43041/comment/ba0a982d_cab0ec0c?... : PS1, Line 282: exec_fallback_mech.req.refreshFlag = refresh_flag; You could put the whole setup into ipa_es10b_exec_fallback_mech and call the function like this:
rc = ipa_es10b_exec_fallback_mech(refresh_flag) if rc != 0 return -EINVAL
File src/ipa/main.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43041/comment/0ee9fa51_4b6b0c07?... : PS1, Line 52: printf(" --execute-fallback-mechanism Trigger enabling of fallback profile\n"); This is the only long option now. (maybe we should have long options for all parameters in addition to the short ones?)
https://gerrit.osmocom.org/c/onomondo-ipa/+/43041/comment/c11b9866_cdb3c341?... : PS1, Line 53: printf(" --refresh-flag.............. Make eUICC send a CAT refresh after switchting profile with the triggers above.\n"); I think we should use the refresh_flag from (cfg.refresh_flag, see ipad.h). (see also comment below)
https://gerrit.osmocom.org/c/onomondo-ipa/+/43041/comment/3e47a09a_58cbf977?... : PS1, Line 209: getopt_refresh_flag = true; maybe set
cfg.refresh_flag = true
here. Then the new command line option can be used in a more general way. (at the moment we have no means to influence the refreshFlag from the commandline. Its always false.
-
dexter